From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 6BCA93858D33 for ; Wed, 17 Jan 2024 14:31:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6BCA93858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6BCA93858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705501868; cv=none; b=LOqRR8njKmTSkoq8Fzj5Enl6nZHYhaIM3vNQX9o3NLPMzX0E/gaMbluEUWi8OCgDTZrSdDZSNUX+pGoY3CW7i8+LWMNBFq4qKFtfnDb8OlA7s5CW/2NVbMF1gVALGrP970HUzFaQhotf4gu1mhHt/qqB19mLboqPS6DUh+FQY/E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705501868; c=relaxed/simple; bh=X0lkQD2LMzZsnA+oBOrQEkDAAJF2TMX7M1zwTThMUOI=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=vGoEnBjUvALqmGnUEG7fL1hLOesRPr2QWH8v8XchPOn0HzUmkv3g+WlRImI6Pc2PAWnB8uOIhquQlfCWXxlOdfUhlG0vOEjrbIQ0sOG0OiTKygmo2ho0nyqQ02Eno4uODxsts2T/57UXJgJ0CGcOU0zauEZTkSgvyvJGr1XDnuo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 720B21FC31; Wed, 17 Jan 2024 14:31:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705501866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i89v9hGYUKmw+wLCS3SPRTI4rHm+zPN4fYpkbJXkhOQ=; b=pVOrBUl4ryqi5eo2xJNz5kLKz5HF6r9Lo+p8EMsTYvvOKry7eTrCiaGtAMhh3vIba2th+G xYYJ0OQ86GoLk0x2L1QKB0ZroCb1RTkUHRukjqGkxkdrUSSCK1kMBZFYlsQ4Z5bbL+ueAJ qgbanBWeECyUxOBaB/6fUycaN/uIF/I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705501866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i89v9hGYUKmw+wLCS3SPRTI4rHm+zPN4fYpkbJXkhOQ=; b=9cJv8G3AuFlDGJGY0B44KBJnmjI5yplcEJbP5a+niJ021qj7uBccgaC1o8HGIGD9vAy4Xi 42iYVhtRiyToxUBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1705501866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i89v9hGYUKmw+wLCS3SPRTI4rHm+zPN4fYpkbJXkhOQ=; b=pVOrBUl4ryqi5eo2xJNz5kLKz5HF6r9Lo+p8EMsTYvvOKry7eTrCiaGtAMhh3vIba2th+G xYYJ0OQ86GoLk0x2L1QKB0ZroCb1RTkUHRukjqGkxkdrUSSCK1kMBZFYlsQ4Z5bbL+ueAJ qgbanBWeECyUxOBaB/6fUycaN/uIF/I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1705501866; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=i89v9hGYUKmw+wLCS3SPRTI4rHm+zPN4fYpkbJXkhOQ=; b=9cJv8G3AuFlDGJGY0B44KBJnmjI5yplcEJbP5a+niJ021qj7uBccgaC1o8HGIGD9vAy4Xi 42iYVhtRiyToxUBA== Date: Wed, 17 Jan 2024 15:25:58 +0100 (CET) From: Richard Biener To: Jan Hubicka cc: gcc-patches@gcc.gnu.org Subject: Re: Add -falign-all-functions In-Reply-To: Message-ID: <78r5nsrq-opq6-0spr-5043-n1n092q52995@fhfr.qr> References: <93nnq110-3974-p060-sp9p-q2pn0641687p@fhfr.qr> <72ssp99q-2447-6685-8307-n06499051o12@fhfr.qr> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -4.10 X-Spamd-Result: default: False [-4.10 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.99)[-0.986]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.01)[-0.048]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-3.00)[100.00%] X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 17 Jan 2024, Jan Hubicka wrote: > > > > I meant the new option might be named -fmin-function-alignment= > > rather than -falign-all-functions because of how it should > > override all other options. > > I was also pondering about both names. -falign-all-functions has the > advantage that it is similar to all the other alignment flags that are > all called -falign-XXX > > but both options are finte for me. > > > > Otherwise is there an updated patch to look at? > > I will prepare one. So shall I drop the max-skip support for alignment > and rename the flag? Yes. > Honza > > > > Richard. > > > > > > -flimit-function-alignment should not have an effect on it > > > > and even very small functions should be aligned. > > > > > > I write that it is not affected by limit-function-alignment > > > @opindex falign-all-functions=@var{n} > > > @item -falign-all-functions > > > Specify minimal alignment for function entry. Unlike @option{-falign-functions} > > > this alignment is applied also to all functions (even those considered cold). > > > The alignment is also not affected by @option{-flimit-function-alignment} > > > > > > Because indeed that would break the atomicity of updates. > > > > > > > > > Honza > > > > > > > > Richard. > > > > > > > > > + } > > > > > + > > > > > /* Handle a user-specified function alignment. > > > > > Note that we still need to align to DECL_ALIGN, as above, > > > > > because ASM_OUTPUT_MAX_SKIP_ALIGN might not do any alignment at all. */ > > > > > > > > > > > > > -- > > > > Richard Biener > > > > SUSE Software Solutions Germany GmbH, > > > > Frankenstrasse 146, 90461 Nuernberg, Germany; > > > > GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg) > > > > > > > -- > > Richard Biener > > SUSE Software Solutions Germany GmbH, > > Frankenstrasse 146, 90461 Nuernberg, Germany; > > GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg) > -- Richard Biener SUSE Software Solutions Germany GmbH, Frankenstrasse 146, 90461 Nuernberg, Germany; GF: Ivo Totev, Andrew McDonald, Werner Knoblich; (HRB 36809, AG Nuernberg)