From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by sourceware.org (Postfix) with ESMTPS id 9A40C3858D32; Thu, 7 Mar 2024 04:01:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A40C3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A40C3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::52f ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709784077; cv=none; b=Drbh/NENYJvLvuylMCMFAuEn8kTVEdDNhqczHumf25Zoc91j902SKgrVpb015TK8I5HwdSRzWL4fLw2a04HIUuHHYFJ7W6YPsst4T4nQKYgKIySFahXXVPeSA0HliIhItTMlnINCEameEKcLJkHK5yv6s5PrrIUWoAUkVaJMst4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709784077; c=relaxed/simple; bh=j3D1QgCfTTrcMSq/w3kvCpB1vBfLhOxp6+MFWNp7BSU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=XliGNU/2pfEi5FHW1eg5ZHOhK+PB57wJUG9/ORprJNTaH6drEm5RgHz4RMdO0WPzJALvqLY4mrXMg7hlVmEyOxF+iYn7SMvoC4vrKcDe8v15TGwfFjv+LFyDw7AhSZKMU3FKeJ4dnMLEk+A1dXz+oa7yeDDa37hZe+R7BFeiCpY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-5cfcf509fbdso184291a12.1; Wed, 06 Mar 2024 20:01:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709784073; x=1710388873; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1/cYGdHVSwjUmRQBSr3MP2KfTYBotyJ0bApk4ZsusxQ=; b=Ns4zesSRuRg0r9R0PGTYlyu+LPIl91WP3s9Cp9PKvo1AEmRADdcipR/ErQivEbUvab 9IBR0A/sfxgN6dncgraotqGSUc8A7d0HfQwo2H6NDzuJcK4s+3KjZAHqEAfE+U+B1w2Y 3kuwEdlEsdtwvUeE2FaUQ4YFNtbWrnH3zSRr8ONwh7lIioqr4M/GAY5spuIQqieqyuVQ LsjVp8pLEs8F9bCb3w1zc+EYubTdPTGwkVjABEYXsxNQqR01OOj2QG15TF0HD7/StHoU zgN2bRnHB6lVAow+gmVOSlGNHV5ne7lm7Cr7B13NaVnYQwhWDFOUREKt8nsKCYTNQLg8 Yp9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709784073; x=1710388873; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1/cYGdHVSwjUmRQBSr3MP2KfTYBotyJ0bApk4ZsusxQ=; b=pjXbgbozjPE9OOcbK9gt11cOgTKU6zi8tidO6DfWmV6dtUnCRy5+zR/bJt3ciB3pVp BRJCuRXi2Pqvb6fM6+fom0w5TlLEsi8src0jInbVNDKdO2HwzdX5ZYg0nAWyBapZWu85 SFm6xmwd+xiutFGIH3L7dyKK0pdd2uil6qLSRgh5HLyLWpCytTrN7bWXzmYKBg4+rd2f ngcAHlLZfCidL5TAP0eG9WrWNSZEuwMiwcaJO6mTowq3Wm+j3Z9lMtdet1vQOGQwh5dh avtj6uluH0xxRnfQYEtyK7QeAVaHGSUG1bJpYKIsaHSwD6bKwGAWIPH5jVJ8U0lHHHPR Emww== X-Forwarded-Encrypted: i=1; AJvYcCV2ciTZd5Y6Jn7DpMlePOM1Kphi2ubekFJZgoBs4/WIRUNeHJNJDpVN5nznGjkoC3T6PqE4JJwpS3961vTPZOGrAH9KvYaj1Q== X-Gm-Message-State: AOJu0YyI/B5WnbQ2o4zUiqAh84SS33kIxzlrYnePTkFZ231Mmlbiz6lx 7fNSYxtkF4c7x+iR/z8rrw6OKwsc3y5l14F6NGIwCVJlu3ldbT+5 X-Google-Smtp-Source: AGHT+IGroeuylYH0Y270a6jtzQ0UP2DthXC61DD3i1YdQVzPtcnrK6TWzTIBiJKfd2HRaE1HytpRcg== X-Received: by 2002:a17:902:d352:b0:1db:f23f:676c with SMTP id l18-20020a170902d35200b001dbf23f676cmr5586049plk.0.1709784073380; Wed, 06 Mar 2024 20:01:13 -0800 (PST) Received: from [192.168.1.20] ([50.37.177.113]) by smtp.gmail.com with ESMTPSA id n9-20020a170902d2c900b001d8f111804asm13409076plc.113.2024.03.06.20.01.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 20:01:12 -0800 (PST) Message-ID: <79209b29-a38c-41d6-bc4b-8448473f55de@gmail.com> Date: Wed, 6 Mar 2024 20:01:11 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [patch, libgfortran] Part 2: PR105456 Child I/O does not propage iostat Content-Language: en-US To: Harald Anlauf , gcc-patches@gcc.gnu.org Cc: fortran@gcc.gnu.org References: <943c3685-c4d4-4f22-8b65-6336f8770043@gmail.com> <20240229104705.62e46010@nbbrfq.loc> <033ebcdd-6e25-4af7-9012-3338978751d8@gmail.com> <05A1AEE6-6A68-4D4F-8BEA-6E87969E19E7@gmail.com> <65b13e02-bc1d-4cad-98cc-cf5d6090b742@gmail.com> <466d3d24-8795-488d-96ac-edb2fc04676a@gmx.de> From: Jerry D Autocrypt: addr=jvdelisle2@gmail.com; keydata= xjMEY5TlkxYJKwYBBAHaRw8BAQdAyrkRDhmJhSTTlV/50gJLlvliU6/Lm5C9ViKV8T9y1GnN HkplcnJ5IEQgPGp2ZGVsaXNsZTJAZ21haWwuY29tPsKJBBMWCAAxFiEEOFR0TS0390uh8dRV uWXAJaWpwWoFAmOU5ZMCGwMECwkIBwUVCAkKCwUWAgMBAAAKCRC5ZcAlpanBalsJAP4wdCiH 2Of9oZv1QWgZ/AVdbWFM3Fv47/WZQHOXfoZ9HgD6AkXrKeJ+6usST7PEaDJjptaViT1fLiYY V/6XaOKSsgLOOARjlOWTEgorBgEEAZdVAQUBAQdAdA7PczYnl07vnOT9oP/wvvMDd4HP09Zl g3LzwXQJWT8DAQgHwngEGBYIACAWIQQ4VHRNLTf3S6Hx1FW5ZcAlpanBagUCY5TlkwIbDAAK CRC5ZcAlpanBasF/AQCa5WjlsVpLsEiggZyT18MOJNAdeRd7wkGDUrwedHrvawD/cE1H+/Ms L1ZwvQiLfGdx8crigQqWTQyos4kH8Wx82wc= In-Reply-To: <466d3d24-8795-488d-96ac-edb2fc04676a@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/6/24 9:13 AM, Harald Anlauf wrote: > Hi Jerry, > > can you please replace the user message in e.g. your new testcase > pr105456-wf.f90 by say: > > piomsg="The users message containing % and %% and %s and other stuff" > > This behaves as expected with Intel, but dies horribly with gfortran > after your patch! > > Cheers, > Harald > > Fixed with: commit 03932d3203bce244edd812b81921c2f16ea18d86 (HEAD -> master, origin/master, origin/HEAD) Author: Jerry DeLisle Date: Wed Mar 6 19:46:04 2024 -0800 Fortran: Fix issue with using snprintf function. The previous patch used snprintf to set the message string. The message string is not a formatted string and the snprintf will interpret '%' related characters as format specifiers when there are no associated output variables. A segfault ensues. This change replaces snprintf with a fortran string copy function and null terminates the message string. PR libfortran/105456 libgfortran/ChangeLog: * io/list_read.c (list_formatted_read_scalar): Use fstrcpy from libgfortran/runtime/string.c to replace snprintf. (nml_read_obj): Likewise. * io/transfer.c (unformatted_read): Likewise. (unformatted_write): Likewise. (formatted_transfer_scalar_read): Likewise. (formatted_transfer_scalar_write): Likewise. * io/write.c (list_formatted_write_scalar): Likewise. (nml_write_obj): Likewise. gcc/testsuite/ChangeLog: * gfortran.dg/pr105456.f90: Revise using '%' characters in users error message. Jerry -