From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 771593858C98 for ; Wed, 28 Feb 2024 17:33:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 771593858C98 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 771593858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709141587; cv=none; b=R5ZOIfmuzrb1KtbJ5OxGq4u+gqGamx5gFVO5PwJA5Z5tsNhT4wHub9rvaTnm4gcAjHXIWfb0/C9SPQCTB1EINKP0LP2D97IGTFuMMGAmXv5jXiN8vQMW3pHO0f5eKRB/c+rSDdeEc0MFUHUj5PaXX0hgl8DbChsBAsLcNtfwExg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709141587; c=relaxed/simple; bh=uSbMBQk1Ip9XM3NgMYo5/C7y12RMW4roGL05X8IYERk=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=KdHvke9yAQbDP7HHmJtJffqxUa0YTi2AKXJ8/a4GexliI0yqWt1WHzCIYujP9oVzE530smiD0Cql/2LwSKGtghRK6ft0c9Wk794BpTjlU4lIrRCx0Er4CxlLbQm5/OwZ8CBloK3pnAbarlDdXPeQVsgmL8qGDWWji+SDcZqccO8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ot1-x333.google.com with SMTP id 46e09a7af769-6e445b4f80bso3154146a34.0 for ; Wed, 28 Feb 2024 09:33:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1709141584; x=1709746384; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=n7Jlgvvva3MyzyVTabtDmtmRr9/nVfccIjg9lXGnxf8=; b=cBHW34atse7NNCh1HFqvCI3+6BR3aut7k+SPiYr4PeUV8CXPCFBaNa0UzGLQhPoPqJ 9wlcDJqRGNs3CtiypKSl4+nRGrlbbyC0SYkUNnSQ7uyGVSvr90Q4hm9VoTyqX9J2JcWI v9pvhYnbWFMDycXAr5LIvnuFLlOm0k/edKQDhqmaJwSYhvZQ2p6CEr5TpSm9pTc+mCfD ie/hLBPoFrSAcctqPJ9UJJIUqZi7ySwi04iyIgEdgUhMc2kjYdZ73aC+goukFpJO94Qi QhIo4s06Lx14PDKWWwPSZCfeLI0m0vEBmfgJFvbWXulRpE2UjhfWFUyTA3npQDvlQGep 0whQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709141584; x=1709746384; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=n7Jlgvvva3MyzyVTabtDmtmRr9/nVfccIjg9lXGnxf8=; b=ZOJqeRQ0t4nIPSDngNSrHTkqmRJf5it3roPkaz4xMwqTfbcYQqfOHjqH2t52LZdGgG AGMy0TSjyYxpK7hQUgl7agta9xKnxHv1tT2xpVTjMkd3McdI3adJiKJdbcRUBPt4JX2w 5qehBGQK3YlNtCZdahLWveFyQIrwwTi8b6xF+AuZ7x1XSuCKNS+9yfiKh0JUrqQXTbTY KRuunogc5FySwHNOVA7D07m/0JiMsi1gCrk4Naplik6S18YK+N/oEb7I3CsYIwJS1enz cAbeneyxtewmSNjL+/n5meFdUxdj7iWrZE4lXHAlUmVq76/z2tIJ+XMpGTuemqRxZTE+ 1gfA== X-Forwarded-Encrypted: i=1; AJvYcCW22h/1pfR2PgYAyWxc8Z3AyOh9U3j2k4GpLCssPF+Gpg6k7pDGGNo29q+PCQ28eUXdiytyG6TOIHYX80m25meFNQBv89LGYA== X-Gm-Message-State: AOJu0Yw+QEM3shaxBhZg+Y1PanKrQtrRw7Bd1IEPeVjMsfbctCjh9AbD Z4TeRlauKWaeLfCHx/B6vzSnE68sAleDq0rike4Ojmmu0hi09dhm X-Google-Smtp-Source: AGHT+IEA8TEC3oCxncyjT+xO2/h3jJrHHXlPV7O9vV3dh+x387gTpfbUHu00xRSPxBj/icuygGFLSg== X-Received: by 2002:a05:6870:7d0b:b0:21f:dc71:c3f4 with SMTP id os11-20020a0568707d0b00b0021fdc71c3f4mr440305oab.43.1709141584665; Wed, 28 Feb 2024 09:33:04 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id z22-20020a056870e15600b0022043a35fb1sm924633oaa.8.2024.02.28.09.33.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Feb 2024 09:33:04 -0800 (PST) Message-ID: <793c14cb-2a08-41a4-ac55-4c39295f42d3@gmail.com> Date: Wed, 28 Feb 2024 10:33:02 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta Subject: Re: [PATCH v2] DSE: Bugfix ICE after allow vector type in get_stored_val Content-Language: en-US To: "Li, Pan2" , "gcc-patches@gcc.gnu.org" Cc: "juzhe.zhong@rivai.ai" , "kito.cheng@gmail.com" , "richard.guenther@gmail.com" , "Wang, Yanzhang" , "rdapp.gcc@gmail.com" , "Liu, Hongtao" References: <20240226032558.587912-1-pan2.li@intel.com> <20240226142235.3215553-1-pan2.li@intel.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/27/24 21:51, Li, Pan2 wrote: >> if (!targetm.modes_tieable_p (src_int_mode, src_mode)) >> return NULL_RTX; >> if (!targetm.modes_tieable_p (int_mode, mode)) >> return NULL_RTX; > > Yes, will return NULL_RTX for in the first if, given src_int_mode is E_DImode while src_mode is > E_V2SFmode and mode is E_V4QImode. The extract_low_bits convert the modes E_V2SFmode/E_V4QImode > to E_DImode/E_SImode in advance before tieable checking, validate_subreg and gen_lowpart. > > Not sure if my understanding is correct but looks extract_low_bits cannot take care of vector modes > up to a point because vector modes are always untieable to its' int mode, and then return NULL_RTX. Well, the code tries to turn the vector mode into a suitable integer mode via int_mode_for_mode. That takes a mode, including vector modes and tries to find an integer mode of the exact same size. So it's going to check if V2SF can be tied to DI and V4QI with SI. I suspect those are going to fail for RISC-V as those aren't tieable. Jeff