From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ebotcazou@libertysurf.fr>
Received: from smtp2-g21.free.fr (smtp2-g21.free.fr [212.27.42.2])
 by sourceware.org (Postfix) with ESMTPS id 52C753858C3B
 for <gcc-patches@gcc.gnu.org>; Wed, 15 Sep 2021 10:23:13 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 52C753858C3B
Authentication-Results: sourceware.org; dmarc=none (p=none dis=none)
 header.from=libertysurf.fr
Authentication-Results: sourceware.org; spf=none smtp.mailfrom=libertysurf.fr
Received: from fomalhaut.localnet (unknown
 [IPv6:2a01:e0a:41b:84f0:cf71:f5e0:b050:bede])
 by smtp2-g21.free.fr (Postfix) with ESMTP id 50C0C20039E;
 Wed, 15 Sep 2021 12:23:07 +0200 (CEST)
From: Eric Botcazou <ebotcazou@libertysurf.fr>
To: Daniel Cederman <cederman@gaisler.com>
Cc: gcc-patches@gcc.gnu.org, daniel@gaisler.com
Subject: Re: [PATCH 1/4] sparc: Treat more instructions as load or store in
 errata workarounds
Date: Wed, 15 Sep 2021 12:23:02 +0200
Message-ID: <7962862.T7Z3S40VBb@fomalhaut>
In-Reply-To: <20210915093610.3112669-3-cederman@gaisler.com>
References: <20210915093610.3112669-1-cederman@gaisler.com>
 <20210915093610.3112669-3-cederman@gaisler.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 KAM_LAZY_DOMAIN_SECURITY, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,
 RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE,
 TXREP autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Sep 2021 10:23:14 -0000

> gcc/ChangeLog:
> 
>         * config/sparc/sparc.c (store_insn_p): Add predicate for store
>         attributes.
>         (load_insn_p): Add predicate for load attributes.
>         (sparc_do_work_around_errata): Use new predicates.

OK everywhere on principle, but can we avoid the multiple calls to 
get_attr_type?  See div_sqrt_insn_p and fpop_insn_p for a model.

-- 
Eric Botcazou