From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id 9DFF33858D1E for ; Wed, 14 Jun 2023 09:42:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9DFF33858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.00,242,1681200000"; d="scan'208";a="9824875" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa1.mentor.iphmx.com with ESMTP; 14 Jun 2023 01:42:27 -0800 IronPort-SDR: gCC3owc82svY/mHSLmoBJ0psN/nOPrpuCRx/7QIhxb5MUFM3sFmMXPxBIOa8BhcTUoY3vs2baR FzuFcRwKcMx7Otmpt/9LTvNpVOllrUcBn3MgB3wz7HdKr3T9z9og5Jh6twu4u6PCMYZ9NdxmHu zX0siInBzf0A0Pa9QE2PXZBMvvO50xQH4geJGMfVc8Cjc54QpI/YTves7IE2VBCz30BdhGZF5n pMCIe+VE+trZQba5n3lRP/p9BXFI2Lf24HzTcBaBRAl5+wpswnUjdNiy5URb16FoLIxBoxL6kl 4sk= Message-ID: <797c2a73-46e5-65f2-7098-a2ed59f6c90d@codesourcery.com> Date: Wed, 14 Jun 2023 11:42:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: Fix typo in 'libgomp.c/target-51.c' (was: [patch] OpenMP: Set default-device-var with OMP_TARGET_OFFLOAD=mandatory) Content-Language: en-US To: Thomas Schwinge , References: <1487d7d4-8611-0d78-6bf2-9bffdd4daa64@codesourcery.com> <87pm5y31p6.fsf@euler.schwinge.homeip.net> From: Tobias Burnus In-Reply-To: <87pm5y31p6.fsf@euler.schwinge.homeip.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 14.06.23 10:09, Thomas Schwinge wrote: > This reminds me of the (unresolved)https://gcc.gnu.org/PR81886 > "Means to determine at runtime foffload targets specified at compile time= ". I think there is the problem that we also support offloading in libraries. Thus, if you compile the main program without offloading and then link in a shared offloading-providing library (possibly with dlopen), it comes (too) late. Thus, we either exclude devices which could be later used =E2=80=93 or we have to live with providing devices (existing in hardware and with libgomp support) for which no executable code is available. As long as the number of devices is not a dynamic property, I guess we can only handle one or the other. > I intend to push the attached "Fix typo in 'libgomp.c/target-51.c'" > after testing. > Let me know if I should also adjust the new 'target { ! offload_device }' > diagnostic "[...] MANDATORY but only the host device is available" to > include a comma before 'but', for consistency with the other existing > diagnostics (cited above)? I think it makes sense to be consistent. Thus: Yes, please add the commas. Thanks, Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955