From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 50A5538582B7 for ; Fri, 2 Feb 2024 12:29:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50A5538582B7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50A5538582B7 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706876967; cv=none; b=Lgc9qxYnIE7Tp6BdGKX18MRFZHPvngivNZtZoFePOC/S7Fxha400hJoBIn68zyM0XTY98pT/l6RHrcoJ7JMqIizyAHPWJ52asROUddKPnE2a71vmfQlcMISgml7Qews+Gs0SQNf0zfJjLuslWFT8KZx/v2zPUyE/YcMrAeuiVyo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706876967; c=relaxed/simple; bh=7oR9MKHeSFAiZPNAAq/a8OOXkCE0yTvDV7Nm4Pih5jc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=wTD9evOaT2cq9zIeuupTV0Rxkr+w8mvSUmmCKH5Sw0iZwrv88bA0eLjaAxKuLaMalPNFvNSDWicTccgy6CDY+apj6r7Dcc2Z6z9FaO/Gq7Ez7khMFmGrLA6Uyl/g68JfYKOk5ZpDXD+kmTi0IOTVfgtb9Hp762nMPb7B2WmpggA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706876966; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BHJBjWeMOsx4DFjRTll/DYbI9vMZBor+8L7u7e5GEI0=; b=HHHpNRN/E2TSS0cC+sTooRQtEkFphiEjs2UYubPz9Uy3eCcBneV8Wb/EXjw6zCyDE4e9NJ Zz6sKYVOKRS5KN9k2cAYpr1bjxWqjmUoRc/aSKxLWCV8OYQA+J4N/sfCR5fiQ+bw4fGc4p wXifgmZ2ftYVRTnCcyvJLP+mvs4hPyw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-bRfcaCGzOZahdTVSZlzbtQ-1; Fri, 02 Feb 2024 07:29:23 -0500 X-MC-Unique: bRfcaCGzOZahdTVSZlzbtQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-40ef9e08fffso10598875e9.0 for ; Fri, 02 Feb 2024 04:29:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706876962; x=1707481762; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BHJBjWeMOsx4DFjRTll/DYbI9vMZBor+8L7u7e5GEI0=; b=ZkGYcon/kYxCJnb/DxXAlx1ZXY6wMHHXbbwua5v6cTbJ8rm/oe+G/aiJU5Zo7rAVMn t3Osnwq5P3uJi+t3+znTjT+pfa+yu5sGp9xN4hSdSPjLO573MW6j2MB4TG4sQHIk9CFu FJNAS21aMugDNWii+xP+XlATXHN2TrsqiEVz6sKGhgxEOby/12YZ/97rF69wSTwlooY3 s3IVvEbrOpaiHzQoNtMKYqlQa35FY/1NzVyXZJff8yvNg376AO4VfEIYDd2zRo+3obhg dzMfBIiLmvUMM2uCPMRuWYz6SUvgV6j4amUOUBpbtUkparVHVokT7IPQw7YKu8CywF6w 6iPw== X-Gm-Message-State: AOJu0YyEfnlml+ldIZQzvR2smw/FFb80IHwerriNZkw+YTPjMoBTjetJ +Ydfg1T/jWJno/2aVeGcIKndphhFHoWgn6OA0ckL097dKkfVhFY71OQtPIdxlPHWmOHCheFCxmO aukTqiRoL02fbR9ZPYEwHYpEbNeeodqTLsc/vE5cjUsp4cqKVBXwRxs4= X-Received: by 2002:a05:600c:3b20:b0:40f:37da:b878 with SMTP id m32-20020a05600c3b2000b0040f37dab878mr4291881wms.27.1706876962687; Fri, 02 Feb 2024 04:29:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IEoQVoyv6/InqN20tGa1v0C3stW+uoCWP67jEADzX+E2aTwHj+kSE+BDxmSqLtGOkH81MtaLg== X-Received: by 2002:a05:600c:3b20:b0:40f:37da:b878 with SMTP id m32-20020a05600c3b2000b0040f37dab878mr4291863wms.27.1706876962344; Fri, 02 Feb 2024 04:29:22 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCWf70Ue8akaaAPVHuZxWwqXzVerCzKDI5Tsey00/nBLWXLKRqeRciwdhAwksQEBSJhT2uimTcxhgVNYXZoOGNSi6oNW8FsNnQ3D9ceaCRW7P6RGoa100Ryo/KUZ3P+CphOQXvkMLsZe7DFP4RdIgwCzKHmLrn3NSfPY0hgI51BA Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id r18-20020a056000015200b0033aedfc5581sm1846625wrx.32.2024.02.02.04.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 04:29:22 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rVsew-00Bv9E-Pn; Fri, 02 Feb 2024 12:28:42 +0000 Date: Fri, 2 Feb 2024 12:28:42 +0000 (UTC) From: Joseph Myers To: Bernhard Reutner-Fischer cc: gcc@gcc.gnu.org, ubizjak@gmail.com, hubicka@ucw.cz, hjl.tools@gmail.com, gcc-patches@gcc.gnu.org Subject: Re: [Patch, stage-1, RFC]: i386: attribute regparm/stdcall and vaargs In-Reply-To: <20240202115331.37b4a158@nbbrfq.loc> Message-ID: <79d178f-1b83-3dfc-7515-ccb1996de379@redhat.com> References: <20240130001434.35b2b856@nbbrfq.loc> <2a473ec9-950-a775-4e48-6c893202653@redhat.com> <20240202115331.37b4a158@nbbrfq.loc> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, 2 Feb 2024, Bernhard Reutner-Fischer via Gcc wrote: > Hi Joseph! > > On Tue, 30 Jan 2024 14:54:49 +0000 (UTC) > Joseph Myers wrote: > > > On Tue, 30 Jan 2024, Bernhard Reutner-Fischer via Gcc wrote: > > > > > * builtin-attrs.def (ATTR_TM_NOTHROW_RT_LIST): Use ATTR_NOTHROW_LIST > > > instead of ATTR_TM_NOTHROW_LIST, thus removing ATTR_TM_REGPARM. > > > > That doesn't make sense. ATTR_TM_NOTHROW_RT_LIST is specifically a > > transactional memory attribute list, but you're removing all transactional > > memory attributes from it. A list without the "*tm regparm" internal > > attribute would have a different name. > > > > AFAICS there is no pre-existing attr list with just returns_twice and > nothrow. Would ATTR_NOTHROW_RT_LIST be more appropriate as name, and > should i move this up to before the format attribute lists, before > DEF_FORMAT_ATTRIBUTE? Yes, both of those seem appropriate for such an attribute list. I do not know what attributes are appropriate for _ITM_beginTransaction. -- Joseph S. Myers josmyers@redhat.com