From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id C3D1B3858436 for ; Wed, 6 Mar 2024 13:59:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C3D1B3858436 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C3D1B3858436 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709733560; cv=none; b=oas+1H7IsiC9zcYhh4TyuiFLuo2R8jsnLmbzwJFgyFLKqAuQGOPBT9bsOMwFK3RDEFhDYQ7MXZsfdmTwZGAxMxuQdLw+k+rxHqCTw3E1ZojeoNJCPZoLeOd2MYytEvFEZOAEYqVgWVE+6ByKbGByBkRMc+xFVQrpVYFkywGOsNM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709733560; c=relaxed/simple; bh=637ODeNt6R6qf+aIHqsV9d8T/a1u7KmfPjjXKdg+bzE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=kJdgClXXOpeojkhchoL41lIr5xVCA/tOqiC6CwKVrlw2AYTb8xKJ9Gjryh1E/DLtf/P5w0OzfU+99W7R5tiFU+KNfM3KeAAQUGPAgZDKvZWxO1xlJbPuTgue5PtGvanRsIdiTUvSNK1Q/AyfNhPMDr+bmB2l0lxowkYeXHsjSbk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709733559; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8o06dwcBIsQz3G03TvNWG3011qZGHWLD1y2XQRWfLCg=; b=R7GERCAZsQsR+0iHogEJI5vUio0YlK6PD3GDW++DWqDNC7q+e+siI34l6TTvV3MatLDc0b 9ZTO/RRHQ6SiotrA30T1DAwEYg1aCp4sNKZ4sw1cH3xJS8F/p3kA65AJ9wVsFEyavLSaRw 9vMhCVzGwy8XlL0qRJtyXvYDFpQQl4c= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-oWU6DQrBNmWK6HhfDg2QDw-1; Wed, 06 Mar 2024 08:59:18 -0500 X-MC-Unique: oWU6DQrBNmWK6HhfDg2QDw-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-42eea8e559fso34390951cf.3 for ; Wed, 06 Mar 2024 05:59:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709733557; x=1710338357; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8o06dwcBIsQz3G03TvNWG3011qZGHWLD1y2XQRWfLCg=; b=CbqfY05QtH3n+aeVbO/Ri4Gaxc0tiv0VioMqAyqsBiQl5/U8qK1p2LOWVKyHg9eIy1 rToQc7lJ/xfay6fqDQcI8zDabtKKchGTHsw13G3FK9x3yd3KQ33pr9BOgdSI2ibZSzuD XsA8ihtJ8oshj9BFXYHcjfIKkzMWQ+6ygNJ/+9I3CYY1/3kH/a7nK4WF/8m05rvHJMNG bt03d3ImfFz7Ju6ukg5U1uNqZPcpTMk5sihdxvUq7hKM7/fmBQ4y8CtjZmXA4ONNXVer ZF+mO29+uevEvHQBE4QzVe6p6RxMS4II/32Z4jZfdOGV3jJTOHJnJv2rBiffBog7f/cz Sbqw== X-Forwarded-Encrypted: i=1; AJvYcCV6NK5ZWUlpMUVMrdEkyS+nH4e958Up1clu2/4C11bYJdV5opMoUGvFIKNxhu/Ndkunk/evZxFTKSwIdtEPmWQJhBqMRMRGVw== X-Gm-Message-State: AOJu0YzkpOLGQIkCr7KjM6fOK6UGfjUvLHfp+0oS5E+dQ9kacHWKXxwJ nwMJ4DUSCtT1FFQWuIkSeTXat0f2jUYOZr0AtxjtGZQo+68Uury/JVHo1lVeD1zg7R3jeMA4qZU fwDtFM1hPk8mcXecL8j+dwQ9iTlNQul6RyPLFYCiVcdAGfBfZMbYvXRs= X-Received: by 2002:ac8:7d44:0:b0:42e:76fd:dbba with SMTP id h4-20020ac87d44000000b0042e76fddbbamr5764633qtb.10.1709733557748; Wed, 06 Mar 2024 05:59:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IE4Xm2xTN3JpEIpz7lguNqnooSzTaByQvuq0OvD+hlti46fd1/cjz4d3t6bx3UO7vhnLuXSkw== X-Received: by 2002:ac8:7d44:0:b0:42e:76fd:dbba with SMTP id h4-20020ac87d44000000b0042e76fddbbamr5764617qtb.10.1709733557403; Wed, 06 Mar 2024 05:59:17 -0800 (PST) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id h5-20020a05620a10a500b00788435ab818sm139929qkk.0.2024.03.06.05.59.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Mar 2024 05:59:16 -0800 (PST) Message-ID: <79dad146-1efb-433c-97f8-83997cc4b51f@redhat.com> Date: Wed, 6 Mar 2024 08:59:16 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c++/modules: Prevent emission of really-extern vtables in importers [PR114229] To: Nathaniel Shead , gcc-patches@gcc.gnu.org Cc: Nathan Sidwell , Patrick Palka References: <65e7ddc4.170a0220.d647a.c749@mx.google.com> From: Jason Merrill In-Reply-To: <65e7ddc4.170a0220.d647a.c749@mx.google.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/5/24 22:06, Nathaniel Shead wrote: > Bootstrapped and regtested on x86_64-pc-linux-gnu, OK for trunk? > > -- >8 -- > > Currently, reading a variable definition always marks that decl as > DECL_NOT_REALLY_EXTERN, with anything else imported still being > considered external. This is not sufficient for vtables, however; for an > extern template, a vtable may be generated (and its definition emitted) > but nonetheless the vtable should only be emitted in the TU where that > template is actually instantiated. Does the vtable go through import_export_decl? I've been thinking that that function (and import_export_class) need to be more module-aware. Would it make sense to do that rather than stream DECL_NOT_REALLY_EXTERN? Jason