From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by sourceware.org (Postfix) with ESMTP id 76D4D385040D for ; Wed, 16 Dec 2020 03:31:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 76D4D385040D Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-65-x63R5f0ENROmaJt5nFP2Yg-1; Tue, 15 Dec 2020 22:31:40 -0500 X-MC-Unique: x63R5f0ENROmaJt5nFP2Yg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D621F15722; Wed, 16 Dec 2020 03:31:39 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-161.phx2.redhat.com [10.3.112.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82F7360C17; Wed, 16 Dec 2020 03:31:39 +0000 (UTC) Subject: Re: [PATCH 22/23] Add rtl-ssa To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com References: From: Jeff Law Message-ID: <79f3b9a3-423e-72f4-81b5-84dc65a9b6e9@redhat.com> Date: Tue, 15 Dec 2020 20:31:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Dec 2020 03:31:53 -0000 On 11/13/20 1:23 AM, Richard Sandiford via Gcc-patches wrote: > This patch adds the RTL SSA infrastructure itself. The following > fwprop.c patch will make use of it. > > gcc/ > * configure.ac: Add rtl-ssa to the list of dependence directories. > * configure: Regenerate. > * Makefile.in (rtl-ssa-warn): New variable. > (OBJS): Add the rtl-ssa object files. > * emit-rtl.h (rtl_data::ssa): New field. > * rtl-ssa.h: New file. > * system.h: Include when INCLUDE_FUNCTIONAL is defined. > * rtl-ssa: New directory. So I know its late in stage3, but I think the risks here are relatively minor as this would only be used in fwprop right now and it was posted in advance of the deadline. My high level questions/concerns have been addressed and while I strongly suspect we'll have to iterate on infrastructure, I think we can do that on demand as passes start to use the infrastructure and we have a clearer picture of what tweaks we need to make for the clients. Obviously we'll want to keep an eye on testresults, but again, the potential for fallout here is relatively minor IMHO.  OK for the trunk. Jeff