From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 0E6403858D1E for ; Wed, 19 Apr 2023 02:45:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0E6403858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0187473.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33J14si8013906; Wed, 19 Apr 2023 02:45:38 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pp1; bh=4MMH2GNmO4TyZO+7DYbGQhuU8O6GBXvWPUqcPcKOE00=; b=nLkhj+5L4D0RXvqKb0TXgJXiEtUN6iKS00uJkvvELkFkkPKQ96zpmrJJwxbwzNfYAYwT dzcKrzORwNxusEK59UNYacHqCbm+3DckU8H4JNpFllb0Fkk9t+e8OkvpYhXxBbKY7mjh qjH55q6SbRpFLtCtj3hH5WAMYso/6vh8MvBdZmDdJozLzvTkTQJinLaWf+H57rRGQa6k rEFfEUxA49e6KlKU/pV1YdFHX7tDfxAkjv5p5F1AhrQeTQTe/+FtvqqsF+SzkuYcFh4Q 5eVsbfpTmhfT6/dhjir+EKthW8fPzJ+BpqSoxp5rDzk4sr7L6qqqEXMfkFBq4SD/uvBH PQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q1psy7hnu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Apr 2023 02:45:37 +0000 Received: from m0187473.ppops.net (m0187473.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33J2fxJC005548; Wed, 19 Apr 2023 02:45:36 GMT Received: from ppma03ams.nl.ibm.com (62.31.33a9.ip4.static.sl-reverse.com [169.51.49.98]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3q1psy7hn4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Apr 2023 02:45:36 +0000 Received: from pps.filterd (ppma03ams.nl.ibm.com [127.0.0.1]) by ppma03ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33J0WAs5000870; Wed, 19 Apr 2023 02:45:34 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma03ams.nl.ibm.com (PPS) with ESMTPS id 3pykj6jd6d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 19 Apr 2023 02:45:34 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33J2jV6Z25559656 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 19 Apr 2023 02:45:31 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 14FA420043; Wed, 19 Apr 2023 02:45:31 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id DE71A2004B; Wed, 19 Apr 2023 02:45:28 +0000 (GMT) Received: from [9.177.26.173] (unknown [9.177.26.173]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 19 Apr 2023 02:45:28 +0000 (GMT) Message-ID: <79f70af8-16a2-92ed-60b6-0cd7c170abfe@linux.ibm.com> Date: Wed, 19 Apr 2023 10:45:27 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH-1, rs6000] xfail float128 comparison test case that fails on powerpc64 [PR108728] Content-Language: en-US To: HAO CHEN GUI Cc: Segher Boessenkool , David , Peter Bergner , gcc-patches References: From: "Kewen.Lin" In-Reply-To: Content-Type: text/plain; charset=UTF-8 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 48dLSYU3TwizfNnY1kRD6trVRrUbHSA- X-Proofpoint-ORIG-GUID: S7fOB668nvMGw7yVnKCQYRHXC2HrjLXv Content-Transfer-Encoding: 7bit X-Proofpoint-UnRewURL: 0 URL was un-rewritten MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-18_17,2023-04-18_01,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 lowpriorityscore=0 malwarescore=0 bulkscore=0 phishscore=0 impostorscore=0 adultscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304190021 X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Haochen, on 2023/4/18 11:13, HAO CHEN GUI wrote: > Hi, > This patch xfails a float128 comparison test case on powerpc64 > that fails due to a longstanding issue with floating-point > compares. > > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684 for more > information. > > The case is xfailed when instructions of float128 hardware are > generated. When software simulation is used, the case should pass. IMHO we should make the comments here (commit log) clearer, like: when float128 hardware gets supported (-mfloat128-hardware takes effect), xscmpuqp is generated for comparison which is unexpected. "When software simulation is used, the case should pass" is not so right, I would interpret the use of __lekf2 as software simulation, we have to xfail this too when the _hw version is used during runtime, please make it clearer. > > The patch passed regression test on Power Linux platforms. > > Thanks > Gui Haochen > > ChangeLog > rs6000: xfail float128 comparison test case that fails on powerpc64. > > This patch xfails a float128 comparison test cases on powerpc64 that > fails due to a longstanding issue with floating-point compares. > > See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=58684 for more information. > > gcc/testsuite/ > PR target/108728 > * gcc.dg/torture/float128-cmp-invalid.c: Add xfail. > > patch.diff > diff --git a/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c b/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c > index 1f675efdd61..7b520d1f9f1 100644 > --- a/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c > +++ b/gcc/testsuite/gcc.dg/torture/float128-cmp-invalid.c > @@ -1,5 +1,5 @@ > /* Test for "invalid" exceptions from __float128 comparisons. */ > -/* { dg-do run } */ > +/* { dg-do run { xfail { ppc_float128_hw || { ppc_cpu_supports_hw && p9vector_hw } } } } */ This change looks good to me, though personally I prefer dg-xfail-run-if as we can specify one associated comment with it. :) BR, Kewen > /* { dg-options "" } */ > /* { dg-require-effective-target __float128 } */ > /* { dg-require-effective-target base_quadfloat_support } */