From: Vladimir Makarov <vmakarov@redhat.com>
To: Lehua Ding <lehua.ding@rivai.ai>,
Richard Biener <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com, juzhe.zhong@rivai.ai
Subject: Re: [PATCH V3 1/7] df: Add DF_LIVE_SUBREG problem
Date: Tue, 14 Nov 2023 12:18:51 -0500 [thread overview]
Message-ID: <79fd4731-89ea-7d5c-371c-eff768f1a30f@redhat.com> (raw)
In-Reply-To: <1A588F107664DFA6+96d02d06-07bd-4e79-9493-5e0824d672dd@rivai.ai>
On 11/14/23 03:38, Lehua Ding wrote:
>
>
> This is perfectly fine, the code inside the live_subreg problem has a
> branch that goes through similar logic to live_reg if it finds no
> subreg inside the program. Then when the optimization level is less
> than 2, it doesn't track the subreg. By the way, I'd like to ask you
> if you have certain programs where RA has a big impact on compilation
> time to offer? Or any suggestions about it?
>
I've analyzed effect of your patches to -O2 compilation time on
compilation of some old version of combine.c. The total GCC compilation
time increased by about 3%. I used x86_64 release mode compiler. Here
are my more detail findings:
RA compile time increased by 43%.
54% of this increase is due df_analyze time increase and 38% is due to
overall ira_color increase (assign_hard_reg execution time increased in
50 times but still such big increase is 1/3 of overall ira_color increase).
The rest (about 10%) of overall RA increase is mostly LRA increase due
to lra_create_live_ranges.
To see where 6% GCC compilation time increase on SPEC2017 is spent would
be more interesting but it needs a lot of time for analysis.
next prev parent reply other threads:[~2023-11-14 17:18 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 12:08 [PATCH V3 0/7] ira/lra: Support subreg coalesce Lehua Ding
2023-11-12 12:08 ` [PATCH V3 1/7] df: Add DF_LIVE_SUBREG problem Lehua Ding
2023-11-13 22:38 ` Vladimir Makarov
2023-11-14 8:14 ` Richard Biener
2023-11-14 8:38 ` Lehua Ding
2023-11-14 9:03 ` Richard Biener
2023-11-14 14:52 ` Vladimir Makarov
2023-11-14 17:18 ` Vladimir Makarov [this message]
2023-11-14 18:29 ` Vladimir Makarov
2023-11-20 20:11 ` Richard Sandiford
2023-11-21 6:35 ` Lehua Ding
2023-11-12 12:08 ` [PATCH V3 2/7] ira: Switch to live_subreg data Lehua Ding
2023-11-14 20:26 ` Vladimir Makarov
2023-11-12 12:08 ` [PATCH V3 3/7] ira: Support subreg live range track Lehua Ding
2023-11-14 20:37 ` Vladimir Makarov
2023-11-12 12:08 ` [PATCH V3 4/7] ira: Support subreg copy Lehua Ding
2023-11-16 21:13 ` Vladimir Makarov
2023-11-17 2:06 ` Lehua Ding
2023-11-17 14:05 ` Vladimir Makarov
2023-11-18 8:00 ` Lehua Ding
2023-11-18 8:06 ` Sam James
2023-11-18 8:16 ` Lehua Ding
2023-11-18 8:24 ` Sam James
2023-11-18 8:27 ` Lehua Ding
2023-11-12 12:08 ` [PATCH V3 5/7] ira: Add all nregs >= 2 pseudos to tracke subreg list Lehua Ding
2023-11-16 21:14 ` Vladimir Makarov
2023-11-12 12:08 ` [PATCH V3 6/7] lra: Switch to live_subreg data flow Lehua Ding
2023-11-12 12:08 ` [PATCH V3 7/7] lra: Support subreg live range track and conflict detect Lehua Ding
2023-11-13 16:43 ` [PATCH V3 0/7] ira/lra: Support subreg coalesce Dimitar Dimitrov
2023-11-15 2:10 ` Lehua Ding
2023-11-13 19:37 ` Vladimir Makarov
2023-11-14 5:37 ` Lehua Ding
2023-11-14 23:33 ` Peter Bergner
2023-11-14 23:22 ` Peter Bergner
2023-11-15 3:12 ` Lehua Ding
2023-11-15 3:33 ` Peter Bergner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79fd4731-89ea-7d5c-371c-eff768f1a30f@redhat.com \
--to=vmakarov@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=juzhe.zhong@rivai.ai \
--cc=lehua.ding@rivai.ai \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).