From: Richard Biener <rguenther@suse.de>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] cfgrtl: Fix up -g vs. -g0 code generation -flto differences in fixup_reorder_chain [PR104589]
Date: Wed, 2 Mar 2022 10:44:48 +0100 (CET) [thread overview]
Message-ID: <79p9472-95s3-on73-846n-ss959r466395@fhfr.qr> (raw)
In-Reply-To: <Yh86TlG8jY3rPi85@tucnak>
On Wed, 2 Mar 2022, Jakub Jelinek wrote:
> Hi!
>
> This is similar to PR104237 and similarly to that, no testcase included
> for the testsuite, as we don't have a framework to compile/link with
> -g -flto and -g0 -flto and compare -fdump-final-insns= results from
> the lto1 compilations.
>
> With -flto, whether two location_t compare equal or not and just
> express the same location is a lottery.
>
> Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux,
> ok for trunk?
OK.
Richard.
> 2022-03-02 Jakub Jelinek <jakub@redhat.com>
>
> PR rtl-optimization/104589
> * cfgrtl.cc (fixup_reorder_chain): Use loc_equal instead of direct
> INSN_LOCATION comparison with goto_locus.
>
> --- gcc/cfgrtl.cc.jj 2022-02-04 14:36:54.068618386 +0100
> +++ gcc/cfgrtl.cc 2022-03-01 16:11:06.307419636 +0100
> @@ -4090,7 +4090,7 @@ fixup_reorder_chain (void)
> && (!NONDEBUG_INSN_P (insn) || !INSN_HAS_LOCATION (insn)))
> insn = PREV_INSN (insn);
> if (insn != end
> - && INSN_LOCATION (insn) == e->goto_locus)
> + && loc_equal (INSN_LOCATION (insn), e->goto_locus))
> continue;
> if (simplejump_p (BB_END (e->src))
> && !INSN_HAS_LOCATION (BB_END (e->src)))
> @@ -4112,7 +4112,7 @@ fixup_reorder_chain (void)
> while (insn != end && !NONDEBUG_INSN_P (insn))
> insn = NEXT_INSN (insn);
> if (insn != end && INSN_HAS_LOCATION (insn)
> - && INSN_LOCATION (insn) == e->goto_locus)
> + && loc_equal (INSN_LOCATION (insn), e->goto_locus))
> continue;
> }
> nb = split_edge (e);
>
> Jakub
>
>
--
Richard Biener <rguenther@suse.de>
SUSE Software Solutions Germany GmbH, Maxfeldstrasse 5, 90409 Nuernberg,
Germany; GF: Ivo Totev; HRB 36809 (AG Nuernberg)
prev parent reply other threads:[~2022-03-02 9:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 9:35 Jakub Jelinek
2022-03-02 9:44 ` Richard Biener [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79p9472-95s3-on73-846n-ss959r466395@fhfr.qr \
--to=rguenther@suse.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).