From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by sourceware.org (Postfix) with ESMTPS id 4DFEB3858431 for ; Sat, 23 Mar 2024 10:16:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4DFEB3858431 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4DFEB3858431 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::629 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711188983; cv=none; b=gL7O+Y16Ol/UnNQ3O/G/xTf4g3cOv2Z7YAbWY81xO2NO68nVtNoCNs7CGbHpeYMlDapXHxQ7QNOGokmu5vbhNFs8TS/7vPlSEZZw41qXIKH8+Z2uy6w5t+IqOW6yBaYI7ix1b96xvd7dHCjylCMhk0RFH0Z9+SOH81ahZr7/ikI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711188983; c=relaxed/simple; bh=KI+cIqq1qKGUX7kRvq028j5xvh6yfwPd1Gx5kaPTg/E=; h=DKIM-Signature:From:Mime-Version:Subject:Date:Message-Id:To; b=JS8tss1TcrIQfZEZDIO3hBGBgksqUIklhrtaRk/ztxfxbjVKEaK7E0VMtrDcTphLdMvMfbTvpYULc3EwfhQFJEnMZgOKv0ozTPBeGdMuOnKn2cqRYg2DzPqUJoNoMJT0gRqN7Mn8guXoUoiKroIyK6MaywCOjLxghVj39zCxIUs= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a44ad785a44so338789566b.3 for ; Sat, 23 Mar 2024 03:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1711188980; x=1711793780; darn=gcc.gnu.org; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:from:to:cc:subject:date:message-id :reply-to; bh=mQSm/Mgz3j0LrQLp/RjtS5yH1sE28wJB7jm90CWCzes=; b=Cp+NcAc1kdMdaebPVo7+DThx8pbJhOmgbUJiOHbloWWREFAJJjHcsa3Pbpe2F1F7Yy LoPNZ0bxr9SF7Q/1rlvHpjrYQOJyndYsMZixlweX5CYH7SV/RxKvfFz69/8SxUIzevH2 sdWflmsryCkF6KQ41zwKg69ASd3lev5ESnwxdDg/WRphDC59z1Su3Hl5pz3IDA0Hrf2y HTciUKQ6vv9aaMQKq8XGG5LKOQw9JUFW+Nwm3acyy/Ft8xZNhkuAzdkFepOo2mwPuDjY hqO6w+9AawZRIjoxYQZ+0v+vYJojmaU3Cmsgpa0UvC/+lm5ZrtZkFvVp1HEy/FeJ2mRd 6+vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711188980; x=1711793780; h=to:in-reply-to:cc:references:message-id:date:subject:mime-version :from:content-transfer-encoding:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mQSm/Mgz3j0LrQLp/RjtS5yH1sE28wJB7jm90CWCzes=; b=kBERNhrMn29Sfv3ebLOXoTq9teoJcnyJTNhnk/aHwLKmBeO+cG3MH3imeFHBWT0dZM VpAgDz53PguCwzsRpgVXDkzcFBNMDxP9pbNliRHlRhIVKBbUkqWUhkVv1dQAol7GW8yV 4qls/+KU5rMlQRcERy8W9BDUE7Ytql2cUAsVEm8nHb7I5j8zDZzowbxCYXins96q1vX4 OfvDEInMXwzirN6l9snkYRWpuK9WWDD4j4OYujA3eLmUdsRVfQ4OTn2CYk4FXs01hMED M8VTJfgaJP+Ogbvn1l2MMnMDw276CeCJSMa9n/Qqix4fkASVsNLzUEAZ5pA2x/ra1yvV 0BSw== X-Forwarded-Encrypted: i=1; AJvYcCWhpVmFMRYrpBjOLGtkdvCWCKDa6JkHxFuSoAlh9eub3XXjLYc9/hgy0+9L0tRzmxPTupqv+Apxfw+nBCIqWYHqpayB7WS9vQ== X-Gm-Message-State: AOJu0YzLq8gqSFktVOPeNSpo3Myj0fLhTeVIX2OkVhtDfP3JpuPipOfc C3l+idlknjGsIBxDK2Mc63ht44kLv5xrjZ+FPEo3DeWG2QTQ/nGxPhLnwcho X-Google-Smtp-Source: AGHT+IGo4eHN+H8cE/R5uHRlHZ+7tRUUkmnc1IAagoF7eereDkdzisAm1irf4NwJ+K3t+JGOVqR8Kw== X-Received: by 2002:a17:906:b001:b0:a47:fdd:e97d with SMTP id v1-20020a170906b00100b00a470fdde97dmr1303059ejy.51.1711188979962; Sat, 23 Mar 2024 03:16:19 -0700 (PDT) Received: from smtpclient.apple (dynamic-077-009-127-100.77.9.pool.telefonica.de. [77.9.127.100]) by smtp.gmail.com with ESMTPSA id la3-20020a170906ad8300b00a4678ee539bsm756388ejb.190.2024.03.23.03.16.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 23 Mar 2024 03:16:19 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable From: Richard Biener Mime-Version: 1.0 (1.0) Subject: Re: [PATCH] bitint: Fix bitfield loads in handle_cast [PR114433] Date: Sat, 23 Mar 2024 11:16:09 +0100 Message-Id: <7C3B29A2-0781-49CF-9D98-94F936B085E8@gmail.com> References: Cc: Richard Biener , gcc-patches@gcc.gnu.org In-Reply-To: To: Jakub Jelinek X-Mailer: iPhone Mail (21E236) X-Spam-Status: No, score=-0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_LOTSOFHASH,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Am 23.03.2024 um 08:59 schrieb Jakub Jelinek : >=20 > =EF=BB=BFHi! >=20 > We ICE on the following testcase, because handle_cast was incorrectly > testing !m_first to see whether it should use m_data[m_bitfld_load + 1] > or fresh SSA_NAME for a PHI result. > Now, m_first is in the routine sometimes temporarily cleared in between > doing prepare_data_in_out and the !m_first check and only before returning= > restored from the save_first copy. > Without this patch, we try to use the same SSA_NAME (_12 here) in 2 > different PHI results which is obviously invalid IL and ICEs very quickly.= >=20 > Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? Ok Richard=20 > 2024-03-23 Jakub Jelinek >=20 > PR tree-optimization/114433 > * gimple-lower-bitint.cc (bitint_large_huge::handle_cast): For > m_bitfld_load check save_first rather than m_first. >=20 > * gcc.dg/torture/bitint-68.c: New test. >=20 > --- gcc/gimple-lower-bitint.cc.jj 2024-03-22 14:54:41.767972684 +0100 > +++ gcc/gimple-lower-bitint.cc 2024-03-22 17:13:43.702249666 +0100 > @@ -1506,7 +1506,7 @@ bitint_large_huge::handle_cast (tree lhs > if (m_bitfld_load) > { > tree t4; > - if (!m_first) > + if (!save_first) > t4 =3D m_data[m_bitfld_load + 1]; > else > t4 =3D make_ssa_name (m_limb_type); > --- gcc/testsuite/gcc.dg/torture/bitint-68.c.jj 2024-03-22 17:26:29.841= 713520 +0100 > +++ gcc/testsuite/gcc.dg/torture/bitint-68.c 2024-03-22 17:26:51.941409= 603 +0100 > @@ -0,0 +1,28 @@ > +/* PR tree-optimization/114433 */ > +/* { dg-do run { target bitint } } */ > +/* { dg-options "-std=3Dc23" } */ > +/* { dg-skip-if "" { ! run_expensive_tests } { "*" } { "-O0" "-O2" } } *= / > +/* { dg-skip-if "" { ! run_expensive_tests } { "-flto" } { "" } } */ > + > +#if __BITINT_MAXWIDTH__ >=3D 511 > +struct S { int : 31; _BitInt(511) b : 300; } s; > + > +__attribute__((noipa)) _BitInt(511) > +foo (void) > +{ > + return s.b << 1; > +} > +#endif > + > +int > +main () > +{ > +#if __BITINT_MAXWIDTH__ >=3D 511 > + s.b =3D 642460398785925402356009598661384732715767737595497615767135001= 949421105426024498988100867wb; > + if (foo () !=3D ((_BitInt(511)) 642460398785925402356009598661384732715= 767737595497615767135001949421105426024498988100867wb) << 1) > + __builtin_abort (); > + s.b =3D 265515676629856229956075542029808384377407496278629588766022269= 0220887wb; > + if (foo () !=3D ((_BitInt(511)) 265515676629856229956075542029808384377= 4074962786295887660222690220887wb) << 1) > + __builtin_abort (); > +#endif > +} >=20 > Jakub >=20