* Unreviewed patch (PR ada/5856, ada/6919)
@ 2002-11-13 13:23 Nathanael Nerode
2002-11-14 6:00 ` Geert Bosch
0 siblings, 1 reply; 4+ messages in thread
From: Nathanael Nerode @ 2002-11-13 13:23 UTC (permalink / raw)
To: gcc-patches
I'd appreciate review of this patch ASAP.
http://gcc.gnu.org/ml/gcc-patches/2002-10/msg01743.html
Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Unreviewed patch (PR ada/5856, ada/6919)
2002-11-13 13:23 Unreviewed patch (PR ada/5856, ada/6919) Nathanael Nerode
@ 2002-11-14 6:00 ` Geert Bosch
0 siblings, 0 replies; 4+ messages in thread
From: Geert Bosch @ 2002-11-14 6:00 UTC (permalink / raw)
To: Nathanael Nerode; +Cc: gcc-patches
On Wednesday, Nov 13, 2002, at 16:23 America/New_York, Nathanael Nerode
wrote:
> I'd appreciate review of this patch ASAP.
>
> http://gcc.gnu.org/ml/gcc-patches/2002-10/msg01743.html
>
It doesn't look entirely right:
> - End_Line;
> -
> - else
> + if GNATPRO_Version then
> Write_Str
> ("| (use plain ASCII or MIME attachment, or FTP "
> & "to your customer directory).");
There should be no GNATPRO_Version boolean anymore in the FSF sources,
and all code guarded with this condition should be removed.
-Geert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Unreviewed patch (PR ada/5856, ada/6919)
2002-11-14 9:20 Nathanael Nerode
@ 2002-11-14 9:39 ` Geert Bosch
0 siblings, 0 replies; 4+ messages in thread
From: Geert Bosch @ 2002-11-14 9:39 UTC (permalink / raw)
To: Nathanael Nerode; +Cc: gcc-patches
On Thursday, Nov 14, 2002, at 12:20 America/New_York, Nathanael Nerode
wrote:
> How about the Public_Version boolean? Shall I strip that out too,
> leaving only the FSF version?
Yes, that is what I had done on the branch.
-Geert
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Unreviewed patch (PR ada/5856, ada/6919)
@ 2002-11-14 9:20 Nathanael Nerode
2002-11-14 9:39 ` Geert Bosch
0 siblings, 1 reply; 4+ messages in thread
From: Nathanael Nerode @ 2002-11-14 9:20 UTC (permalink / raw)
To: gcc-patches; +Cc: bosch
>There should be no GNATPRO_Version boolean anymore in the FSF sources,
>and all code guarded with this condition should be removed.
>
> -Geert
How about the Public_Version boolean? Shall I strip that out too,
leaving only the FSF version?
--Nathanael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2002-11-14 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-11-13 13:23 Unreviewed patch (PR ada/5856, ada/6919) Nathanael Nerode
2002-11-14 6:00 ` Geert Bosch
2002-11-14 9:20 Nathanael Nerode
2002-11-14 9:39 ` Geert Bosch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).