Re: Re: [PATCH V6] VECT: Add SELECT_VL support

[钟居哲 <juzhe.zhong@rivai.ai>]

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]

Ok. Thanks Jeff.



juzhe.zhong@rivai.ai
 
From: Jeff Law
Date: 2023-06-09 22:42
To: juzhe.zhong@rivai.ai; rguenther
CC: gcc-patches; richard.sandiford
Subject: Re: [PATCH V6] VECT: Add SELECT_VL support
 
 
On 6/9/23 05:32, juzhe.zhong@rivai.ai wrote:
> Thanks a lot Richi.
> 
> Even though last time Richard asked me no need to wait for 2nd ACK,
> I am still want to wait for Richard final approval since I am not sure this patch is ok for him.
If Richard had asked you to wait for Richi and you've done updates based 
on Richi's feedback, then it becomes a judgment call -- if the changes 
are significant, then we might want Richard to take another look.  If 
the changes are minor, then getting another ACK isn't necessary.
 
It's not always clear what the best path forward ought to be and in 
cases where it isn't clear, a bit of caution is appreciated.
 
So to give some clear guidance.  Based on my understanding both Richard 
and Richi are basically on board with what you've implemented.  So how 
about this, if Richard hasn't chimed in by the start of your day on 
Tuesday, go ahead with the patch.  That gives Richard the rest of today 
and his Monday if there's something he wants to comment on.
 
jeff