public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Andrew Pinski <pinskia@physics.uc.edu>
To: "Kaveh R. Ghazi" <ghazi@caip.rutgers.edu>
Cc: gcc-patches@gcc.gnu.org, Andrew Pinski <pinskia@physics.uc.edu>,
	dje@watson.ibm.com
Subject: Re: [PATCH]: Add some more builtins opts for sqrt/cbrt
Date: Sun, 28 Mar 2004 07:28:00 -0000	[thread overview]
Message-ID: <7DD20D88-8089-11D8-9789-000393A6D2F2@physics.uc.edu> (raw)
In-Reply-To: <200403280011.i2S0BCef009286@caip.rutgers.edu>


On Mar 27, 2004, at 19:11, Kaveh R. Ghazi wrote:

>> From: David Edelsohn <dje@watson.ibm.com>
>>
>> 	builtin-power-1.c is failing on PowerPC.  [...]
>>
>> It also is failing on Darwin, along with other builtins.
>> David
>
> The darwin failure is different.  It occurs because there is a
> mismatch in whether GCC thinks darwin has C99 functions between the
> darwin port itself and the testsuite.  Fixing this will correct much
> more than just builtin-power-1.c.  As you noted, there are several
> builtins failures on darwin.
>
> If darwin has the C99 functions, then someone needs to add
> #define TARGET_C99_FUNCTIONS 1
> to config/darwin.h.
>
> If darwin doesn't have the C99 functions, then someone needs to tweek
> testsuite/gcc.dg/builtins-config.h appropriately so darwin doesn't
> attempt to test any transformations which result in C99 function
> calls.
>
> Either way, someone who knows darwin and can test on it should fix
> this.

I have a fix for darwin but I have not applied it yet, I have been
just to busy to finish it up as the C99 math functions are in the
libmx library which causes so much problems.  I have already fixed
libgfortran to support this library but I need to add support for
libstdc++.

I am almost ready to file a bug (with Apple) asking for the
functions to be in libm or libsystem as that makes it more
consistent with the rest of the UNIX world.

Thanks,
Andrew Pinski

  reply	other threads:[~2004-03-28  7:28 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-12 14:36 Kaveh R. Ghazi
2004-03-19  8:14 ` Kaveh R. Ghazi
2004-03-25 13:10 ` Unreviewed patch Kaveh R. Ghazi
2004-03-25 14:57   ` Roger Sayle
2004-03-27 18:43 ` [PATCH]: Add some more builtins opts for sqrt/cbrt David Edelsohn
2004-03-28  0:05   ` Kaveh R. Ghazi
2004-03-28  1:09     ` David Edelsohn
2004-03-29 18:55     ` Richard Henderson
2004-03-29 20:47       ` Kaveh R. Ghazi
2004-03-29 20:52         ` Richard Henderson
2004-03-29 23:22           ` Kaveh R. Ghazi
2004-03-28  0:11   ` Kaveh R. Ghazi
2004-03-28  7:28     ` Andrew Pinski [this message]
2004-03-28 13:03       ` Kaveh R. Ghazi
2004-03-25 21:42 Ulrich Weigand
2004-04-07 14:56 John David Anglin
2004-04-07 16:17 ` Kaveh R. Ghazi
2004-04-07 16:46   ` John David Anglin
2004-04-09 20:06     ` John David Anglin
2004-04-08 21:01   ` Jan Hubicka
2004-04-08 21:16     ` Kaveh R. Ghazi
2004-04-08 21:19       ` Jan Hubicka
2004-04-09 20:06         ` Jan Hubicka
2004-04-30 15:11         ` David Edelsohn
2004-04-30 15:29           ` Kaveh R. Ghazi
2004-04-30 16:21             ` David Edelsohn
2004-05-02 13:49               ` Kaveh R. Ghazi
2004-04-09 20:06       ` Kaveh R. Ghazi
2004-04-09 20:06     ` Jan Hubicka
2004-04-09 20:06   ` Kaveh R. Ghazi
2004-04-09 20:06 ` John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7DD20D88-8089-11D8-9789-000393A6D2F2@physics.uc.edu \
    --to=pinskia@physics.uc.edu \
    --cc=dje@watson.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=ghazi@caip.rutgers.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).