From: Mike Stump <mikestump@comcast.net>
To: Martin Sebor <msebor@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] restore CFString handling in attribute format (PR 88638)
Date: Fri, 04 Jan 2019 22:30:00 -0000 [thread overview]
Message-ID: <7F4803D9-451F-4DFC-AC93-CDA68F742693@comcast.net> (raw)
In-Reply-To: <f4ef9f1e-1db8-319f-c023-948e32485879@gmail.com>
On Jan 4, 2019, at 2:03 PM, Martin Sebor <msebor@gmail.com> wrote:
>
> The improved handling of attribute positional arguments added
> in r266195 introduced a regression on Darwin where attribute
> format with the CFString archetype accepts CFString* parameter
> types in positions where only char* would otherwise be allowed.
You didn't ask Ok? I'll assume you want a review... The darwin bits and the testsuite bits look fine.
That just leaves the C bits for someone...
next prev parent reply other threads:[~2019-01-04 22:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 22:03 Martin Sebor
2019-01-04 22:30 ` Mike Stump [this message]
2019-01-05 10:31 ` Iain Sandoe
2019-01-05 17:39 ` Martin Sebor
2019-01-05 17:54 ` Iain Sandoe
2019-01-06 23:34 ` Martin Sebor
2019-01-07 9:26 ` Iain Sandoe
2019-01-11 22:05 ` Jeff Law
2019-01-05 21:41 Dominique d'Humières
2019-01-14 18:55 ` Martin Sebor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F4803D9-451F-4DFC-AC93-CDA68F742693@comcast.net \
--to=mikestump@comcast.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=msebor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).