From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-493414-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 50038 invoked by alias); 4 Jan 2019 22:30:41 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 49853 invoked by uid 89); 4 Jan 2019 22:30:23 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=sk:msebor, msebor@gmail.com, sk:msebor@, mseborgmailcom
X-HELO: resqmta-po-05v.sys.comcast.net
Received: from resqmta-po-05v.sys.comcast.net (HELO resqmta-po-05v.sys.comcast.net) (96.114.154.164) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 04 Jan 2019 22:30:22 +0000
Received: from resomta-po-07v.sys.comcast.net ([96.114.154.231])	by resqmta-po-05v.sys.comcast.net with ESMTP	id fXd4gFzmgFbd9fXyogDfCA; Fri, 04 Jan 2019 22:30:14 +0000
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;	s=q20161114; t=1546641014;	bh=NBitUE7RXm3csxVGTYu14zdRvkM79H1KLByNzWai7H0=;	h=Received:Received:Content-Type:Mime-Version:Subject:From:Date:	 Message-Id:To;	b=FFt2utm2rcPkjGUHaictIiJTxRo0SXjFNwdQr82RqKRysx7R9cLXfwUOdGCBCcICy	 k/zusjc7MH+C/QnXAkREKEFzl+FjFl1JqsTJiwbzi5dwqoX3Di9zQb9L2Yv3EvurkL	 6zK7MUrPujC1VOtcOcUnUXWwadNbqe0E+cyeJf7JXGS6lGfHPqw5vGljOkYIArPkpF	 ylEOMKQUkrLs3Tdpq6WBMc3ihpmlonlHev+hwKdQ4vo+rJdTwlWcDosiH356eGe17N	 NtzwqpJAGxoXTEfdlxVKDbMVI+f5/TzAgoKxfZTZGhJ0XJEGYDl+IRe2oypnAQX25l	 ARWfNdw0GfllA==
Received: from [IPv6:2601:640:4001:ad2:44eb:4cf9:dda:435c] ([IPv6:2601:640:4001:ad2:44eb:4cf9:dda:435c])	by resomta-po-07v.sys.comcast.net with ESMTPA	id fXyngBA1jrQokfXyngnEuy; Fri, 04 Jan 2019 22:30:14 +0000
X-Xfinity-VMeta: sc=??;st=legit
Content-Type: text/plain;	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: [PATCH] restore CFString handling in attribute format (PR 88638)
From: Mike Stump <mikestump@comcast.net>
In-Reply-To: <f4ef9f1e-1db8-319f-c023-948e32485879@gmail.com>
Date: Fri, 04 Jan 2019 22:30:00 -0000
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <7F4803D9-451F-4DFC-AC93-CDA68F742693@comcast.net>
References: <f4ef9f1e-1db8-319f-c023-948e32485879@gmail.com>
To: Martin Sebor <msebor@gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2019-01/txt/msg00183.txt.bz2

On Jan 4, 2019, at 2:03 PM, Martin Sebor <msebor@gmail.com> wrote:
>=20
> The improved handling of attribute positional arguments added
> in r266195 introduced a regression on Darwin where attribute
> format with the CFString archetype accepts CFString* parameter
> types in positions where only char* would otherwise be allowed.

You didn't ask Ok?  I'll assume you want a review...  The darwin bits and t=
he testsuite bits look fine.

That just leaves the C bits for someone...