From: IainS <developer@sandoe-acoustics.co.uk>
To: Mike Stump <mikestump@comcast.net>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] Fix anonymous code atoms problem on Darwin.
Date: Tue, 08 Feb 2011 09:14:00 -0000 [thread overview]
Message-ID: <7F9538A1-5F81-4609-A436-AC828BA1940F@sandoe-acoustics.co.uk> (raw)
In-Reply-To: <6466C461-AC3F-42AD-A0E3-52F24BA1E2C4@sandoe-acoustics.co.uk>
On 8 Feb 2011, at 08:19, IainS wrote:
> On 8 Feb 2011, at 03:01, Mike Stump wrote:
>
>> On Dec 20, 2010, at 3:07 AM, IainS wrote:
>>> This problem became apparent during the resolution of
>>> PR46904/46916 (we have had to switch off freorder-and-partition to
>>> avoid regression).
>>
>>> gcc:
>>>
>>> * target.def (function_switched_text_sections): New Hook.
>>> * doc/tm.texi Regenerated.
>>> * doc/tm.texi.in (TARGET_ASM_FUNCTION_SWITCHED_TEXT_SECTIONS)
>>> New.
>>> * final.c (default_function_switched_text_sections): New.
>>> (final_scan_insn): Call function_switched_text_sections when a
>>> mid-function section
>>> change occurs.
>>> * output.h (default_function_switched_text_sections): Declare.
>>> * config/darwin-protos.h
>>> (darwin_function_switched_text_sections) : Likewise.
>>> * config/darwin.c (darwin_function_switched_text_sections): New.
>>> * config/darwin.h (TARGET_ASM_FUNCTION_SWITCHED_TEXT_SECTIONS)
>>> New.
>>
>> This posted patch does not match what was checked in r168571.
>> Could you please audit what was checked in and ensure it is as you
>> wanted. Thanks.
>
> Yes, the commit matches what was intended.
scratch that, I'm obviously blind.....
I'll bootstrap this on *-darwin9 + i686-darwin8 right away.
Iain
--- gcc/config/darwin.c (revision 169878)
+++ gcc/config/darwin.c (working copy)
@@ -2581,7 +2581,7 @@ darwin_override_options (void)
global_options.x_flag_asynchronous_unwind_tables = 0;
/* Disable -freorder-blocks-and-partition when unwind tables are
being emitted
- for Darwin < 10 (OSX 10.6).
+ for Darwin < 9 (OSX 10.5).
The strategy is, "Unless the User has specifically set/unset
an unwind flag
we will switch off -freorder-blocks-and-partition when unwind
tables will be
generated". If the User specifically sets flags... we assume
(s)he knows
@@ -2596,6 +2596,13 @@ darwin_override_options (void)
&& !global_options_set.x_flag_non_call_exceptions)
|| (global_options.x_flag_asynchronous_unwind_tables
&& !
global_options_set.x_flag_asynchronous_unwind_tables)))
+ {
+ inform (input_location,
+ "-freorder-blocks-and-partition does not work with
exceptions "
+ "on this architecture");
+ flag_reorder_blocks_and_partition = 0;
+ flag_reorder_blocks = 1;
+ }
if (flag_mkernel || flag_apple_kext)
{
next prev parent reply other threads:[~2011-02-08 9:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-20 12:03 IainS
2010-12-20 21:49 ` Richard Henderson
2010-12-23 20:50 ` Mike Stump
2011-01-07 14:12 ` IainS
2011-02-08 3:01 ` Mike Stump
2011-02-08 8:19 ` IainS
2011-02-08 9:14 ` IainS [this message]
2011-02-08 13:35 ` IainS
2011-02-08 20:50 ` Mike Stump
2011-02-12 11:21 ` IainS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7F9538A1-5F81-4609-A436-AC828BA1940F@sandoe-acoustics.co.uk \
--to=developer@sandoe-acoustics.co.uk \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).