From: Mike Stump <mikestump@comcast.net>
To: Renlin Li <renlin.li@arm.com>
Cc: David Edelsohn <dje.gcc@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Ramana Radhakrishnan <ramana.radhakrishnan@foss.arm.com>
Subject: Re: [PATCH] g++.dg/init/vbase1.C and g++.dg/cpp/ucn-1.C
Date: Fri, 20 Nov 2015 22:17:00 -0000 [thread overview]
Message-ID: <7FDDFA0F-C795-4E4B-9488-B4772097C40B@comcast.net> (raw)
In-Reply-To: <5649E1E0.60303@arm.com>
On Nov 16, 2015, at 6:02 AM, Renlin Li <renlin.li@arm.com> wrote:
> On 14/11/15 00:33, David Edelsohn wrote:
>> No RISC architecture can store directly to MEM, so the expected RTL in
>> g++.dg/init/vbase1.C is wrong. I am adding XFAIL for PowerPC. This
>> probably should be disabled for ARM and other RISC architectures.
>
> I observed the same problem in arm.
>
> This passes for aarch64 and mips as they have zero register to do that. However, other RISC might not have that feature, for example arm and RS6000 in this case.
I fixed this with the below patch. Tested on x86_64 linux, x86_64 darwin and my port. If you want to list aarch64/arn and mips, please do.
* g++.dg/init/vbase1.C: Only run on x86_64-*-* as this testcase
isn't portable.
Index: g++.dg/init/vbase1.C
===================================================================
--- g++.dg/init/vbase1.C (revision 230675)
+++ g++.dg/init/vbase1.C (working copy)
@@ -42,4 +42,4 @@ int main(int, char**)
// Verify that the SubB() mem-initializer is storing 0 directly into
// this->D.whatever rather than into a stack temp that is then copied into the
// base field.
-// { dg-final { scan-rtl-dump "set \[^\n\]*\n\[^\n\]*this\[^\n\]*\n\[^\n\]*const_int 0" "expand" { xfail { powerpc*-*-* } } } }
+// { dg-final { scan-rtl-dump "set \[^\n\]*\n\[^\n\]*this\[^\n\]*\n\[^\n\]*const_int 0" "expand" { target { x86_64-*-* } } } }
next prev parent reply other threads:[~2015-11-20 22:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-14 0:33 David Edelsohn
2015-11-14 1:01 ` Mike Stump
2015-11-14 10:16 ` Andreas Schwab
2015-11-14 13:09 ` David Edelsohn
2015-11-14 13:31 ` Jakub Jelinek
2015-11-14 13:36 ` David Edelsohn
2015-11-14 13:42 ` Andreas Schwab
2015-11-14 13:47 ` David Edelsohn
2015-11-16 9:15 ` Eric Botcazou
2015-11-16 13:29 ` David Edelsohn
2015-11-16 14:02 ` Renlin Li
2015-11-20 22:17 ` Mike Stump [this message]
2015-11-21 12:34 Uros Bizjak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7FDDFA0F-C795-4E4B-9488-B4772097C40B@comcast.net \
--to=mikestump@comcast.net \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=ramana.radhakrishnan@foss.arm.com \
--cc=renlin.li@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).