From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-4316.protonmail.ch (mail-4316.protonmail.ch [185.70.43.16]) by sourceware.org (Postfix) with ESMTPS id EB0023858D1E for ; Tue, 7 Nov 2023 04:24:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EB0023858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=protonmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=protonmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EB0023858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=185.70.43.16 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699331064; cv=none; b=PbR3ZaAEzu+XT1x03Hrt/0AtBy1knBOeBpJ4OfY5nJsymdQcdX3d8Ep68GKLEwAfJBBn95J6NxuotxuHgkCWuil4hukXymDq6dgBFkFw6AKkDR1KjI3yCMgB+MRGTkw6L3caf0Yqamnm14gcVFlriwHnDOXtmEG1jS6cNTQwuCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699331064; c=relaxed/simple; bh=rDGUviDX+suXJD9/1Z4folYY5qFDbisRHBjusRY7GHs=; h=DKIM-Signature:Date:To:From:Subject:Message-ID:MIME-Version; b=VSPQ3rmnRKiIn8uMpxesH5lTJ2gri0gTZ3qYAqiZegNMOympo1FaXGNGAHo8d0BuS2H/GSANXdf79REaWYDomR028Jy+Fyc/cqh0l1DTfyVXnhPJ03WzoO6pT2Vx/6MVvbhXOcmxyTo0s5M4Yp97VNsJAhgbCgQSM/VhG+L30NE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1699331061; x=1699590261; bh=hLH2N0BLizltOmf0a7M/19UAmGsPBC+vozEmo+q8/lA=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=eZVlwfShU3UoplxPn5nTQQcGgxKMZK/gAYHMnicAi4BsKjBPlhreYgwH80ismtvMz Mck9XdihTmTDJr/Ye+7yWUC31BSGzYLkUlMS1Vsh58DZ9Ltp82QQXAuOpr5DLX/t5N brh8GzuvFaZMekNJnqsvKMfblFxX1SiuLWMcixzoaQil84746WNunVdBygWpYyRJef 2wH2wH/Mrna3hXubezUujT9u99gctZ6HbsaOJbsu/9m5KDljtzUS6nnNgNt6WuWIQz /0GPaGHXDXQIPONMa+nEpEC7iTR4Pov8rhWZU4ZwQPwakUL0xyPX1xr4rYf5nsW+nJ RjftP/TKTWtXQ== Date: Tue, 07 Nov 2023 04:24:06 +0000 To: waffl3x From: waffl3x Cc: Jason Merrill , "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH v4 1/2] c++: Initial support for P0847R7 (Deducing this) [PR102609] Message-ID: <7N-k8O0zfePgSAEbzdPO3eGBPJA0Yrg__iRbGQKl9EM2tMwZyckQHLqoS010EALNhrwO41zYqmFfGkbNIk6edrFZCwNY9c4WOjq7z6mUABw=@protonmail.com> In-Reply-To: References: Feedback-ID: 14591686:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TO_EQ_FM_DIRECT_MX,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I noticed I made a bit of a mistake in grokdeclarator:find_xobj_parm,=20 this code: ``` if (!parm_list || parm_list =3D=3D void_list_node) return false; if (TREE_PURPOSE (parm_list) !=3D this_identifier) return false; ``` Can be simplified to this code: ``` if (!parm_list || TREE_PURPOSE (parm_list) !=3D this_identifier) return false; ``` While working on lambda support I found that I need to find the xobj parameter before we get to grokdeclarator, so I was going to reuse the same code. After looking at it I realized, hey, I wonder what void_list_node's purpose field holds. So I checked, and found that tree.cc:build_common_tree_nodes initializes void_list_node with a NULL_TREE for it's purpose field. It's obviously not going to be a big deal but simpler code is better. I will most likely fix this if I have time later just so the code doesn't look semantically different in the lambda support patch. Alex