From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 6D2D4385843E for ; Fri, 8 Jul 2022 11:14:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6D2D4385843E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 6A39B22045; Fri, 8 Jul 2022 11:14:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1657278888; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dR8epvPdOnFF0iKX0L2dYGouevDcHgW1+LyDJD2wYsA=; b=j7tVmT9SgDXaSvF1dcZbfSCxDUyT2oYdHQgsdO7Hmcss16rT/oYh6MHo/UKTky3EFCLeUQ /C0Tk4+6cb1b4r8J4SMfYyeEE2fg49wZkt8iNVzoEy27aNc5FjFq5LCwKQtwsd+DONdHy5 ImyZU1upggtDyW26QVmW4hN5XXzzbpg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1657278888; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=dR8epvPdOnFF0iKX0L2dYGouevDcHgW1+LyDJD2wYsA=; b=M39/iHumMfYMgxC1KS/9uJQztahcQwWpfxbeY9d+KW5zj4xhIRKWSwZ1CLewnyWrtHCwv0 LflC2RgzSXrJESAQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4E3E713A7D; Fri, 8 Jul 2022 11:14:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7GMEEqgRyGILegAAMHmgww (envelope-from ); Fri, 08 Jul 2022 11:14:48 +0000 Content-Type: multipart/mixed; boundary="------------g99eBpJiUH4mQ7A471vDZQMH" Message-ID: <7a07c85c-546e-7ee6-d059-85244488f296@suse.cz> Date: Fri, 8 Jul 2022 13:14:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2] Support --disable-fixincludes. Content-Language: en-US To: Alexandre Oliva Cc: Andreas Schwab , gcc-patches@gcc.gnu.org, Joseph Myers References: <2e2c7061-3f3f-fde4-6e8c-d2118820a5b6@suse.cz> <87pmkkutdz.fsf@igel.home> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Jul 2022 11:14:54 -0000 This is a multi-part message in MIME format. --------------g99eBpJiUH4mQ7A471vDZQMH Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/25/22 07:37, Alexandre Oliva wrote: > On May 24, 2022, Martin Liška wrote: > >> Allways install limits.h and syslimits.h header files >> to include folder. > > typo: s/Allways/Always/ Hello. Fixed. > > I'm a little worried about this bit, too. limitx.h includes > "syslimits.h", mentioning it should be in the same directory. Perhaps > it could be left in include-fixed? Well, I would like to go w/o include-fixed if the option --disable-fixincludes is used. > > The patch also changes syslimits.h from either the fixincluded file or > gsyslimits.h to use gsyslimits.h unconditionally, which seemed wrong at > first. > > Now I see how these two hunks work together: syslimits.h will now always > #include_next , which will find it in include-fixed if it's > there, and system header files otherwise. Nice!, but IMHO the commit > message could be a little more verbose on the extent of the change and > why that (is supposed to) work. Oh, to be honest I'm not fully familiar with how these 2 files work together. Can you explain it to me so that I can adjust the changelog entry correspondingly? > > > It also looks like install-mkheaders installs limits-related headers for > when fixincludes runs; we could probably skip the whole thing if > fixincludes is disabled, but I'm also worried about how the changes > above might impact post-install fixincludes: if that installs > gsyslimits.h et al in include-fixed while your changes moves it to > include, headers might end up in a confusing state. I haven't worked > out whether that's safe, but there appears to be room for cleanups > there. I've check that 'make install-mkheaders' work fine w/ and w/o --disable-fixincludes after the patch. > > gcc/config/mips/t-sdemtk also places syslimits.h explicitly in include/ > rather than include-fixed/, as part of disabling fixincludes, which is > good, but it could be cleaned up as well. Can we do that as a follow-up patch? > > I don't see other config fragments that might require adjustments, so I > think the patch looks good; hopefully my worries are unjustified, and > the cleanups it enables could be Good. > > > We still create the README file in there and install it, even with > fixincludes disabled and thus unavailable, don't we? That README then > becomes misleading; we might be better off not installing it. Sure, fixed in v2 of the patch. > > >> When --disable-fixincludes is used, then no systen header files >> are fixed by the tools in fixincludes. Moreover, the fixincludes >> tools are not built any longer. > > typo: s/systen/system/ Fixed. > > > Could you please check that a post-install mkheaders still has a > functional limits.h with these changes? How do I check that, please? > The patch is ok (with the typo > fixes) if so. The cleanups it enables would be welcome as separate > patches ;-) Can I install the v2? Martin > > Thanks! > --------------g99eBpJiUH4mQ7A471vDZQMH Content-Type: text/x-patch; charset=UTF-8; name="0001-Support-disable-fixincludes.patch" Content-Disposition: attachment; filename="0001-Support-disable-fixincludes.patch" Content-Transfer-Encoding: base64 RnJvbSBkMDZmOTMxMzI5YzQ1NjgyMWFjYWM0NWFhM2Q4OTkyMjE4MzE2MWJjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ0aW4gTGlza2EgPG1saXNrYUBzdXNlLmN6PgpE YXRlOiBUdWUsIDI0IE1heSAyMDIyIDEzOjA2OjA3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g U3VwcG9ydCAtLWRpc2FibGUtZml4aW5jbHVkZXMuCgpBbHdheXMgaW5zdGFsbCBsaW1pdHMu aCBhbmQgc3lzbGltaXRzLmggaGVhZGVyIGZpbGVzCnRvIGluY2x1ZGUgZm9sZGVyLgoKV2hl biAtLWRpc2FibGUtZml4aW5jbHVkZXMgaXMgdXNlZCwgdGhlbiBubyBzeXN0ZW0gaGVhZGVy IGZpbGVzCmFyZSBmaXhlZCBieSB0aGUgdG9vbHMgaW4gZml4aW5jbHVkZXMuIE1vcmVvdmVy LCB0aGUgZml4aW5jbHVkZXMKdG9vbHMgYXJlIG5vdCBidWlsdCBhbnkgbG9uZ2VyLgoKZ2Nj L0NoYW5nZUxvZzoKCgkqIE1ha2VmaWxlLmluOiBBbHdheXMgaW5zdGFsbCBsaW1pdHMuaCBh bmQgc3lzbGltaXRzLmggdG8KCWluY2x1ZGUgZm9sZGVyLgoJKiBjb25maWd1cmUuYWM6IEFz c2lnbiBTVE1QX0ZJWElOQyBibGFuayBpZgoJLS1kaXNhYmxlLWZpeGluY2x1ZGVzIGlzIHVz ZWQuCgkqIGNvbmZpZ3VyZTogUmVnZW5lcmF0ZS4KLS0tCiBnY2MvTWFrZWZpbGUuaW4gIHwg MzAgKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tCiBnY2MvY29uZmlndXJlICAgIHwg MTAgKysrKysrKystLQogZ2NjL2NvbmZpZ3VyZS5hYyB8ICA2ICsrKysrKwogMyBmaWxlcyBj aGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCAxOSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9nY2MvTWFrZWZpbGUuaW4gYi9nY2MvTWFrZWZpbGUuaW4KaW5kZXggM2FlMjM3MDI0MjYu LmI3ODgzMjU0MzI0IDEwMDY0NAotLS0gYS9nY2MvTWFrZWZpbGUuaW4KKysrIGIvZ2NjL01h a2VmaWxlLmluCkBAIC0zMTY0LDI0ICszMTY0LDI3IEBAIHN0bXAtaW50LWhkcnM6ICQoU1RN UF9GSVhJTkMpICQoVF9HTElNSVRTX0gpICQoVF9TVERJTlRfR0NDX0gpICQoVVNFUl9IKSBm aXhpbmNfCiAJc2V0IC1lOyBmb3IgbWwgaW4gYGNhdCBmaXhpbmNfbGlzdGA7IGRvIFwKIAkg IHN5c3Jvb3RfaGVhZGVyc19zdWZmaXg9YGVjaG8gJCR7bWx9IHwgc2VkIC1lICdzLzsuKiQk Ly8nYDsgXAogCSAgbXVsdGlfZGlyPWBlY2hvICQke21sfSB8IHNlZCAtZSAncy9eW147XSo7 Ly8nYDsgXAotCSAgZml4X2Rpcj1pbmNsdWRlLWZpeGVkJCR7bXVsdGlfZGlyfTsgXAorCSAg aW5jbHVkZV9kaXI9aW5jbHVkZSQke211bHRpX2Rpcn07IFwKIAkgIGlmICQoTElNSVRTX0hf VEVTVCkgOyB0aGVuIFwKIAkgICAgY2F0ICQoc3JjZGlyKS9saW1pdHguaCAkKFRfR0xJTUlU U19IKSAkKHNyY2RpcikvbGltaXR5LmggPiB0bXAteGxpbWl0cy5oOyBcCiAJICBlbHNlIFwK IAkgICAgY2F0ICQoVF9HTElNSVRTX0gpID4gdG1wLXhsaW1pdHMuaDsgXAogCSAgZmk7IFwK LQkgICQobWtpbnN0YWxsZGlycykgJCR7Zml4X2Rpcn07IFwKLQkgIGNobW9kIGErcnggJCR7 Zml4X2Rpcn0gfHwgdHJ1ZTsgXAorCSAgJChta2luc3RhbGxkaXJzKSAkJHtpbmNsdWRlX2Rp cn07IFwKKwkgIGNobW9kIGErcnggJCR7aW5jbHVkZV9kaXJ9IHx8IHRydWU7IFwKIAkgICQo U0hFTEwpICQoc3JjZGlyKS8uLi9tb3ZlLWlmLWNoYW5nZSBcCiAJICAgIHRtcC14bGltaXRz LmggIHRtcC1saW1pdHMuaDsgXAotCSAgcm0gLWYgJCR7Zml4X2Rpcn0vbGltaXRzLmg7IFwK LQkgIGNwIC1wIHRtcC1saW1pdHMuaCAkJHtmaXhfZGlyfS9saW1pdHMuaDsgXAotCSAgY2ht b2QgYStyICQke2ZpeF9kaXJ9L2xpbWl0cy5oOyBcCisJICBybSAtZiAkJHtpbmNsdWRlX2Rp cn0vbGltaXRzLmg7IFwKKwkgIGNwIC1wIHRtcC1saW1pdHMuaCAkJHtpbmNsdWRlX2Rpcn0v bGltaXRzLmg7IFwKKwkgIGNobW9kIGErciAkJHtpbmNsdWRlX2Rpcn0vbGltaXRzLmg7IFwK KwkgIGNwICQoc3JjZGlyKS9nc3lzbGltaXRzLmggJCR7aW5jbHVkZV9kaXJ9L3N5c2xpbWl0 cy5oOyBcCiAJZG9uZQogIyBJbnN0YWxsIHRoZSBSRUFETUUKLQlybSAtZiBpbmNsdWRlLWZp eGVkL1JFQURNRQotCWNwICQoc3JjZGlyKS8uLi9maXhpbmNsdWRlcy9SRUFETUUtZml4aW5j IGluY2x1ZGUtZml4ZWQvUkVBRE1FCi0JY2htb2QgYStyIGluY2x1ZGUtZml4ZWQvUkVBRE1F CisJaWYgWyB4JChTVE1QX0ZJWElOQykgIT0geCBdOyB0aGVuIFwKKwkgIHJtIC1mIGluY2x1 ZGUtZml4ZWQvUkVBRE1FOyBcCisJICBjcCAkKHNyY2RpcikvLi4vZml4aW5jbHVkZXMvUkVB RE1FLWZpeGluYyBpbmNsdWRlLWZpeGVkL1JFQURNRTsgXAorCSAgY2htb2QgYStyIGluY2x1 ZGUtZml4ZWQvUkVBRE1FOyBcCisJZmk7CiAJJChTVEFNUCkgJEAKIAogLlBIT05ZOiBpbnN0 YWxsLWdjYy10b29sZGlyCkBAIC0zMjY2LDEzICszMjY5LDYgQEAgc3RtcC1maXhpbmM6IGdz eXNsaW1pdHMuaCBtYWNyb19saXN0IGZpeGluY19saXN0IFwKIAkgICAgICBjZCAkKGJ1aWxk X29iamRpcikvZml4aW5jbHVkZXMgJiYgXAogCSAgICAgICQoU0hFTEwpIC4vZml4aW5jLnNo ICIkJHtnY2NfZGlyfS8kJHtmaXhfZGlyfSIgXAogCSAgICAgICAgJChCVUlMRF9TWVNURU1f SEVBREVSX0RJUikgJChPVEhFUl9GSVhJTkNMVURFU19ESVJTKSApOyBcCi0JICAgIHJtIC1m ICQke2ZpeF9kaXJ9L3N5c2xpbWl0cy5oOyBcCi0JICAgIGlmIFsgLWYgJCR7Zml4X2Rpcn0v bGltaXRzLmggXTsgdGhlbiBcCi0JICAgICAgbXYgJCR7Zml4X2Rpcn0vbGltaXRzLmggJCR7 Zml4X2Rpcn0vc3lzbGltaXRzLmg7IFwKLQkgICAgZWxzZSBcCi0JICAgICAgY3AgJChzcmNk aXIpL2dzeXNsaW1pdHMuaCAkJHtmaXhfZGlyfS9zeXNsaW1pdHMuaDsgXAotCSAgICBmaTsg XAotCSAgICBjaG1vZCBhK3IgJCR7Zml4X2Rpcn0vc3lzbGltaXRzLmg7IFwKIAkgIGRvbmU7 IFwKIAlmaQogCSQoU1RBTVApIHN0bXAtZml4aW5jCkBAIC0zOTkwLDcgKzM5ODYsNyBAQCBp bnN0YWxsLW1raGVhZGVyczogc3RtcC1pbnQtaGRycyBpbnN0YWxsLWl0b29sc2RpcnMgXAog CXNldCAtZTsgZm9yIG1sIGluIGBjYXQgZml4aW5jX2xpc3RgOyBkbyBcCiAJICBtdWx0aV9k aXI9YGVjaG8gJCR7bWx9IHwgc2VkIC1lICdzL15bXjtdKjsvLydgOyBcCiAJICAkKG1raW5z dGFsbGRpcnMpICQoREVTVERJUikkKGl0b29sc2RhdGFkaXIpL2luY2x1ZGUkJHttdWx0aV9k aXJ9OyBcCi0JICAkKElOU1RBTExfREFUQSkgaW5jbHVkZS1maXhlZCQke211bHRpX2Rpcn0v bGltaXRzLmggJChERVNURElSKSQoaXRvb2xzZGF0YWRpcikvaW5jbHVkZSQke211bHRpX2Rp cn0vbGltaXRzLmg7IFwKKwkgICQoSU5TVEFMTF9EQVRBKSBpbmNsdWRlJCR7bXVsdGlfZGly fS9saW1pdHMuaCAkKERFU1RESVIpJChpdG9vbHNkYXRhZGlyKS9pbmNsdWRlJCR7bXVsdGlf ZGlyfS9saW1pdHMuaDsgXAogCWRvbmUKIAkkKElOU1RBTExfU0NSSVBUKSAkKHNyY2Rpcikv Li4vbWtpbnN0YWxsZGlycyBcCiAJCSQoREVTVERJUikkKGl0b29sc2RpcikvbWtpbnN0YWxs ZGlycyA7IFwKZGlmZiAtLWdpdCBhL2djYy9jb25maWd1cmUgYi9nY2MvY29uZmlndXJlCmlu ZGV4IDYyODcyZDEzMmVhLi5iZDk0MDhlMDYxMyAxMDA3NTUKLS0tIGEvZ2NjL2NvbmZpZ3Vy ZQorKysgYi9nY2MvY29uZmlndXJlCkBAIC0xMzU0OCw2ICsxMzU0OCwxMiBAQCB0aGVuCiAg ICAgQlVJTERfTERGTEFHUz0nJChMREZMQUdTX0ZPUl9CVUlMRCknCiBmaQogCisKK2lmIHRl c3QgeCRlbmFibGVfZml4aW5jbHVkZXMgPSB4bm87Cit0aGVuCisgICAgU1RNUF9GSVhJTkM9 JycKK2ZpCisKICMgRXhwYW5kIGV4dHJhX2hlYWRlcnMgdG8gaW5jbHVkZSBjb21wbGV0ZSBw YXRoLgogIyBUaGlzIHN1YnN0aXR1dGVzIGZvciBsb3RzIG9mIHQtKiBmaWxlcy4KIGV4dHJh X2hlYWRlcnNfbGlzdD0KQEAgLTE5Njc0LDcgKzE5NjgwLDcgQEAgZWxzZQogICBsdF9kbHVu a25vd249MDsgbHRfZGxub191c2NvcmU9MTsgbHRfZGxuZWVkX3VzY29yZT0yCiAgIGx0X3N0 YXR1cz0kbHRfZGx1bmtub3duCiAgIGNhdCA+IGNvbmZ0ZXN0LiRhY19leHQgPDxfTFRfRU9G Ci0jbGluZSAxOTY3OSAiY29uZmlndXJlIgorI2xpbmUgMTk2ODMgImNvbmZpZ3VyZSIKICNp bmNsdWRlICJjb25mZGVmcy5oIgogCiAjaWYgSEFWRV9ETEZDTl9ICkBAIC0xOTc4MCw3ICsx OTc4Niw3IEBAIGVsc2UKICAgbHRfZGx1bmtub3duPTA7IGx0X2Rsbm9fdXNjb3JlPTE7IGx0 X2RsbmVlZF91c2NvcmU9MgogICBsdF9zdGF0dXM9JGx0X2RsdW5rbm93bgogICBjYXQgPiBj b25mdGVzdC4kYWNfZXh0IDw8X0xUX0VPRgotI2xpbmUgMTk3ODUgImNvbmZpZ3VyZSIKKyNs aW5lIDE5Nzg5ICJjb25maWd1cmUiCiAjaW5jbHVkZSAiY29uZmRlZnMuaCIKIAogI2lmIEhB VkVfRExGQ05fSApkaWZmIC0tZ2l0IGEvZ2NjL2NvbmZpZ3VyZS5hYyBiL2djYy9jb25maWd1 cmUuYWMKaW5kZXggNDQ2NzQ3MzExYTYuLjliZWM5Y2Y5Yzg1IDEwMDY0NAotLS0gYS9nY2Mv Y29uZmlndXJlLmFjCisrKyBiL2djYy9jb25maWd1cmUuYWMKQEAgLTI1MDEsNiArMjUwMSwx MiBAQCB0aGVuCiAgICAgQlVJTERfTERGTEFHUz0nJChMREZMQUdTX0ZPUl9CVUlMRCknCiBm aQogCisKK2lmIHRlc3QgeCRlbmFibGVfZml4aW5jbHVkZXMgPSB4bm87Cit0aGVuCisgICAg U1RNUF9GSVhJTkM9JycKK2ZpCisKICMgRXhwYW5kIGV4dHJhX2hlYWRlcnMgdG8gaW5jbHVk ZSBjb21wbGV0ZSBwYXRoLgogIyBUaGlzIHN1YnN0aXR1dGVzIGZvciBsb3RzIG9mIHQtKiBm aWxlcy4KIGV4dHJhX2hlYWRlcnNfbGlzdD0KLS0gCjIuMzYuMQoK --------------g99eBpJiUH4mQ7A471vDZQMH--