From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2082.outbound.protection.outlook.com [40.107.104.82]) by sourceware.org (Postfix) with ESMTPS id 5D3493858D1E for ; Tue, 20 Jun 2023 09:03:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5D3493858D1E Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QfBWHau2aZ9L/i3EL/0aTZGctz0Az8ei1ulRgyxjayA7vL/+oGL3ylfk+ZFoo2V8Z1Ajcd1LyeP128NZHSQtnuhPFozMBqSnDqYqDjKowFG5oV6gBkNJC7nbOqUcea9G77GFUhAVXHIOamj3S3xdO7udvmkyHze0XeJb0SCkKAXFpx9wxcGs/Ar+pmtYnG8iPZrvCCXKU9Sm93tzQMp/zKLRq6FlxXb9ODgtbGU3JXylM8aakPr0BOSnzRWD8pTuQRfJukYU0lTIUpmDFBa7Z8W+e7nahV2/5C/1wv7QaLiQcbfnjwH5bQjh2z8/dYtvqKcqQGMEBmof3Am5aKhyEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=62G74Dn3Kb+gQUIeIskU9lLtIDU3dQLQoo3Ij/Sj9tQ=; b=JArR+R/tZK9CuNhCOUArLho5FLLlRhWIof/gcuuAdsuVgvURuBZbVTw/HJBeu7tz4YpXZAzg4rGwNK/b5QO0L71PDksy9A/qKM7cZ0erVTNeoTpj07vYOtPW+MVuByCiYTx3OMCVMxtH0HvC8mA/zo86ENhbAY3JXxZexDxBdCPI08yay2NoosEK6O+uPDjzoV+JeRLlIKZabPeNNBGRkINlZAHW+quymiwvq3ejrPkfgOuTqz0gZmGyoeB2lkeBuJITJr2QyfcvP2qvEIVSH3k96/qYSNcJHJ/HWeIhCFLUuRLWYn841voO6+3I8N7OypApaaucJ5eUFLJ5l8FeQw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=suse.com; dmarc=pass action=none header.from=suse.com; dkim=pass header.d=suse.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=62G74Dn3Kb+gQUIeIskU9lLtIDU3dQLQoo3Ij/Sj9tQ=; b=HZFmEaWz9cMhCqbzHl3FVxYM00SClvK3sV7P3xsD0f6QFsGr7FaDNLkO8/FDcYVZZtg65AjQxeNjl2A3cBVfRQfeuRk0BPLFGZFr5VOp6IckavHcySLSo01vmVV6iN1m7OWVctLt5eUW83YduGjkgKfDugGeknobjB3f/q7LZyXt6WKRhDE5zUYRHWsUhmMgqGk8wZGx8Zi7EqUhQb5IIDixGPSACCOgZ0m06ZrX5BmA/WgIkhjM0JXa261XEtx21oGK6J6E6CU6l7+lBEfHE8b6YTcNRxn+Fnhtij6AFWkbHtHg/dZS9esM0ERJKzrdarxLMIcLRNY1IEph1j/+tA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=suse.com; Received: from VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) by PAXPR04MB8272.eurprd04.prod.outlook.com (2603:10a6:102:1c1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.36; Tue, 20 Jun 2023 09:03:46 +0000 Received: from VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c]) by VE1PR04MB6560.eurprd04.prod.outlook.com ([fe80::e442:306f:7711:e24c%5]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 09:03:46 +0000 Message-ID: <7a8c5593-c53d-9c45-ffcd-c48cdd3ef911@suse.com> Date: Tue, 20 Jun 2023 11:03:45 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3] x86: make VPTERNLOG* usable on less than 512-bit operands with just AVX512F Content-Language: en-US To: Hongtao Liu Cc: "gcc-patches@gcc.gnu.org" , Kirill Yukhin , Hongtao Liu References: <169ca252-3828-b466-4d47-a8fe720ec4ef@suse.com> From: Jan Beulich In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: FR0P281CA0068.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::13) To VE1PR04MB6560.eurprd04.prod.outlook.com (2603:10a6:803:122::25) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: VE1PR04MB6560:EE_|PAXPR04MB8272:EE_ X-MS-Office365-Filtering-Correlation-Id: 628eeb5a-40ba-4e09-1904-08db716d40e6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iNg15DO1/z1mH2ka3sKgpdZ8+e9UGZXVb9InDgq9x8+eXK4p3sMIXGA0Afh4O+9ycmLrgzm15n08sanqomyAbXn78B9stdDkUpFkTT2P4S5CGbbRF2HncmHB24sU/mdLv1d0a7zOAwJaktlXBaVAemPEcgcmyyd8Pqf0w69oN+grB+CK+bwe4SoDjM6/tXOLuM4w1PMKLbvkpngsfsx2jZxxZjsWmyrSWJQnBQXEeD2eDlh6bRF4YSmf59qutcOIOb/HxmQeGZa/b9ltYX54tBKOItM0spF4qp+YMwat6hj0GzMFMRCcFIqBxmq5endcZyMRzu9BNcxWu6imQusyuBoskVc9oviC0rEsxsfHjBID2M1kgGYVGj5CA92NGXkRHcE8rqyg2dP4CtHLKQ7zrr+QlRDpYealu3q+1eYKkm3Po/JHV5naUVvMiiAb6zV5AMlN+MDXH81w2uCx6L+tqknlYfRWfHgWgIU9LVdtDsegf5UAqGCpQwX4iLbybXjMXrUOf0QfT3/9qN/rfkc/NriZZvac2S6mPbkAg2/NWT3i9VJ8Oh4YTNaxEvVDO2jFVjcZ9iRGcLaMhkcfKL6oZMsXvTdR4k/B7640XQ59LCa+tVr3iLeyePWkmE+lC4TNfrNMd7cmZCmvOREr8Z3n9Q== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VE1PR04MB6560.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(346002)(39860400002)(396003)(376002)(366004)(451199021)(6486002)(478600001)(186003)(6512007)(6506007)(53546011)(26005)(2616005)(36756003)(38100700002)(86362001)(31696002)(66556008)(66476007)(6916009)(66946007)(4326008)(316002)(41300700001)(2906002)(5660300002)(31686004)(8936002)(8676002)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S0ljcGw2ZXJaUWpUMWp6aXUxZ2VVazBFQWgweVNLYTR4dlV6Q3dnYUpqRnBD?= =?utf-8?B?UmdQdzNvNDhkczZKMzJXekJJVzI4MGVtYnRuRFBlTHFlNzV2TmZJdmN3V3pj?= =?utf-8?B?dHRQZThOMjhqL09jVkU0Rlpyem5yTTNyVVBwcUhGdHQ3d01CVVc0cUR1Zi9q?= =?utf-8?B?Wjlma2UraDdka01GTkM4ekgranBTMVpZbERGZ0ZsQjdBS042Y0czcDM3amRP?= =?utf-8?B?SUVKWTJxRTVPYnpENndmYmRhRWtZeUhXbk1wZ2djOVV1NnI2NHE1ZXdabUtz?= =?utf-8?B?N3RxbDlKV3ByT1JxSUYrQkpla012Y1V3bkN3WmoyUzlBMS9JSU5rMFQ2a0l6?= =?utf-8?B?eUR0cXNlSXRLNG1aOHFIVDg4RTVuVHYxTm8yVy93S2dCOUU2S3o3L1NIb2dY?= =?utf-8?B?TGhtbGNrcnRSUVZpT2hlaEZnT052eDhnaWQ3NjFQcmRxR1hjQkVTSkg2OFNU?= =?utf-8?B?SlZDaHN1RGtKNlZmcjF3QVd5N2lhMnNvMWNTMkE5aDJUSEtUeEJuNWlSUnpD?= =?utf-8?B?L2FYRm5BZm5TT3dPeDlLNmhpSWpwVUtUeWt6dm8yOXoxRFpSZDFOdHNSOUxG?= =?utf-8?B?ZWg1UmZ0ZFJKYU5vNnRLaC85NkpQemQ5V2E1QnFnMmszaW93UXpXck5KVTRL?= =?utf-8?B?Y3kxSWJRd0tTM29YVm83Z0szMFFYRHZsZGlrMERVVlhqME1HQXRremdnNURj?= =?utf-8?B?eFRTRExTWkFMNlRURnpxb2M0VjRSS0JFRmhMVXFodUxocEZuSmpoaWdZcGtj?= =?utf-8?B?UHBHYUEvcGljcGhZZjNmdUx1NDBpRCtFMWpwV2tuRXRxMUlGaHNwejVFR25D?= =?utf-8?B?ZFVmN201Qy9ZazZzekNqQWh5cDNubU14OWtKWW0rUDlCRFNFQXlrdkI3enJY?= =?utf-8?B?bzFkSERjQ0o5N3BPbk9jeXBOMXhjZGF2ajBkdXJQeW9KbHFZVFNlU2RyWjZl?= =?utf-8?B?THJ4S3FUbExYWTRCOTZFM3RRdzAxUjk1eVE3U3ZNenF4VXVXWTRNemNFcEhY?= =?utf-8?B?T3pVV3pMK2F1alpWQy9jVGRUOVdnZ2U2eWQ5M3Z4UjVUS3Q0OUNIWW5lK0Yx?= =?utf-8?B?am1NeGlBYmt2blpvYmc2cGdVdzlCN050ZWpMWEtXYVVZYkh3MWdjU3dubkli?= =?utf-8?B?WTdzZzVDWFhiWnVta3FIdk9aYW5nTEY1TmRTQUN4YmtyRDNSZWJQUUd1K3Mz?= =?utf-8?B?SkoySEhhZkxoSTNPaTJubWx3Lys2SGJJQVNWcVhrdjA2aUdEWE1mYjU1R2Nh?= =?utf-8?B?VVRTdVUwUlRGQXl3MG1hNnErenhOWkpUbGJla3BLeVMvQzZObXV5SGRTR0Mr?= =?utf-8?B?d2VNSXE1bEZMTzVsWXNUNENxdGo2U3E5M1ExT2poZHFRRzhMcnFlMEpKcGZx?= =?utf-8?B?MmJvWGR6UDBTMmFlVnpZSXhmTUs4YVRVdGNlRkJXUHk4ZmVnUFVYMWJUUUJF?= =?utf-8?B?ak8xanA0c1NoellYWEpTS0tyak0vMmJUcGVuZVcrTmRaM2t5a1FITnd2N0gy?= =?utf-8?B?RUJRRjR2eWFpMTBJSFZBV1cxVUdsWGtrcWJBNWoyOVRKUWVXT3BqVlU0TTdN?= =?utf-8?B?bCt0N05GbUJaR0UvU0VBRkFsWUlhMERwU2FHL1lFTXl2c0VFZHI2YlJnaExT?= =?utf-8?B?dG1nM1d2NG5GNFNIMGplbmN1bnR3NFRnd2YxdkpZNG5rY2RNYWQwSjgyalFj?= =?utf-8?B?NGdKRmdqZjljRWJsRWJObmNsU21PdmU3Ylk3dWZDNkpoRjRadHFERTRSR1gw?= =?utf-8?B?YktSU28wVHg1RUdrT0psM3dVdVhveUVTbmx0bEU4aW16S0MvOFBxdjhnRnJV?= =?utf-8?B?VE05RTdLSTV3dFgrRm92VVNYbHQzNk5IemNMa1BrNVI0MklpVHJYQnlRRkIr?= =?utf-8?B?WnA5MGRycUJLVUxzbFRKKzdQemFMeGZkTWlUM3RWVWRzZXJwbkZiK0dPVnZq?= =?utf-8?B?OXFuKzVDR1FxZEwyRTVEblFtSStkMVFxenNxSEM5OU1qcFY0bFNjeFBhbDdX?= =?utf-8?B?OHREc0gvMVpNZnNZeE9BaEo5S3NIWitiVmtmQ2xJTFRJcW15bVhRVWJMajJG?= =?utf-8?B?L0laVWhuMjhRdTA2aUFHRDRZVmhJTllZdTVWZjN6TzY2ZXc4eEQzVDIwd0FJ?= =?utf-8?Q?+xqLaNYEb+jMPCg37eGr+lnv6?= X-OriginatorOrg: suse.com X-MS-Exchange-CrossTenant-Network-Message-Id: 628eeb5a-40ba-4e09-1904-08db716d40e6 X-MS-Exchange-CrossTenant-AuthSource: VE1PR04MB6560.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 09:03:45.9743 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WMTdafMGx8+wZdFCz8MyW0PHei6OCu49FU7SdcP4Neh3PqW9iaTp/LFX8l1pVqLMK0gzBGfZZzxbr+xiZ8JQtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8272 X-Spam-Status: No, score=-3027.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20.06.2023 10:33, Hongtao Liu wrote: > On Tue, Jun 20, 2023 at 3:07 PM Jan Beulich via Gcc-patches > wrote: >> >> I guess the underlying pattern, going along the lines of what >> one_cmpl2 uses, can be applied elsewhere >> as well. > That should be guarded with !TARGET_PREFER_AVX256, let's handle that > in a separate patch. Sure, and as indicated there are more places where similar things could be done. >> --- /dev/null >> +++ b/gcc/testsuite/gcc.target/i386/avx512f-copysign.c >> @@ -0,0 +1,32 @@ >> +/* { dg-do compile } */ >> +/* { dg-options "-mavx512f -mno-avx512vl -O2" } */ > Please explicitly add -mprefer-vector-width=512, our tester will also > test unix{-m32 \-march=cascadelake,\ -march=cascadelake} which set the > - mprefer-vector-width=256, -mprefer-vector-width=512 in dg-options > can overwrite that. Oh, I see. Will do. And I expect I then also need to adjust the newly added avx512f-dupv2di.c from the earlier patch. I guess I could commit that option addition there as obvious? > Others LGTM. May I take this as "okay with that change", or should I submit v4? Jan