public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Gerald Pfeifer <gerald@pfeifer.com>
To: "Arsen Arsenović" <arsen@aarsen.me>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] update_web_docs_git: Add updated Texinfo to PATH
Date: Thu, 20 Apr 2023 22:14:33 +0200 (CEST)	[thread overview]
Message-ID: <7af14864-04f1-0b56-2236-507b0eefcbf8@pfeifer.com> (raw)
In-Reply-To: <87edomcim4.fsf@aarsen.me>

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

Hi Arsen,

On Fri, 14 Apr 2023, Arsen Arsenović wrote:
>> Did you intentionally not implement the following part of my suggestion
>>
>>    if [ x${MAKEINFO}x = xx ]; then
>>    :
> > that is, allowing to override from the command-line (or crontab)?
> (answering both the questions)
> 
> This := operator is a handy "default assign" operator.  It's a bit of an
> oddity of the POSIX shell, but it works well.  The line:
> 
>   : "${foo:=bar}"
> 
> is a convenient way of spelling "if foo is unset or null, set it to
> bar".  the initial ':' there serves to discard the result of this
> evaluation (so that only its side effect of updating foo if necessary is
> kept)

I understand, just am wondering whether and why the : is required? I 
don't think we are using this construct anywhere else?

(I was aware of the ${foo:=bar} syntax, just caught up by you pushing
that part of the logic to the lowest level whereas I had it at the top
level. That's purely on me.)

Please go ahead and push this (or a variant without the : commands) and
I'll then pick it up from there.

Gerald

  reply	other threads:[~2023-04-20 20:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-06 10:35 Arsen Arsenović
2023-04-10 21:45 ` Gerald Pfeifer
2023-04-10 22:15   ` Arsen Arsenović
2023-04-14 19:29     ` Gerald Pfeifer
2023-04-14 20:25       ` Arsen Arsenović
2023-04-20 20:14         ` Gerald Pfeifer [this message]
2023-04-20 20:53           ` Arsen Arsenović
2023-04-21  7:00             ` Gerald Pfeifer
2023-04-21  8:46               ` Arsen Arsenović
2023-04-10 21:49 ` Gerald Pfeifer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7af14864-04f1-0b56-2236-507b0eefcbf8@pfeifer.com \
    --to=gerald@pfeifer.com \
    --cc=arsen@aarsen.me \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).