From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by sourceware.org (Postfix) with ESMTPS id 453163858D33 for ; Thu, 18 Jan 2024 20:20:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 453163858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 453163858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::534 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609210; cv=none; b=ECx1evtPv3icGcRs82T/9Kafc6iMZR1hvhCw7rdesOqtym8V2TkiBa1Y0HYhWHdW9xAYD2qqoAP9R7/F/S3epkenh5SMENaF/aR+1gVlmXlgd3DJX/nMO5xXYwltbvMxC/LcMACBJLeNLGbn1R7ENU64DUXjdcL3NfX1XPxTQd0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705609210; c=relaxed/simple; bh=wxCDZGoMZVOalETOHZYS0aPpGhqE8UDINgG2NPJGWPQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=BQ6E/2iY9L5L//wqqgjjP5DLkW5XJUn1Pi4EKcD/agzP8HtuPItYX64aEYdwJUps+uOHjuTi0jXFwrTcbq0K8zZFYM8QIhUK555h45eaSJqjbPRhFTVYocL3kdEu1rnPbvmzbKYZdftmQ7rPMWnSQaNyNP4zJXK0OTq1Ao5MUU8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-55a356f8440so1000139a12.2 for ; Thu, 18 Jan 2024 12:20:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; t=1705609207; x=1706214007; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6BsTVEwkF1bqtI0fICBHOIRLpv2yZrv9pZJ3KH2FJo0=; b=g61WTRQfSvQJNsDr6xJgU7pN2ZckNYOeeHXVp44Qa/2fILRjeW6yw1DD5n+z7qUZtF CoUxr7XFENWt0O/oJ9lIspgtG3u2isMswP7mVwl8hXCEaujea8TU7ahCf8jOWHaKM5m1 IRelNa//H8+KCOov8s9V+e39wyiqzR8Zz2CgBEDUSxuvdB7iF9sBGSdaC3ONHpFRZ/ke GsZBgDyHS7wFYbxPXEHOJnWGNrHhiTU0cpyZQLkMAfdPO5EFNGM8r2EVrE+6wBc+zIXR si4immbyYh+9jnDBPWrGxVZMloMdv+vggA6X84lILioUbCRZqi05kPB0QP4Y630DB6Ui jinA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705609207; x=1706214007; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=6BsTVEwkF1bqtI0fICBHOIRLpv2yZrv9pZJ3KH2FJo0=; b=K9mSKfd8jpVJ3NkDre4Bol8uKIcq099NEvK0Uh/+GjqkXFKJXsLFeFNpz9zI39aauv 4FuwFcRSaB7gR2Gs3V8PNkavPsCR9eqeu5cuy/iqr1Pa2vH9CgXdb9QmwzMHDK03bm5V MKw/HkgT9ZsMBK9jGd3IHJ7OtVDVTbookX9ym2vsarQgGu20LI1gDTgTVD48VGxWrw4a PcDKw/XybLCpf0HaWrBWUOFW9QqB02fsZLyaPzjPYmakqBLKMFbs9sv2CwKLsNr48/3t 1GpkK+POsjw9Pl/3Jct0+RQkW8Aok/i1Vhgs+LVNx0azhtRHx/sqaI2Ga+hRcWUgqv7+ 0xiQ== X-Gm-Message-State: AOJu0YxaZ4Ghx+VdELBCgVQMjERcdHwuFm0sta3QTHW/ES/Ns3fiFapZ zsVt0rBqoHFzu0dhdTW9wORVKEOsMIHQTYnN0xYMq/kj35Mf55qGPiFtPDUe1ARTx+lAPP+DZKo = X-Google-Smtp-Source: AGHT+IEsfoSj2RBFcwWSVq6l2MHSh+KWA4fn/XwQ3sRI7IWvnNzNjMhLkLnxUa+187qQ3BBOCJlvsg== X-Received: by 2002:aa7:c652:0:b0:559:b27b:e3e7 with SMTP id z18-20020aa7c652000000b00559b27be3e7mr868858edr.62.1705609206831; Thu, 18 Jan 2024 12:20:06 -0800 (PST) Received: from ?IPV6:2a04:cec2:28:c7b4:d00c:36ef:969e:37f6? ([2a04:cec2:28:c7b4:d00c:36ef:969e:37f6]) by smtp.gmail.com with ESMTPSA id es18-20020a056402381200b00554b1d1a934sm9892092edb.27.2024.01.18.12.20.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jan 2024 12:20:06 -0800 (PST) Message-ID: <7af3ddc9-46f8-41d1-ad7a-86a93bce424b@embecosm.com> Date: Thu, 18 Jan 2024 21:19:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [COMMITTED] rust_debug: Cast size_t values to unsigned long before printing. Content-Language: en-US To: Rainer Orth Cc: gcc-patches@gcc.gnu.org, gcc-rust@gcc.gnu.org References: <20240118090056.2910410-2-arthur.cohen@embecosm.com> <7b53ee9e-1830-4878-9e12-b3e748a2e4fd@embecosm.com> From: Arthur Cohen In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Rainer, On 1/18/24 10:34, Rainer Orth wrote: > Hi Arthur, > >> Yes, I was talking about this on IRC the other day - if we do run in a >> situation where we have more than UINT32_MAX procedural macros in memory >> we have big issues. These debug prints will probably end up getting removed >> soon as they clutter the output a lot for little information. > > makes sense, especially if they break the build once in a while ;-) > >> I don't mind doing it the right way for our regular prints, but we have not >> been using PRIu64 in our codebase so far, so I'd rather change all those >> incriminating format specifiers at once later down the line - this patch >> was pushed so that 32bit targets could bootstrap the Rust frontend for now. > > Makes sense: using different styles throughout the codebase only creates > confusion. > > On a related issue: didn't you have some 32-bit host in your CI? I > remember having similar issues in the past which could easily be avoided > in advance this way. We do have 32 bits runners in the buildbot Mark takes care of, but they were not running bootstrap builds so this was getting ignored as it only produced a warning. Definitely something I want to fix quickly. > > Thanks. > Rainer >