From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 765943885C31 for ; Wed, 22 Nov 2023 22:32:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 765943885C31 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 765943885C31 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::231 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700692349; cv=none; b=YS3q8QMD8LWfe324yCvVAAEAETvz4YNheO7KcegSFNo7Epu2YJ4G1uI58Lf8cu1WEBi4y4K3YQvsJ1PO7fanU6nmARPgQ7nhhnHZY8YfrXod76G3zzgPFi4QALZ4VeYEV2gYgvKKdvYx/fu5FHrZlfYdEk05cgSn1fz2rskk5nw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700692349; c=relaxed/simple; bh=NXgVVRT5UIuGJav1BgxWbrqNvis4GsLPZM3vAbFrpNM=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=wZ1+LPqr5czn165lPXyT0HHyPHyLekL0ij7zHbyYrbitszShzO2fbm/lkhmM0R9wU5jAhYky7O/bwqL29GvqZqelkgj1jNml9F+kqxbjEJb9vwFmv7UwNY4i8n0jdrbYGzYEBn2GeD1uCqN0jyPhe49LDjMVXCt13G69aDpMM00= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-3b842c1511fso197959b6e.1 for ; Wed, 22 Nov 2023 14:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700692338; x=1701297138; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=AK3Kg7nwLIoeR3+pM1LaEBjE7CKf+S1kBPliOYbxJR0=; b=Ku7MMjwvbeDgHihGD5vFUki7FgCGzV9cFMar7AfijeM86mVepevGBQLLlXWtC0+Dn9 xY+hJAhlUH+HzObPI1xPKpN5Orfj4vC+r2Uosd/fByJrQNlqpOVXna1GPUHEtpbSvbpV TO6e1K1bt2AjoE6L9Ou7RmEz1onTRYVLvpJ3qgYm+2BeKltsAmtoLTALHLMEPUe9LXe/ ztpN5NwsGGr24f8ByC2oSZeBeUvEfg6jbo6Pd3/TOVwPdjtm+R1brCTGou61iQSiGZMz 54Kt+d9QsXbqNk48sSdCAKLB5JaDh+G0X/bDC5nfxHMYoEZd6+gPjafRh9relN6Ilad0 R29w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700692338; x=1701297138; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=AK3Kg7nwLIoeR3+pM1LaEBjE7CKf+S1kBPliOYbxJR0=; b=EXCgZxX/SmOX2u2uIrWOjZg6QEsZ0nTV8OEMc4yoNYamqfKPGdJCMgjNgLuvNuFapp JUaGP096AdIec86SgO/SeHbXy/bPuavAQx/5iBC61h2BZ7iZl7LSWtaijSGcX2CIQkqS DlA0NGI6UkZYqhdZNMALgA55mti2zhkDIJd0/Y+haPTQ394o82y6J0v0jYlJeNZnAnMj s1wU3fI2I5zaLMUAfc1FuDjWrtw+Qm33MOVnzn7mfPFk8e4KHV9PLrYyOIm6WRnN3F4r ZPHWBSDFw876xZ3bpo0V6qnzlUOxfrrIsXEyOs2T5o2GLDW94FrtjTuyiBpWXpvMNpaC RPFg== X-Gm-Message-State: AOJu0YxtXi4iiVAzynwKyLqQTaFfI6929Ai5a2wEdGnG3/iAjmy2N9ig RBzpoW6pwZX4F3wo/n0+igA= X-Google-Smtp-Source: AGHT+IHtUUrvicjtx/pUGgvzGrMGI6byt36iAL5p+mcoAWUJ7qcBTXPH80+FVeJxCWzalTP8ugvwKw== X-Received: by 2002:a05:6870:6711:b0:1ef:b109:b8ca with SMTP id gb17-20020a056870671100b001efb109b8camr4292950oab.34.1700692338570; Wed, 22 Nov 2023 14:32:18 -0800 (PST) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id d16-20020a05683018f000b006c619f17669sm4346otf.74.2023.11.22.14.32.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 Nov 2023 14:32:18 -0800 (PST) Message-ID: <7b03e1a1-cf1d-40ac-96d0-6cf5d33d61d0@gmail.com> Date: Wed, 22 Nov 2023 15:32:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] testsuite/unroll-8: Avoid triggering undefined behavior Content-Language: en-US To: Palmer Dabbelt , gcc-patches@gcc.gnu.org References: <20231121232704.12336-3-palmer@rivosinc.com> From: Jeff Law In-Reply-To: <20231121232704.12336-3-palmer@rivosinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/21/23 16:27, Palmer Dabbelt wrote: > I was poking around with this test failure and noticed it was exercising > undefined behavior. The return type doesn't matter for what's being > tested, so just mark it as void. > > gcc/testsuite/ChangeLog: > > * gcc.dg/unroll-8.c: Remove UB. I just reviewed the history of unroll-8, I don't think this compromises the test's original intent. OK for the trunk. jeff