public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Aldy Hernandez <aldyh@redhat.com>
To: GCC patches <gcc-patches@gcc.gnu.org>
Cc: Andrew MacLeod <amacleod@redhat.com>,
	Richard Biener <richard.guenther@gmail.com>
Subject: Re: [PATCH] Add inchash support for vrange.
Date: Tue, 18 Apr 2023 11:17:02 +0200	[thread overview]
Message-ID: <7b17f703-ef60-b303-a293-4e7309d83a66@redhat.com> (raw)
In-Reply-To: <20230418090637.253140-2-aldyh@redhat.com>

> +namespace inchash
> +{
> +
> +void
> +add_vrange (const vrange &v, inchash::hash &hstate,
> +	     unsigned int)
> +{
> +  if (v.undefined_p ())
> +    {
> +      hstate.add_int (VR_UNDEFINED);
> +      return;
> +    }
> +  // Types are ignored throughout to inhibit two ranges being equal
> +  // but having different hash values.  This can happen when two
> +  // ranges are equal types_compatible_p is true.

Sorry, this comment should read:

+  // Types are ignored throughout to inhibit two ranges being equal
+  // but having different hash values.  This can happen when two
+  // ranges are equal and their types are different (but
+  // types_compatible_p is true).


  reply	other threads:[~2023-04-18  9:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-18  9:06 [PATCH] Add support for vrange streaming Aldy Hernandez
2023-04-18  9:06 ` [PATCH] Add inchash support for vrange Aldy Hernandez
2023-04-18  9:17   ` Aldy Hernandez [this message]
2023-04-18  9:33   ` Jakub Jelinek
2023-04-18 10:32     ` Jakub Jelinek
2023-04-18 10:50       ` Aldy Hernandez
2023-04-18 10:59         ` Jakub Jelinek
2023-04-18 11:33           ` Aldy Hernandez
2023-04-18 11:34             ` Jakub Jelinek
2023-04-18 12:48 ` [PATCH] Add support for vrange streaming Aldy Hernandez
2023-04-27 11:00   ` Richard Biener
2023-04-27 11:36     ` Aldy Hernandez
2023-05-17 14:08       ` Aldy Hernandez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b17f703-ef60-b303-a293-4e7309d83a66@redhat.com \
    --to=aldyh@redhat.com \
    --cc=amacleod@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).