public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Luis Machado <luis.machado@linaro.org>
To: Jeff Law <law@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH, obv?] Fix missing newlines from local-pure-const pass dump
Date: Mon, 04 Dec 2017 17:04:00 -0000	[thread overview]
Message-ID: <7b1b2431-64e4-13d9-e730-3d3d5dfea8ce@linaro.org> (raw)
In-Reply-To: <ecf1bbd1-6a4e-6b28-73c4-0adbfc87a68b@redhat.com>



On 12/04/2017 02:01 PM, Jeff Law wrote:
> On 12/01/2017 11:42 AM, Luis Machado wrote:
>> I noticed the debugging output from local-pure-const pass is missing a
>> newline in a couple places, leading to this:
>>
>>   local analysis of main
>>     scanning: i ={v} 0;
>>      Volatile stmt is not const/pure
>>      Volatile operand is not const/pure  scanning: j ={v} 20;
>>      Volatile stmt is not const/pure
>>      Volatile operand is not const/pure  scanning: vol.0_10 ={v} i;
>>      Volatile stmt is not const/pure
>>
>> It should've been:
>>
>>   local analysis of main
>>     scanning: i ={v} 0;
>>      Volatile stmt is not const/pure
>>      Volatile operand is not const/pure
>>     scanning: j ={v} 20;
>>      Volatile stmt is not const/pure
>>      Volatile operand is not const/pure
>>     scanning: vol.0_10 ={v} i;
>>      Volatile stmt is not const/pure
>>
>> Seems fairly obvious. OK?
>>
>> gcc/ChangeLog:
>>
>> 2017-12-01  Luis Machado  <luis.machado@linaro.org>
>>
>> 	* ipa-pure-const.c (check_decl): Add missing newline.
>> 	(state_from_flags): Likewise.
> OK.
> jeff
> 

Thanks. Pushed now.

      reply	other threads:[~2017-12-04 17:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01 18:42 Luis Machado
2017-12-04 16:01 ` Jeff Law
2017-12-04 17:04   ` Luis Machado [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7b1b2431-64e4-13d9-e730-3d3d5dfea8ce@linaro.org \
    --to=luis.machado@linaro.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).