[PATCH, obv?] Fix missing newlines from local-pure-const pass dump

[PATCH, obv?] Fix missing newlines from local-pure-const pass dump

[Luis Machado]

I noticed the debugging output from local-pure-const pass is missing a
newline in a couple places, leading to this:

 local analysis of main
   scanning: i ={v} 0;
    Volatile stmt is not const/pure
    Volatile operand is not const/pure  scanning: j ={v} 20;
    Volatile stmt is not const/pure
    Volatile operand is not const/pure  scanning: vol.0_10 ={v} i;
    Volatile stmt is not const/pure

It should've been:

 local analysis of main
   scanning: i ={v} 0;
    Volatile stmt is not const/pure
    Volatile operand is not const/pure
   scanning: j ={v} 20;
    Volatile stmt is not const/pure
    Volatile operand is not const/pure
   scanning: vol.0_10 ={v} i;
    Volatile stmt is not const/pure

Seems fairly obvious. OK?

gcc/ChangeLog:

2017-12-01  Luis Machado  <luis.machado@linaro.org>

	* ipa-pure-const.c (check_decl): Add missing newline.
	(state_from_flags): Likewise.
---
 gcc/ipa-pure-const.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gcc/ipa-pure-const.c b/gcc/ipa-pure-const.c
index bdc7522..22f92fc 100644
--- a/gcc/ipa-pure-const.c
+++ b/gcc/ipa-pure-const.c
@@ -332,7 +332,7 @@ check_decl (funct_state local,
     {
       local->pure_const_state = IPA_NEITHER;
       if (dump_file)
-        fprintf (dump_file, "    Volatile operand is not const/pure");
+        fprintf (dump_file, "    Volatile operand is not const/pure\n");
       return;
     }
 
@@ -446,7 +446,7 @@ state_from_flags (enum pure_const_state_e *state, bool *looping,
     {
       *looping = true;
       if (dump_file && (dump_flags & TDF_DETAILS))
-	fprintf (dump_file, " looping");
+	fprintf (dump_file, " looping\n");
     }
   if (flags & ECF_CONST)
     {
-- 
2.7.4

Re: [PATCH, obv?] Fix missing newlines from local-pure-const pass dump

[Jeff Law]

On 12/01/2017 11:42 AM, Luis Machado wrote:
> I noticed the debugging output from local-pure-const pass is missing a
> newline in a couple places, leading to this:
> 
>  local analysis of main
>    scanning: i ={v} 0;
>     Volatile stmt is not const/pure
>     Volatile operand is not const/pure  scanning: j ={v} 20;
>     Volatile stmt is not const/pure
>     Volatile operand is not const/pure  scanning: vol.0_10 ={v} i;
>     Volatile stmt is not const/pure
> 
> It should've been:
> 
>  local analysis of main
>    scanning: i ={v} 0;
>     Volatile stmt is not const/pure
>     Volatile operand is not const/pure
>    scanning: j ={v} 20;
>     Volatile stmt is not const/pure
>     Volatile operand is not const/pure
>    scanning: vol.0_10 ={v} i;
>     Volatile stmt is not const/pure
> 
> Seems fairly obvious. OK?
> 
> gcc/ChangeLog:
> 
> 2017-12-01  Luis Machado  <luis.machado@linaro.org>
> 
> 	* ipa-pure-const.c (check_decl): Add missing newline.
> 	(state_from_flags): Likewise.
OK.
jeff

Re: [PATCH, obv?] Fix missing newlines from local-pure-const pass dump

[Luis Machado]

On 12/04/2017 02:01 PM, Jeff Law wrote:
> On 12/01/2017 11:42 AM, Luis Machado wrote:
>> I noticed the debugging output from local-pure-const pass is missing a
>> newline in a couple places, leading to this:
>>
>>   local analysis of main
>>     scanning: i ={v} 0;
>>      Volatile stmt is not const/pure
>>      Volatile operand is not const/pure  scanning: j ={v} 20;
>>      Volatile stmt is not const/pure
>>      Volatile operand is not const/pure  scanning: vol.0_10 ={v} i;
>>      Volatile stmt is not const/pure
>>
>> It should've been:
>>
>>   local analysis of main
>>     scanning: i ={v} 0;
>>      Volatile stmt is not const/pure
>>      Volatile operand is not const/pure
>>     scanning: j ={v} 20;
>>      Volatile stmt is not const/pure
>>      Volatile operand is not const/pure
>>     scanning: vol.0_10 ={v} i;
>>      Volatile stmt is not const/pure
>>
>> Seems fairly obvious. OK?
>>
>> gcc/ChangeLog:
>>
>> 2017-12-01  Luis Machado  <luis.machado@linaro.org>
>>
>> 	* ipa-pure-const.c (check_decl): Add missing newline.
>> 	(state_from_flags): Likewise.
> OK.
> jeff
> 

Thanks. Pushed now.