From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 2AD803858D28 for ; Fri, 4 Feb 2022 15:02:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2AD803858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0C8E4210FA; Fri, 4 Feb 2022 15:02:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1643986960; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=93wmv4OTe3BxF+nOCcaqVsti0XLQzcX5mJ6dLIRcTJ8=; b=k66zfRjTUjpMEgIXSs5EUwWrCCM9CiplWyMuwn/Wncmbzw4q9kuNS6NidiyrC0m4jQuB28 gZeEhD56yrDoHc03+FkpjRSOiJ5yRg3nqiRtQa19fkXfp640bQDu7p4RjF26ha4M9rDk71 +8ytYgvME5scZ64dtq0sjAe62h4Gdjw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1643986960; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=93wmv4OTe3BxF+nOCcaqVsti0XLQzcX5mJ6dLIRcTJ8=; b=gTxBzutRVEDoXkTYD5KbVO1F5nM4Ajp2vzgLJsVXu3bAAVBfPGMK0ODJfDHKjTrY5/1R8q pDr8FRavYs85KgAA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id ED19F13AA9; Fri, 4 Feb 2022 15:02:39 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id dpacOA9A/WFiHwAAMHmgww (envelope-from ); Fri, 04 Feb 2022 15:02:39 +0000 Message-ID: <7b44d245-f354-a308-b03e-c53b9afc52f7@suse.cz> Date: Fri, 4 Feb 2022 16:02:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH] configure: add --disable-fix-includes Content-Language: en-US To: Rainer Orth Cc: gcc-patches@gcc.gnu.org References: <417eca08-e1ad-538e-c39a-388e20e2fcca@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Feb 2022 15:02:45 -0000 On 2/4/22 14:07, Rainer Orth wrote: > Hi Martin, > >> It seems to me that fixincludes is hardy unused feature for nowadays header >> files and so I'm suggesting a developer option that can skip the fixing. > > please remember that there's a world beyond current-day Linux. Sure! That's why I'm suggesting an option and not removing the machinery. > >> How is the feature used on other targets? > > There are still quite a number of fixes on e.g. Solaris or macOS. And > people are still building gcc on older OS versions for one reason or > another... > >> diff --git a/gcc/configure.ac b/gcc/configure.ac >> index 1171c946e6e..6015e403aa9 100644 >> --- a/gcc/configure.ac >> +++ b/gcc/configure.ac >> @@ -842,6 +842,12 @@ gather_stats=`if test $enable_gather_detailed_mem_stats != no; then echo 1; else >> AC_DEFINE_UNQUOTED(GATHER_STATISTICS, $gather_stats, >> [Define to enable detailed memory allocation stats gathering.]) >> >> +AC_ARG_ENABLE(disable-fix-includes, >> +[AS_HELP_STRING([--disable-fix-includes], > > The beast is called fixincludes, no '-' or '_'. > >> + [skip fixing of includes])], [], > > Better say 'running fixincludes' for example rather than being > vague/obtuse. Note using --disable-fixinclude effectively disables building of everything in the folder. That's not what I want, it breaks GCC build. > > The new options requires documenting in install.texi. > > That said, I'm not sure this is really worth yet adding another option. > And how are developers supposed to know if they can safely use it or > not. Sure. > > Besides, have you actually run a regtest with that option? I'm asking > because even on Ubuntu 20.04 fixincludes drops in it's own . > You need to check that dropping that is actually safe. Let me try that. Martin > > Rainer >