From: Carl Love <cel@linux.ibm.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: gcc-patches@gcc.gnu.org,
Segher Boessenkool <segher@kernel.crashing.org>,
"bergner@linux.ibm.com" <bergner@linux.ibm.com>
Subject: Re: [PATCH 2/13 ver4] rs6000, Remove __builtin_vsx_xvcvspsxws,, __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws built-ins.
Date: Mon, 24 Jun 2024 15:15:05 -0700 [thread overview]
Message-ID: <7b72c4eb-21bb-4105-a508-f20ccf9774c7@linux.ibm.com> (raw)
In-Reply-To: <b9894781-d489-11e0-4170-001aea4f2ca8@linux.ibm.com>
Kewen:
On 6/18/24 20:03, Kewen.Lin wrote:
> Hi Carl,
>
> on 2024/6/14 03:40, Carl Love wrote:
>> GCC maintainers:
>>
>> Per the comments on patch 0004 from version 3, the removal of
>> The built-in __builtin_vsx_xvcvdpuxds_uns and __builtin_vsx_xvcvspuxws was moved to this patch. The rest of the patch is unchanged from version 3. There were no comments on this patch for version 3.
>>
>> Please let me know if this patch is acceptable. Thanks.
>>
>> Carl
>>
>>
>> -----------------------------------------------------
>>
>> rs6000, Remove __builtin_vsx_xvcvspsxws,
>> __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws built-ins.
>
> Nit: Maybe make it shorter like: Remove built-ins __builtin_vsx_xvcv{sp{sx,u}ws,dpuxds_uns}
>
>>
>> The built-in __builtin_vsx_xvcvspsxws is a duplicate of the vec_signed
>
> Nit: Strictly speaking, not a duplicate of vec_signed but covered by it.
>
>> built-in that is documented in the PVIPR. The __builtin_vsx_xvcvspsxws
>> built-in is not documented and there are no test cases for it.
>>
>> The built-in __builtin_vsx_xvcvdpuxds_uns is redundant as it is covered by
>> vec_unsigned, remove.
>>
>> The __builtin_vsx_xvcvspuxws is redundant as it is covered by
>> vec_unsigned, remove.
>
> As mentioned in the previous review, I'd expect patch 4/13 only focuses on
> extending vec_{un,}signed{e,o} for vector float (aka. __builtin_vsx_xvcvspsxds
> and __builtin_vsx_xvcvspuxds related), and this patch focuses on some built-in
> removals which have been covered by the existing vec_{un,}signed{,e,o}, so
> it can also drop the built-ins:
>
> "The built-in __builtin_vsx_xvcvdpsxws is redundant as it is covered by
> vec_signed{e,o}, remove.
>
> The built-in __builtin_vsx_xvcvdpuxws is redundant as it is covered by
> vec_unsigned{e,o}, remove."
>
> // copied from 4/13.
Not sure why I didn't move these two with the other two??? Sorry.
Moved them from patch 4.
Carl
next prev parent reply other threads:[~2024-06-25 3:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 19:23 [PATCH 0/13 ver4] rs6000, built-in cleanup patch series Carl Love
2024-06-13 19:40 ` [PATCH 2/13 ver4] rs6000, Remove __builtin_vsx_xvcvspsxws,, __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws built-ins Carl Love
2024-06-19 3:03 ` Kewen.Lin
2024-06-24 22:15 ` Carl Love [this message]
2024-06-13 19:40 ` [PATCH 4/13 ver4] rs6000, extend the current vec_{un,}signed{e,o}, built-ins Carl Love
2024-06-19 3:03 ` Kewen.Lin
2024-06-24 22:14 ` Carl Love
2024-06-13 19:40 ` [PATCH 7/13 ver4] rs6000, add overloaded vec_sel with int128 arguments Carl Love
2024-06-19 3:03 ` Kewen.Lin
2024-06-13 19:40 ` [PATCH 11/13 ver4] rs6000, extend vec_xxpermdi built-in for __int128 args Carl Love
2024-06-19 3:03 ` Kewen.Lin
2024-06-13 19:40 ` [PATCH 13/13 ver4] rs6000, remove vector set and vector init built-ins Carl Love
2024-06-19 3:04 ` Kewen.Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b72c4eb-21bb-4105-a508-f20ccf9774c7@linux.ibm.com \
--to=cel@linux.ibm.com \
--cc=bergner@linux.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=linkw@linux.ibm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).