From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id B732D3846423 for ; Tue, 25 Jun 2024 03:10:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B732D3846423 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B732D3846423 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=148.163.156.1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719285028; cv=none; b=vJo5mKQqWdOyEyDtVQdsBPkYOHlm2l6fYzlv9OgDfmbCzTlevtUcSXSBFQtcykw8A5OaDDrg3I25AU8au9I4CLzp3zQuS9UHxeig30Ad3igx+t63/3x5p9V4hRNUjE5VIhm+eAlXiolV/zabN7086gtg4ode5OyfokmD2sQOuwg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719285028; c=relaxed/simple; bh=XoC97gpiaL8E1QwZT3pvVBlocvKSjXw9hAs+ZBFWGtg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=GtaLxlcl4zKXTuGQhUVfja1hZOeZ9PQWpCF7ExCpzbgI36iK1cg+IclZsW2o0j8G2uMLXoceaSzcxamrKUMYQHSHvR8OObU1HFTY24hd6tTKFVl6wYVcEqYOaFeCFYK3CvYdkLRHwX114veArqAdkd2FXLuv9zalYs2tswqiVz8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 45OLTDAJ029042; Mon, 24 Jun 2024 22:15:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h= message-id:date:mime-version:subject:to:cc:references:from :in-reply-to:content-type:content-transfer-encoding; s=pp1; bh=3 VhP70Oigrwi90ysWaCx2tHrPpPRkXwfWgo/Qeww6Hs=; b=Mu7ek/w9+Ke2NcXVM 8oKHwGk8hnKQcssSTApGhVOj/2K781on9V1vATXiZmxA0GvchO0nn/jh0S6s9+GT SFAh2Pia94jwctPBX+5lfokeuntfv59J3+x0hsdW/QpmNffe2SS3V+0xFuLSyPPj voOzrdPg3fBCsnK6Pz4iY7xLnQHImMMmK1acNyD0ult9cBm2fUrdYU0X1cqzQM4T zWQs4KbBAYy4VRP2IcVn9gytIc+biVMkapGF5UGg6O75TI8BPdEpszJkAXlkdCeB g9+PPUVbgnUExrjE+0naB0Y7mndMmkwqq+wYKKTF3/jZ54IomwQGe7sTn+xYF4re t7bPQ== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3yygr883f1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Jun 2024 22:15:12 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 45OIqCQB008162; Mon, 24 Jun 2024 22:15:11 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([172.16.1.8]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3yx9b0kamw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 24 Jun 2024 22:15:11 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 45OMF73Q46989736 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 24 Jun 2024 22:15:09 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3EFAE58060; Mon, 24 Jun 2024 22:15:07 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 42C335805F; Mon, 24 Jun 2024 22:15:06 +0000 (GMT) Received: from [9.67.67.158] (unknown [9.67.67.158]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 24 Jun 2024 22:15:06 +0000 (GMT) Message-ID: <7b72c4eb-21bb-4105-a508-f20ccf9774c7@linux.ibm.com> Date: Mon, 24 Jun 2024 15:15:05 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/13 ver4] rs6000, Remove __builtin_vsx_xvcvspsxws,, __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws built-ins. To: "Kewen.Lin" Cc: gcc-patches@gcc.gnu.org, Segher Boessenkool , "bergner@linux.ibm.com" References: <073e4ca4-be47-4037-8719-035c4781b1a9@linux.ibm.com> <4e3c59b0-b6d9-4b29-a65f-c877926a4552@linux.ibm.com> Content-Language: en-US From: Carl Love In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: L-32mIC1HBYS0siAKkPKHiHNQVP7UU5d X-Proofpoint-GUID: L-32mIC1HBYS0siAKkPKHiHNQVP7UU5d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-06-24_18,2024-06-24_01,2024-05-17_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 suspectscore=0 phishscore=0 impostorscore=0 mlxscore=0 mlxlogscore=667 adultscore=0 spamscore=0 bulkscore=0 clxscore=1015 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2406140001 definitions=main-2406240175 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Kewen: On 6/18/24 20:03, Kewen.Lin wrote: > Hi Carl, > > on 2024/6/14 03:40, Carl Love wrote: >> GCC maintainers: >> >> Per the comments on patch 0004 from version 3, the removal of >> The built-in __builtin_vsx_xvcvdpuxds_uns and __builtin_vsx_xvcvspuxws was moved to this patch. The rest of the patch is unchanged from version 3. There were no comments on this patch for version 3. >> >> Please let me know if this patch is acceptable. Thanks. >> >> Carl >> >> >> ----------------------------------------------------- >> >> rs6000, Remove __builtin_vsx_xvcvspsxws, >> __builtin_vsx_xvcvdpuxds_uns, __builtin_vsx_xvcvspuxws built-ins. > > Nit: Maybe make it shorter like: Remove built-ins __builtin_vsx_xvcv{sp{sx,u}ws,dpuxds_uns} > >> >> The built-in __builtin_vsx_xvcvspsxws is a duplicate of the vec_signed > > Nit: Strictly speaking, not a duplicate of vec_signed but covered by it. > >> built-in that is documented in the PVIPR. The __builtin_vsx_xvcvspsxws >> built-in is not documented and there are no test cases for it. >> >> The built-in __builtin_vsx_xvcvdpuxds_uns is redundant as it is covered by >> vec_unsigned, remove. >> >> The __builtin_vsx_xvcvspuxws is redundant as it is covered by >> vec_unsigned, remove. > > As mentioned in the previous review, I'd expect patch 4/13 only focuses on > extending vec_{un,}signed{e,o} for vector float (aka. __builtin_vsx_xvcvspsxds > and __builtin_vsx_xvcvspuxds related), and this patch focuses on some built-in > removals which have been covered by the existing vec_{un,}signed{,e,o}, so > it can also drop the built-ins: > > "The built-in __builtin_vsx_xvcvdpsxws is redundant as it is covered by > vec_signed{e,o}, remove. > > The built-in __builtin_vsx_xvcvdpuxws is redundant as it is covered by > vec_unsigned{e,o}, remove." > > // copied from 4/13. Not sure why I didn't move these two with the other two??? Sorry. Moved them from patch 4. Carl