From: Kamil Rytarowski <n54@gmx.com>
To: coypu@sdf.org, gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/2] Untangle stddef.h a little
Date: Thu, 01 Mar 2018 06:02:00 -0000 [thread overview]
Message-ID: <7ba4c576-fcb5-4771-a415-8eaab713d003@gmx.com> (raw)
In-Reply-To: <20180301024342.GB20007@SDF.ORG>
[-- Attachment #1.1: Type: text/plain, Size: 1449 bytes --]
On 01.03.2018 03:43, coypu@sdf.org wrote:
> hi gcc-patches,
>
> as part of pinging, i'll explain the story of this patch.
>
> I want to make sure all netbsd archs work with upstream gcc.
> in this case, netbsd/arm's EABI support.
> I try to break up my changes into digestible chunks that are rational,
> which is why this change came first.
>
> building netbsd/arm gcc-trunk, I had a build error in libstdc++, because
> this stddef.h relies on include guards:
>
> #if defined(_ANSI_H_) || defined(_MACHINE_ANSI_H_) || defined(_X86_64_ANSI_H_) || defined(_I386_ANSI_H_)
>
> In theory I could have just added:
> || _ARM_ANSI_H_
>
> this felt gross, so I tried a better solution.
> the file even comes with comments like:
> /* Why is this file so hard to maintain properly?
> so I try my best to help.
>
> Please let me upstream local changes. there are a lot of them. and I
> feel unable to get them across.
> I have so many changes that it feels inappropriate to ask for help with
> hard problems like internal compiler errors because upstream GCC hit a
> different problem. I'm not familiar with stuff so this is hard :-(
>
Looks good, ping from my point of view for maintainers.
Adding defined(_*_ANSI_H) for each CPU and flavor of headers on NetBSD
does not scale even for the existing set of supported architectures.
NetBSD/hpcsh uses _HPCSH_ANSI_H_, NetBSD/dreamcast _DREAMCAST_ANSI_H_ etc.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 850 bytes --]
next prev parent reply other threads:[~2018-03-01 6:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-04 7:38 Maya Rashish
2018-02-04 7:41 ` [PATCH 2/2] Simplify: combine cases for dfly+fbsd with vms coypu
2018-02-13 0:41 ` [PATCH 1/2] Untangle stddef.h a little coypu
2018-02-19 22:12 ` coypu
2018-03-01 2:43 ` coypu
2018-03-01 6:02 ` Kamil Rytarowski [this message]
2018-06-19 15:32 ` Joseph Myers
2018-06-19 22:08 ` coypu
2018-06-19 22:43 ` Gerald Pfeifer
2018-06-24 23:19 ` Gerald Pfeifer
2018-06-25 21:37 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7ba4c576-fcb5-4771-a415-8eaab713d003@gmx.com \
--to=n54@gmx.com \
--cc=coypu@sdf.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).