From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41615 invoked by alias); 1 Mar 2018 06:02:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 41547 invoked by uid 89); 1 Mar 2018 06:02:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=01.03.2018, 01032018 X-HELO: mout.gmx.net Received: from mout.gmx.net (HELO mout.gmx.net) (212.227.17.20) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Mar 2018 06:02:55 +0000 Received: from [192.168.0.241] ([89.78.252.225]) by mail.gmx.com (mrgmx101 [212.227.17.174]) with ESMTPSA (Nemesis) id 0LxcbX-1efPKS2W6N-017GNM; Thu, 01 Mar 2018 07:02:51 +0100 Subject: Re: [PATCH 1/2] Untangle stddef.h a little To: coypu@sdf.org, gcc-patches@gcc.gnu.org References: <20180204073846.GA17915@SDF.ORG> <20180301024342.GB20007@SDF.ORG> From: Kamil Rytarowski Message-ID: <7ba4c576-fcb5-4771-a415-8eaab713d003@gmx.com> Date: Thu, 01 Mar 2018 06:02:00 -0000 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20180301024342.GB20007@SDF.ORG> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ve72vOu9AwThU0DMEcPXiPbWF0dVoKcmF" X-UI-Out-Filterresults: notjunk:1;V01:K0:TUZL93/ATOQ=:Gaxzdr79haqiYlzP7y8R55 gFyVapkIL7myzpSGRD+/T/9M2a76gC6DWz6ux2UW44l0vULU7B1R0arjVjCaNumk6/xWWn2yi EbK6DzSh83Q9B1f3MEXeKJWIxloQnMYcRsiZ0uCsnhIoTB/8NgzFqLI3+DeMjqyOChtCgtmi+ GF+7frHBpPfUnWLGQCfUng5Zudzyt9uk0X9+Rm9Bn3slddKeZr1jVRZn6ZayaLN4lT6x1LvYa 1yq+tG/Vqvo9Bebdo5jGnfbwUVOsuJsFTl0jtyKHez8d+4aUJ6+kJob9OlWIdDzcxZYFcEYD0 z6f9e7ipUIdfKr9sRocjXUt7mAqgZ8mnaYqHNkgu8fpWVv5KFaIg97d92A8c9Frs+sB2ZoACZ YUabNo/Y3rtxiX4oYEBQbecMffxd3pNQ6UHkaJtC8Rm/ukfVUrIf94AVT9GzSBjxuy+xPJQV2 yGDnYnfBqqdoHcJCGQCeGcFSsiKl2oWRpVAFZHwd3TqIBnlQUWu9Pg0nqQE8nEV96a4fls58S CGw7FngkAm4R8hw2vInfXoAo6L1lLTDFYpj3V49K91bgIJI5PlthfLt53x3HKiU9chns6NAPE 1HMAiwU2F1ZRPhnOjjClRUe4D+cuZOITpG83ud4G8y4igfV+OVpvxMPB0saJ6NpRM+bmXdkAr DrUH7tmSMzpoJL9dKZ9govNo2Ha5/zT5w4zi3lf2VOlK6nBVVOj6heDUGUgQzJOZicjY2NAnJ aO1hEqcnNY6fazyiMJB8LxLcw9ZTJI62NTspIEVx3olipU1iXc+aNjwKWGT4+5vUAxDRrX+/Z M9sZD3XH9hLHxKs3QulSBrf6riTew== X-IsSubscribed: yes X-SW-Source: 2018-03/txt/msg00009.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ve72vOu9AwThU0DMEcPXiPbWF0dVoKcmF Content-Type: multipart/mixed; boundary="RPN79Q7hax08BW2nx3PjfnG0WWu1kt5Hu"; protected-headers="v1" From: Kamil Rytarowski To: coypu@sdf.org, gcc-patches@gcc.gnu.org Message-ID: <7ba4c576-fcb5-4771-a415-8eaab713d003@gmx.com> Subject: Re: [PATCH 1/2] Untangle stddef.h a little References: <20180204073846.GA17915@SDF.ORG> <20180301024342.GB20007@SDF.ORG> In-Reply-To: <20180301024342.GB20007@SDF.ORG> --RPN79Q7hax08BW2nx3PjfnG0WWu1kt5Hu Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Content-length: 1430 On 01.03.2018 03:43, coypu@sdf.org wrote: > hi gcc-patches, >=20 > as part of pinging, i'll explain the story of this patch. >=20 > I want to make sure all netbsd archs work with upstream gcc. > in this case, netbsd/arm's EABI support. > I try to break up my changes into digestible chunks that are rational, > which is why this change came first. >=20 > building netbsd/arm gcc-trunk, I had a build error in libstdc++, because > this stddef.h relies on include guards: >=20 > #if defined(_ANSI_H_) || defined(_MACHINE_ANSI_H_) || defined(_X86_64_ANS= I_H_) || defined(_I386_ANSI_H_) >=20 > In theory I could have just added: > || _ARM_ANSI_H_ >=20 > this felt gross, so I tried a better solution. > the file even comes with comments like: > /* Why is this file so hard to maintain properly? > so I try my best to help. >=20 > Please let me upstream local changes. there are a lot of them. and I > feel unable to get them across. > I have so many changes that it feels inappropriate to ask for help with > hard problems like internal compiler errors because upstream GCC hit a > different problem. I'm not familiar with stuff so this is hard :-( >=20 Looks good, ping from my point of view for maintainers. Adding defined(_*_ANSI_H) for each CPU and flavor of headers on NetBSD does not scale even for the existing set of supported architectures. NetBSD/hpcsh uses _HPCSH_ANSI_H_, NetBSD/dreamcast _DREAMCAST_ANSI_H_ etc. --RPN79Q7hax08BW2nx3PjfnG0WWu1kt5Hu-- --ve72vOu9AwThU0DMEcPXiPbWF0dVoKcmF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 850 -----BEGIN PGP SIGNATURE----- iQJABAEBCAAqFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAlqXmBwMHG41NEBnbXgu Y29tAAoJEEuzCOmwLnZslRUP/ikOQOQEB8DjpTHeEbvcAwoyeYb9EEjOCoXxFL5L TJzZHNL4ypN25SXZ2ET0zMDHxSJy+gioNX+Yv0KY67jky/pUrz+KuRCNKnEP4OGv yoeHDNh4JKsH8v/P0J7FAmB7lBOSjLPesXBsgT02f6xyFegiGw0pNKs5VUTyo5CT ytckH8gFrHoFLQAew3xyt0UPOhbT7vfycNCleYcuDMtmFT12oFoBaJ/VxAn0Ur6e fNM3uFgxtHwwB60m+mnmIvu9GFwV49PMCIXEMZTNiHUXrW9rzO1TWf3qIo7mSAei Pb0Nl8KPXzJd9I0+7Qreh9nJ2iCmb/YxyU4aKQO3jLoHjq950urOaJ/AMnSz5xRV eVTQA6rG6LQYB/hd5w5Plh5LDzBC6mnZMc+D2wXRRLN2VFFO1X1u9VLFh3n0Oy2R bASeWrZZ1MfxiQOXwS2xtYsQ5LVuS/TX06MN8FuAWvR1DgR9cMhQOOYWVMjsrKhM kMEVl0OO6dqf7gEcmk1ufNwFNtABHLp8gotsh56BvFxsdYzL3sErqHl0VhrP+B6M 4twaYRNQTm5UdAWrvBJl2FNAm4fl3A3V1PmwwrEm6JI/Gx9Vs8q9+u0i4CMw3kGu /yw8XIUitP0f0oWinftd7KEEjucUKCTaUGe/0JkmAlFaMMPKptWcB5rPNlVR7cJT qsjC =EvD9 -----END PGP SIGNATURE----- --ve72vOu9AwThU0DMEcPXiPbWF0dVoKcmF--