From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71899 invoked by alias); 19 Jul 2019 08:54:00 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 71881 invoked by uid 89); 19 Jul 2019 08:54:00 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-16.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3 autolearn=ham version=3.3.1 spammy=nonpic, forcing, independently, HContent-Transfer-Encoding:8bit X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.110.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 19 Jul 2019 08:53:59 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D28DB337; Fri, 19 Jul 2019 01:53:57 -0700 (PDT) Received: from [10.2.206.47] (e120808-lin.cambridge.arm.com [10.2.206.47]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7CBE43F71A; Fri, 19 Jul 2019 01:53:57 -0700 (PDT) Subject: Re: [ARM/FDPIC v5 16/21] [ARM][testsuite] FDPIC: Skip tests that don't work in PIC mode To: Christophe Lyon , "gcc-patches@gcc.gnu.org" References: <20190515124006.25840-1-christophe.lyon@st.com> <20190515124006.25840-17-christophe.lyon@st.com> From: Kyrill Tkachov Message-ID: <7bd35f8e-e694-30ca-f62e-8ed775e76bf9@foss.arm.com> Date: Fri, 19 Jul 2019 08:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: <20190515124006.25840-17-christophe.lyon@st.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2019-07/txt/msg01285.txt.bz2 On 5/15/19 1:39 PM, Christophe Lyon wrote: > Some tests fail on arm*-*-uclinuxfdpiceabi because it generates PIC > code and they don't support it: skip them. They also fail on > arm*-linux* when forcing -fPIC. > > 2019-XX-XX  Christophe Lyon  > >         gcc/testsuite/ >         * gcc.target/arm/eliminate.c: Accept only nonpic targets. >         * g++.dg/other/anon5.C: Likewise. > Ok. I think it's worth committing this now independently of the others. Thanks, Kyrill > Change-Id: I8efb8d356ce25b020c44a84b07f79a996dca0358 > > diff --git a/gcc/testsuite/g++.dg/other/anon5.C > b/gcc/testsuite/g++.dg/other/anon5.C > index ee4601e..dadd92e 100644 > --- a/gcc/testsuite/g++.dg/other/anon5.C > +++ b/gcc/testsuite/g++.dg/other/anon5.C > @@ -1,5 +1,6 @@ >  // PR c++/34094 >  // { dg-do link { target { ! { *-*-darwin* *-*-hpux* *-*-solaris2.* } > } } } > +// { dg-require-effective-target nonpic } >  // { dg-options "-gdwarf-2" } >  // Ignore additional message on powerpc-ibm-aix >  // { dg-prune-output "obtain more information" } */ > diff --git a/gcc/testsuite/gcc.target/arm/eliminate.c > b/gcc/testsuite/gcc.target/arm/eliminate.c > index f254dd8..299d4df 100644 > --- a/gcc/testsuite/gcc.target/arm/eliminate.c > +++ b/gcc/testsuite/gcc.target/arm/eliminate.c > @@ -1,4 +1,4 @@ > -/* { dg-do compile } */ > +/* { dg-do compile { target { nonpic } } } */ >  /* { dg-options "-O2" }  */ > >  struct X > -- > 2.6.3 >