* Fix aarch64_evpc_tbl guard (PR 85910)
@ 2018-08-23 8:53 Richard Sandiford
2018-08-23 14:44 ` Richard Earnshaw (lists)
0 siblings, 1 reply; 2+ messages in thread
From: Richard Sandiford @ 2018-08-23 8:53 UTC (permalink / raw)
To: gcc-patches; +Cc: richard.earnshaw, james.greenhalgh, marcus.shawcroft
This patch fixes a typo in aarch64_expand_vec_perm_const_1 that I
introduced as part of the SVE changes. I don't know of any cases in
which it has any practical effect, since we'll eventually try to use
TBL as a variable permute instead. Having the code is still an
important part of defining the interface properly and so we shouldn't
simply drop it.
Tested on aarch64-linux-gnu (with and without SVE) and aarch64_be-elf.
Applied as obvious to trunk, but OK to backport to GCC 8?
Richard
2018-08-23 Richard Sandiford <richard.sandiford@arm.com>
gcc/
PR target/85910
* config/aarch64/aarch64.c (aarch64_expand_vec_perm_const_1): Fix
aarch64_evpc_tbl guard.
------------------------------------------------------------------------------
Index: gcc/config/aarch64/aarch64.c
===================================================================
--- gcc/config/aarch64/aarch64.c 2018-08-23 09:47:55.000000000 +0100
+++ gcc/config/aarch64/aarch64.c 2018-08-23 09:48:51.379223625 +0100
@@ -15461,7 +15461,7 @@ aarch64_expand_vec_perm_const_1 (struct
return true;
if (d->vec_flags == VEC_SVE_DATA)
return aarch64_evpc_sve_tbl (d);
- else if (d->vec_flags == VEC_SVE_DATA)
+ else if (d->vec_flags == VEC_ADVSIMD)
return aarch64_evpc_tbl (d);
}
return false;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fix aarch64_evpc_tbl guard (PR 85910)
2018-08-23 8:53 Fix aarch64_evpc_tbl guard (PR 85910) Richard Sandiford
@ 2018-08-23 14:44 ` Richard Earnshaw (lists)
0 siblings, 0 replies; 2+ messages in thread
From: Richard Earnshaw (lists) @ 2018-08-23 14:44 UTC (permalink / raw)
To: gcc-patches, james.greenhalgh, marcus.shawcroft, richard.sandiford
On 23/08/18 09:52, Richard Sandiford wrote:
> This patch fixes a typo in aarch64_expand_vec_perm_const_1 that I
> introduced as part of the SVE changes. I don't know of any cases in
> which it has any practical effect, since we'll eventually try to use
> TBL as a variable permute instead. Having the code is still an
> important part of defining the interface properly and so we shouldn't
> simply drop it.
>
> Tested on aarch64-linux-gnu (with and without SVE) and aarch64_be-elf.
> Applied as obvious to trunk, but OK to backport to GCC 8?
>
Yes.
R.
> Richard
>
>
> 2018-08-23 Richard Sandiford <richard.sandiford@arm.com>
>
> gcc/
> PR target/85910
> * config/aarch64/aarch64.c (aarch64_expand_vec_perm_const_1): Fix
> aarch64_evpc_tbl guard.
> ------------------------------------------------------------------------------
>
> Index: gcc/config/aarch64/aarch64.c
> ===================================================================
> --- gcc/config/aarch64/aarch64.c 2018-08-23 09:47:55.000000000 +0100
> +++ gcc/config/aarch64/aarch64.c 2018-08-23 09:48:51.379223625 +0100
> @@ -15461,7 +15461,7 @@ aarch64_expand_vec_perm_const_1 (struct
> return true;
> if (d->vec_flags == VEC_SVE_DATA)
> return aarch64_evpc_sve_tbl (d);
> - else if (d->vec_flags == VEC_SVE_DATA)
> + else if (d->vec_flags == VEC_ADVSIMD)
> return aarch64_evpc_tbl (d);
> }
> return false;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-23 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-23 8:53 Fix aarch64_evpc_tbl guard (PR 85910) Richard Sandiford
2018-08-23 14:44 ` Richard Earnshaw (lists)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).