From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id CA7A93953832 for ; Wed, 16 Nov 2022 03:33:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CA7A93953832 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52b.google.com with SMTP id 136so15495412pga.1 for ; Tue, 15 Nov 2022 19:33:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rzQ1bpeG0tT/Ug54rovtWcXkH8kB5IPzftp0AYhXD5w=; b=dW3wwHBoZoipZ9x7lYMbr3NA2ZOE+w7yjdYhvYq3APH3m4wVMqPzsj0WfLeP/HuigC vSxH+j/s6+vPvpsA8qTyrqhPcr9Dd7IhK2pRM0GWgcpYvW9yEo3z6YOHXfHNNbf0sxsJ Zsys5piurpvYZxooTKi4PtI8jNk8voX+flLoJ7S0NsqPl0OCIWLvS2tlTsrdQt+s6rSY XuZfRAdcutx7wJjPQpAFEyGdkIMlceEwEDWJ3CmkRB1IoCLuRkXy5D3b74cAamDCf8T/ wYBIQBkHomafezNXfNCyliAUivAs0LWO96L+bvfgNRe1SvssmNOwcfFiO+Dglhh/WMA/ zENA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rzQ1bpeG0tT/Ug54rovtWcXkH8kB5IPzftp0AYhXD5w=; b=mgLe+VGbN+2/l7/fceYTtCSIeVsfmR1IlsQabRpK4Im7uCvWhyUZZpVKNWKiFXtObm pb9sz0bQvGzKFUD2OZe5gxkWg43EHygxgXzU3yszszv3/lK5yMDt1EpRW6oPFj5hqTj3 vAgfVkWtwhuf63pdE18DagKaeYUOa4GChpwB+9uSU8fd5x3Xur0QKZGz7+h97d04DYoZ HdkHUFXZX4ZLpwIG/fIXaFniqrYDDV5WOPxDO++B360oacTY9CUcf5E2zk0vueOAFR1b 0v9xqylYggyEdnyQ2imTkTiF9HLzYSxeWeJGnJgmLWSTIa5mnOsWGlYa430qZA50LS7K h4Lg== X-Gm-Message-State: ANoB5pmO3I3I5sbgZ89S5QaZwCi/HrE65zjMXq41FXbt2SxIzDqkFxNc JLGh/XpBQAVxzj1WT77xOvxMTBSUADk= X-Google-Smtp-Source: AA0mqf6a4shoxeNl+3/oTqgvj8LBu2NNDYH0YyBHX0WkA43xHJBGkBJdOyYmKjy521if+8LcrFm3wg== X-Received: by 2002:a05:6a00:1c96:b0:562:e0fb:3c79 with SMTP id y22-20020a056a001c9600b00562e0fb3c79mr21343990pfw.39.1668569597659; Tue, 15 Nov 2022 19:33:17 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id b12-20020a170903228c00b001889e58d520sm10808172plh.184.2022.11.15.19.33.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 19:33:16 -0800 (PST) Message-ID: <7c27f8ea-38c2-a946-d281-4a35e03e8e83@gmail.com> Date: Tue, 15 Nov 2022 20:33:13 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] gcc: m68k: fix PR target/107645 Content-Language: en-US To: Max Filippov Cc: gcc-patches@gcc.gnu.org, Andreas Schwab References: <20221111194356.3922768-1-jcmvbkbc@gmail.com> <80a301f3-6b42-cbad-77b9-cc219eed54ce@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_NUMSUBJECT,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/12/22 20:47, Max Filippov wrote: > On Sat, Nov 12, 2022 at 11:42 AM Jeff Law wrote: >> ISTM that we'd need to strip the unspec and process its argument >> instead. > I tried that first, the result was more ICEs because that pattern > wasn't recognized at later stages. Then I read the change to the > comment over the symbolic_operand predicate: > https://gcc.gnu.org/git/?p=gcc.git;a=blobdiff;f=gcc/config/m68k/predicates.md;h=6ca261fb92a2b7ecd53a0356d06410e2c0d70965;hp=417989f6d6c408fa82af9f9649a204b9a754d1dc;hb=75df395f15f2;hpb=676fd528c9990a4f1046b51d40059893c3a71490 > and that made me think that the intention was to not recognize > the unspecs in that predicate. Thanks for clarifying.  ISTM that operand predicate is quite poorly named. OK for the trunk. jeff