From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id DEB6B385B537 for ; Thu, 5 Oct 2023 15:04:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DEB6B385B537 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-io1-xd33.google.com with SMTP id ca18e2360f4ac-79fe6da0095so44464539f.0 for ; Thu, 05 Oct 2023 08:04:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696518297; x=1697123097; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lque/SERLjqgYbqR4DBkRhynuQOWd2vQ5tMsqyxeEQg=; b=BI7707H4/R6ZQD1eOJ6Bw9wBs1wcL9lr85pH9f1dFZuVNi1+Phg2o9MhvZOLGQ96U8 2NY7W+4QlM+9UmiI6kjjztubyPFVclvZ4TAEjq9pAgCrGZbE3xZDDabUcq7aInc03u7s dYAxReuvX3lYit4WMC4yVlwT/dH5s28i8toUL1mZ+dRTqpeKL+nyLqJbp2QQtlBh6Ndd 8knry9ZkdxKrXbpctk2ILF/lBzHrQ/ht0dsbd48HS0mx+75Zvd0E/FEcK6dZskjnwpm6 GebhjEdiEfPQn55Cw59g3qprDOooRrCeE6ZbLznSOQe8Z8gTXKPPE+VkzIO3O5bj159L 7sAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696518297; x=1697123097; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lque/SERLjqgYbqR4DBkRhynuQOWd2vQ5tMsqyxeEQg=; b=UQveX3uAV7gsn2cp14VfyCYc14iljhni0wKSS90cLrBGzBF8eEF5OBMLlwf6JMWz6D rlcr/m54aMUPxJXYdTRKDVko5pBXpgBB5nOWthKLeyn2D6u0jO5I/FXRz00b35mYlblm 7LN2q7mwtG5sITkYbgjKe043xMFt726ue6CvfjUp7OBdyZ5aMownBaS14K/NV0OKdSbb m6vf2Rims3kIFokllfSHF+Ko7A+er/O9DqaOlZlmM0lwSMJ7jhxxUvsQ2TxzP4qwY5SM ijR0ZO6Uf6CpsnCYkTk+kKi1wCQzCcMg8zgJ3cm859yGH7sQpUHlD5nczamkGGh5kiYB nR+Q== X-Gm-Message-State: AOJu0YyWmhU56DvTNFIzRITSO3gg03PNtK8nSmeDYZedxrC7UnvJg42V D39jlidBRQmRlpQYMyvvCHw= X-Google-Smtp-Source: AGHT+IESg1ws+mcbrMa6mX7G5xPCEEx498FCCS4xDPGpAf8iE4vNrQ+Xvulz0/99RX5bMv0qo6q+Hg== X-Received: by 2002:a6b:5b16:0:b0:79f:d04d:ce59 with SMTP id v22-20020a6b5b16000000b0079fd04dce59mr6433352ioh.6.1696518296927; Thu, 05 Oct 2023 08:04:56 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id s11-20020a02ad0b000000b0042b3dcb1106sm483339jan.47.2023.10.05.08.04.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Oct 2023 08:04:56 -0700 (PDT) Message-ID: <7c3138ba-7792-44b3-a9ae-d6e054712baa@gmail.com> Date: Thu, 5 Oct 2023 09:04:55 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC] expr: don't clear SUBREG_PROMOTED_VAR_P flag for a promoted subreg [target/111466] Content-Language: en-US To: Richard Kenner Cc: gcc-patches@gcc.gnu.org, gnu-toolchain@rivosinc.com, jakub@redhat.com, jivanhakobyan9@gmail.com, kito.cheng@gmail.com, palmer@rivosinc.com, rdapp.gcc@gmail.com, roger@nextmovesoftware.com, vineetg@rivosinc.com References: <20230928214341.257862-1-vineetg@rivosinc.com> <2aab5d77-b9a5-490b-99db-693f88481809@gmail.com> <20231005145605.18E8533CEF@vlsi2.gnat.com> From: Jeff Law In-Reply-To: <20231005145605.18E8533CEF@vlsi2.gnat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/5/23 08:56, Richard Kenner wrote: >> At that particular time I think Kenner was mostly focused on the alpha >> and ppc ports, but I think he was also still poking around with romp and >> a29k. I think romp is an unlikely target for this because it didn't >> promote modes and it wasn't even building for several months >> (April->late July). > > Obviously, I have no recollection of that change at all. That's the assumption I made :-) > > In July of 1994, I don't believe I was actively working on much in the > way of ports, though I could be misremembering. My guess is that this > change was to fix some bug, but I'm a bit mystified why I'd have > batched so many different changes together in one ChangeLog entry like > that. I think you're correct that it was most likely the Alpha that > showed the bug. The alpha was a combination of my memory and reviewing patches/email messages in that time span. I agree this was almost certainly meant to be a bugfix and I suspect the bug was expanding directly into a promoted subreg target and ending up with inconsistency between the value and the promoted subreg state bits. Jeff