From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 1D5E3385840A for ; Mon, 24 Oct 2022 07:47:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1D5E3385840A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.95,207,1661846400"; d="scan'208";a="85390900" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa2.mentor.iphmx.com with ESMTP; 23 Oct 2022 23:47:36 -0800 IronPort-SDR: TYcsPoFCiZODOLXrUbQVszRP8htvOC1GqU4JKGXsAcYIXGP9/paWwEBcH4BV7/nWzX0XkS4mRN T/3MglDXOI391M03Pk6yqA6L0hdKFsUG5GFOUsd6/5qI/26X7TMkr9r1+kKTCaCOMRClXmmzA6 tXGNboJbcqO2zdQF0UzfiHodmpGKWIR3gI4VNoQGnMnlRu8aat+2KW7Uxqd996ffDPXC2vVShx WmFemdN/WopTJThb5yGfbUxGvHR/nQQiNy7NGK9eKQ0K/V/Q1tH4mKUVBwZ8U1YAiCKUO1tLvX wws= Message-ID: <7cc0ce4b-90b0-8182-d7e8-5c21e61fc72c@codesourcery.com> Date: Mon, 24 Oct 2022 09:47:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: *ping* Re: [Patch] OpenMP: Fix reverse offload GOMP_TARGET_REV IFN corner cases [PR107236] Content-Language: en-US From: Tobias Burnus To: gcc-patches , Jakub Jelinek References: <9e2d0331-92c4-c8a6-a662-61f298fb3976@codesourcery.com> In-Reply-To: <9e2d0331-92c4-c8a6-a662-61f298fb3976@codesourcery.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: SVR-IES-MBX-07.mgc.mentorg.com (139.181.222.7) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_SHORT,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping this patch =E2=80=93 and also "Re: [Patch][v5] libgomp/nvptx: Prepare = for reverse-offload callback handling". For the latter cf. Alexander's code approval https://gcc.gnu.org/pipermail/gcc-patches/2022-October/603908.html =E2=80= =93 and his concerns regarding the generic feature in https://gcc.gnu.org/pipermail/gcc-patches/2022-September/601959.html (I think 'target nowait' permits what he thinks is the better way for GPUs.) Tobias On 18.10.22 21:27, Tobias Burnus wrote: > Found when playing around with reverse offload once I used 'omp target > parallel'. > The other issue showed up when running the testsuite (which is done > with -O2). > > In all cases, the ICE is in expand_GOMP_TARGET_REV of this IFN, which > should > be unreachable > > Note: ENABLE_OFFLOADING inside the compiler must evaluate to true to > show up > as ICE - otherwise, the IFN is not even generated. > > I did not see a good reason for DECL_CONTEXT =3D NULL, thus, I now set > it to > the same as was set for child_fn - for no good reason. > > Tested on x86-64 with ENABLE_OFFLOADING albeit without true offloading. > OK for mainline? > > Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955