From: John David Anglin <dave.anglin@bell.net>
To: Andreas Schwab <schwab@suse.de>
Cc: Jeff Law <law@redhat.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority
Date: Mon, 17 Sep 2018 14:07:00 -0000 [thread overview]
Message-ID: <7d314cf8-d89f-8423-437f-247a13906a07@bell.net> (raw)
In-Reply-To: <mvm1s9sze2u.fsf@suse.de>
On 2018-09-17 5:08 AM, Andreas Schwab wrote:
> PR rtl-optimization/85458
> * sel-sched.c (sel_target_adjust_priority): Remove wrong
> assertion.
>
> diff --git a/gcc/sel-sched.c b/gcc/sel-sched.c
> index 824f1ec340..1be977d70b 100644
> --- a/gcc/sel-sched.c
> +++ b/gcc/sel-sched.c
> @@ -3330,8 +3330,6 @@ sel_target_adjust_priority (expr_t expr)
> else
> new_priority = priority;
>
> - gcc_assert (new_priority >= 0);
> -
> /* If the priority has changed, adjust EXPR_PRIORITY_ADJ accordingly. */
> EXPR_PRIORITY_ADJ (expr) = new_priority - EXPR_PRIORITY (expr);
>
I added the assert because the hppa implementation of
TARGET_SCHED_ADJUST_PRIORITY assumes
scheduling priorities are non negative. If that is not the case, I tend
to think this should be documented.
It seems ia64 is the only target tripping on the assert.
Dave
--
John David Anglin dave.anglin@bell.net
next prev parent reply other threads:[~2018-09-17 14:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 14:32 John David Anglin
2018-09-06 17:05 ` Jeff Law
2018-09-10 12:35 ` Andreas Schwab
2018-09-10 14:10 ` John David Anglin
2018-09-17 9:13 ` Andreas Schwab
2018-09-17 14:07 ` John David Anglin [this message]
2018-09-17 14:25 ` Andreas Schwab
2018-09-17 19:34 ` Jeff Law
2018-09-18 8:00 ` Andreas Schwab
2018-09-18 13:51 ` Jeff Law
2018-09-20 1:51 ` [PATCH] hppa: Remove TARGET_SCHED_ADJUST_PRIORITY hook John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7d314cf8-d89f-8423-437f-247a13906a07@bell.net \
--to=dave.anglin@bell.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).