From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84103 invoked by alias); 17 Sep 2018 14:06:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 83592 invoked by uid 89); 17 Sep 2018 14:06:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-27.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 spammy=Hx-languages-length:946, HContent-Transfer-Encoding:8bit X-HELO: torfep02.bell.net Received: from simcoe208srvr.owm.bell.net (HELO torfep02.bell.net) (184.150.200.208) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 17 Sep 2018 14:06:18 +0000 Received: from bell.net torfep02 184.150.200.158 by torfep02.bell.net with ESMTP id <20180917140616.UJQX19392.torfep02.bell.net@torspm01.bell.net> for ; Mon, 17 Sep 2018 10:06:16 -0400 Received: from [192.168.0.138] (really [70.29.37.31]) by torspm01.bell.net with ESMTP id <20180917140616.ZJPM26298.torspm01.bell.net@[192.168.0.138]>; Mon, 17 Sep 2018 10:06:16 -0400 Subject: Re: [PATCH]: Allow TARGET_SCHED_ADJUST_PRIORITY hook to reduce priority To: Andreas Schwab Cc: Jeff Law , GCC Patches References: <0339d94b-e63b-d4b5-ee11-04133ad2b418@bell.net> <175a9d44-219f-12c5-e669-60674e82ab2d@redhat.com> <5d6d3ad1-41f5-2a73-ffbf-cb883ab1ffbc@bell.net> From: John David Anglin Message-ID: <7d314cf8-d89f-8423-437f-247a13906a07@bell.net> Date: Mon, 17 Sep 2018 14:07:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-SW-Source: 2018-09/txt/msg00874.txt.bz2 On 2018-09-17 5:08 AM, Andreas Schwab wrote: > PR rtl-optimization/85458 > * sel-sched.c (sel_target_adjust_priority): Remove wrong > assertion. > > diff --git a/gcc/sel-sched.c b/gcc/sel-sched.c > index 824f1ec340..1be977d70b 100644 > --- a/gcc/sel-sched.c > +++ b/gcc/sel-sched.c > @@ -3330,8 +3330,6 @@ sel_target_adjust_priority (expr_t expr) > else > new_priority = priority; > > - gcc_assert (new_priority >= 0); > - > /* If the priority has changed, adjust EXPR_PRIORITY_ADJ accordingly. */ > EXPR_PRIORITY_ADJ (expr) = new_priority - EXPR_PRIORITY (expr); > I added the assert because the hppa implementation of TARGET_SCHED_ADJUST_PRIORITY assumes scheduling priorities are non negative.  If that is not the case, I tend to think this should be documented. It seems ia64 is the only target tripping on the assert. Dave -- John David Anglin dave.anglin@bell.net