From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 33871 invoked by alias); 28 Sep 2016 15:20:22 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 33858 invoked by uid 89); 28 Sep 2016 15:20:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:779 X-HELO: mail-qk0-f180.google.com Received: from mail-qk0-f180.google.com (HELO mail-qk0-f180.google.com) (209.85.220.180) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Sep 2016 15:20:20 +0000 Received: by mail-qk0-f180.google.com with SMTP id j129so42359459qkd.1 for ; Wed, 28 Sep 2016 08:20:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:to:from:subject:message-id:date :user-agent:mime-version:content-transfer-encoding; bh=4mT5q1+mXNLESyCF7EJvloAGOfYXdOipDfyAiPqOgsY=; b=aBem2ZeRc+BEvsFolmKACwz/eppGuVjZSKfy7zZDNTGk5XS327DsR7oEMNdoi2lVNP 8Yk9V/l4yD3ObiHyp8dGX+7vdPYg9ZwmyvJdn7JOUlAiib2ghnvE/La7p3d38hh+A5gA S2PcQ8sxI4AeQZag1gU+fqL/YtI85TYR7zl/0/OwzAFY10RINXy0aCmjkPgc68Hi+d2J zJf6UFh1wBiwy8x3n8+Ls83XqwOVminEsN/nkQSwzuTm97TMFCP9JzXZgdD/zNpydsdD aEP3H+81Fi9w6gUysnKWp9NrQK8CM4Ll+WQhnv1eJRYou+VCyUqtZuiJz08FUeSyNsok ALfA== X-Gm-Message-State: AA6/9Rm/DppLV8W3kGRm7BFfl3ZDY/K5vTQeA23E85kSzFKM/CM3qvBDWeb5uhtAlbdpsA== X-Received: by 10.55.203.152 with SMTP id u24mr2929782qkl.196.1475076018734; Wed, 28 Sep 2016 08:20:18 -0700 (PDT) Received: from ?IPv6:2601:181:c003:1930:3fe6:c217:b86a:6e86? ([2601:181:c003:1930:3fe6:c217:b86a:6e86]) by smtp.googlemail.com with ESMTPSA id h25sm4087623qtc.38.2016.09.28.08.20.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Sep 2016 08:20:17 -0700 (PDT) To: GCC Patches From: Nathan Sidwell Subject: [gomp4] more tile parsing Message-ID: <7d421600-1a8c-4944-4f93-53846999bcc0@acm.org> Date: Wed, 28 Sep 2016 15:29:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg02140.txt.bz2 In my recent patch for tile clauses, I noticed some tile tests didn't appear to fail, even though the loops they tiled were ill formed. I figured I'd find out why in the fullness of time. Didn't take long for time to be full. The omp_for parsing routines had no knowledge of tile, so did not checking. This patch rectifies that. I did notice a couple of nits in the c++ parser, also fixed here 1) we'd complain about a missing inner loop twice, which is a bit repetative. Fixed by only emitting the missing for token error, if we didn't already emit an error. 2) 'do ... while (1)' is an odd way to write a non-terminating loop. Changed to 'for (;;) ...' I guess the loop condition was originally something other than '1'. applied to gomp4 nathan