From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by sourceware.org (Postfix) with ESMTPS id 47C373858D37 for ; Fri, 21 Apr 2023 07:44:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47C373858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-94a342f15e4so176974766b.0 for ; Fri, 21 Apr 2023 00:44:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682063074; x=1684655074; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=S3Hr6LPYV3UefeidlAhTjrolchdFnDKiyKoeApTkcD4=; b=fE3+7p0HUjL3UCqgicmGyUuzeSDzNVhN0dd0l468k196272kezBAxXshXEOzU87k/x 5ls/KkVV/tBsBnEKeYHhUpcsQN9vZ+r7VTmEbMVOmcz5MGQ84RCEh10SqtFgsXtWpOSA lB+/7qhWlA2LeS99MU5R2R90jhuOo/TRv/FV3WrrGmIhqi8yy/1H75k/uiMYVWmdroMB Ef/v+cINaneeymZ8l2MiVviHFAEkmjYiVjgayZjryOjXcgY80Mz13euPYSB8edzhxqcs PsBIt3ciZftyFeXdR4CLhl9aFvwiI/s9WEx7RpazHTpnHKJLqSjYs9K7XB86CaJCM33z znNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682063074; x=1684655074; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S3Hr6LPYV3UefeidlAhTjrolchdFnDKiyKoeApTkcD4=; b=Nxh0dRdxjmrAn74lViKS36LJOBKXVh3F1wHMo11QeVWYIUKbXZQZJXqlv0n8h2YeKR SdiRaPSjO7sMOFdPeUgDLjZwGDewdLpUq6nsteBQWgdNdDZm4G8BBPo45tSFJ9LAmtr2 DhMCu+wzhyuNrnWSVT2f32PRxjp8mXeiXHJ9HJeh0jlJToyR9I/kdW7yGxMhWt7hFYkN VhKmDXgoR7YE2r+tOuXEFqeNKXbjfpu0jFzx1hUvAqYZVWMSifeggvwJcSOBZgIvAWxv lYO/YFPIzMhh9q0VkrnZzTUoEuv8EC7MaBhdD0zPeiqLdHmydbSQ21iH8ReNnKOMRVaV 3QKA== X-Gm-Message-State: AAQBX9fMJeZbEidZc8sl6aobGJPW0L1jpn5KysYaxcSHQHasxZZWrdsx ZnpPjdo1Bz2m0u9eOHXbBeTbmS7SjqU= X-Google-Smtp-Source: AKy350Y+HzB5sqxpgNe020ohHT7MUTEZtP0cmwhAO0w5NkAmJKqHemSFwu42fKrqVV5NfsBNow6w5A== X-Received: by 2002:a17:906:17d6:b0:94f:3728:7047 with SMTP id u22-20020a17090617d600b0094f37287047mr1416842eje.6.1682063073594; Fri, 21 Apr 2023 00:44:33 -0700 (PDT) Received: from [192.168.1.23] (ip-046-005-130-086.um12.pools.vodafone-ip.de. [46.5.130.86]) by smtp.gmail.com with ESMTPSA id m9-20020a1709061ec900b009571df15cd1sm471526ejj.13.2023.04.21.00.44.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Apr 2023 00:44:33 -0700 (PDT) Message-ID: <7d4cc0d3-9ffb-6371-9658-0f93be64276d@gmail.com> Date: Fri, 21 Apr 2023 09:44:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [RFA] [PR target/108248] [RISC-V] Break down some bitmanip insn types Content-Language: en-US To: Andreas Schwab , Jeff Law Cc: "gcc-patches@gcc.gnu.org" References: <3ee750e7-d3f5-12cc-4885-bbe2f6290861@ventanamicro.com> <874jp91yc9.fsf@igel.home> From: Robin Dapp In-Reply-To: <874jp91yc9.fsf@igel.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > ../../gcc/config/riscv/generic.md:28:1: unknown value `smin' for attribute `type' > make[3]: *** [Makefile:2528: s-attrtab] Error 1 > >From 582c428258ce17ffac8ef1b96b4072f3d510480f Mon Sep 17 00:00:00 2001 From: Robin Dapp Date: Fri, 21 Apr 2023 09:38:06 +0200 Subject: [PATCH] riscv: Fix fallout. The adjusted generic.md uses standard names instead of the types defined in the iterator (that match instruction names). Change this. gcc/ChangeLog: * config/riscv/generic.md: Change standard names to insn names. --- gcc/config/riscv/generic.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/riscv/generic.md b/gcc/config/riscv/generic.md index db4fabbbd92..2c3376628c3 100644 --- a/gcc/config/riscv/generic.md +++ b/gcc/config/riscv/generic.md @@ -27,7 +27,7 @@ (define_cpu_unit "fdivsqrt" "pipe0") (define_insn_reservation "generic_alu" 1 (and (eq_attr "tune" "generic") - (eq_attr "type" "unknown,const,arith,shift,slt,multi,auipc,nop,logical,move,bitmanip,smin,smax,umin,umax,clz,ctz,cpop")) + (eq_attr "type" "unknown,const,arith,shift,slt,multi,auipc,nop,logical,move,bitmanip,min,max,minu,maxu,clz,ctz,cpop")) "alu") (define_insn_reservation "generic_load" 3 -- 2.40.0