From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by sourceware.org (Postfix) with ESMTPS id 1C62A3858D32 for ; Thu, 4 Jan 2024 21:39:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1C62A3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1C62A3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d32 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704404368; cv=none; b=WrxYd/6x4nTZPYQyD7NFgs7flHKOhdb8/C3q+ZEsZvYPH/LnHJ7OC9XZqHQMwha8CV3l9a02onp6h9QQ478+C5573Ja8nE2XFEbEquYaF/pBc7PZl734doJlr1oXKs5VlGp8Eo6tZst226qVHRz4b8KJZVYGe8uvkNutY1EBeBU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1704404368; c=relaxed/simple; bh=62MrEAxFgRZ8O3QvQ15HaY6GBKjUB6rNl2HMkuZ/13k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NeqPAaLzvgQoOHiX2P77Ja397NGPYhWp34Oa3lOIQD0y4D2TeUxqmnt+hau7nLASqF5R2ll2PjZUDAVN87Wt/mlSVdasqu7HkvuIibFASyf//qLtdjzIz67uts07FIy5SYbJygReEyUv/4ygCyOFyE/xNUxTdEqLqrvQUAL6yNo= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd32.google.com with SMTP id ca18e2360f4ac-7ba87489f97so41144639f.1 for ; Thu, 04 Jan 2024 13:39:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704404366; x=1705009166; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OKmdLQi44n9oqcN2s97zju9HES6O3DL7ZqfpcDreLG8=; b=ExasQU86PD++h1BVTq/MkL+ybzZj1OUcEuKf08QppAWP0xrCZyOH1nHMdiX4cZW7/6 N9DqSioYFjvsZ4iVpsYv8ac4ghCH+76tbIOqVyHhC04eWYRMOvG6ma3tDnnFCDgCjJdB HuqUYLklt6Mf2vFCMqrKAJ0QlK3Kd3w9u6XLHFZegCmWLVUVhYIXWbucC7slbP1NAbAA RiOsmi6mV+8xtT21L6JTzSHg7oYSsxMp1DE6tNXPgAqpVXdA+wdfreNtomBE31BGWSAN 4WtrFcWNKRdRcrnEnpEahEhh8T3cEf7nOtEG+iudToGmNsEvShN3h9m3Bi/wcZEUZ6zs uegw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704404366; x=1705009166; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OKmdLQi44n9oqcN2s97zju9HES6O3DL7ZqfpcDreLG8=; b=KKDtSQxueLc0rzLHIxkpI7An57Bx2Q3KX4nw9nVxyIqDzWSnzZDeFZHGkomGPkrQyt uz9SiTZ6yVbdHoC+bDvdv0+bl5hYTf+UKvRRNkwfCVvp1oBPXh64j4l/96raRRGYkqPk 5n4oVN0bWzdwT3OmU0LfVy3A7xYLN2KkeXrVQT+huoFRuSL8LB0ff2XndKaekTJMGewN vgR8utdrJiytcFHV9O01NyX2Eo/c0vWrYmF+MZKWhQxDKRDG3rOptaFz16RbmH5MviJC /1IrUrwx+LK1EynGL6cXH3GQTczbDdXyJViOI5qyvgPFC3M6FAWY1k2cK1SIl+7z22Fw tDqQ== X-Gm-Message-State: AOJu0YwFcfK34aBLP5pklEZTIbEPQ9Qb76kS5++LDYUNA4wNqJIStcFT 1cXkW0lGv2axwXUOipRhnXY= X-Google-Smtp-Source: AGHT+IEO5jcOowrsT4PAyJhet9d7TCU4kupRDuAz4MWcR8lHm1h5dGnUZdF163SQAO/d+N/YGk9EZg== X-Received: by 2002:a05:6602:4f82:b0:7bb:4af3:2857 with SMTP id gr2-20020a0566024f8200b007bb4af32857mr1293102iob.18.1704404366183; Thu, 04 Jan 2024 13:39:26 -0800 (PST) Received: from [172.31.0.109] ([136.36.72.243]) by smtp.gmail.com with ESMTPSA id cv4-20020a056638498400b0043978165d54sm43391jab.104.2024.01.04.13.39.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 13:39:25 -0800 (PST) Message-ID: <7de190a0-5562-402d-9958-242c41129ad9@gmail.com> Date: Thu, 4 Jan 2024 14:39:23 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Avoid ICE with m68k-elf -malign-int and libcalls Content-Language: en-US To: Mikael Pettersson , gcc-patches@gcc.gnu.org References: <20240104092425.1844-2-mikpelinux@gmail.com> From: Jeff Law In-Reply-To: <20240104092425.1844-2-mikpelinux@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/4/24 02:23, Mikael Pettersson wrote: > emit_library_call_value_1 calls emit_push_insn with NULL_TREE > for TYPE. Sometimes emit_push_insn needs to assign a temp with > that TYPE, which causes a segfault. > > Fixed by computing the TYPE from MODE when needed. > > Original patch by Thorsten Otto. > > gcc/ > > 2024-01-03 Thorsten Otto > Mikael Pettersson > > PR target/82420 > PR target/111279 > * expr.cc (emit_push_insn): If TYPE is NULL compute it > from MODE before calling assign_temp. > > gcc/teststuite/ > > 2024-01-03 Mikael Pettersson > > PR target/82420 > * gcc.target/m68k/pr82420.c: New test. This really needs to happen in the two call paths which pass in NULL_TREE for the type. Note how the type is used to determine padding earlier in emit_push_insn. That would also make the code more consistent with the comment before emit_push_insn which implies that both MODE and TYPE are valid. Additionally you should bootstrap and regression test this patch on at least one target. jeff