From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa4.mentor.iphmx.com (esa4.mentor.iphmx.com [68.232.137.252]) by sourceware.org (Postfix) with ESMTPS id 803AE3858D1E; Fri, 30 Sep 2022 10:57:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 803AE3858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="5.93,358,1654588800"; d="scan'208,217";a="83903262" Received: from orw-gwy-01-in.mentorg.com ([192.94.38.165]) by esa4.mentor.iphmx.com with ESMTP; 30 Sep 2022 02:57:50 -0800 IronPort-SDR: L5kzOl6LfMZ1kGbd+L6VJIgPNibAkrKr4DwFfkl9zH3Gn4Kd8LNWlM9cy33TL8KtjaO0wEcvcG gXdsCAruWjXt95ek5us9SilfQP5jmEgAm7YbMuMqG61kSpkzyAS5VWtqzAsWbczPO+LnIJ9njS IhEkRJ5K4qYP88g67UOFmDWy/7XxyxUcr6Vu0qXuP0HNmbtTrxRmkyZJooXx0+6RV+dk/pboII CTgWytyG94GDRx96LcZJfn0r2LRpJ2C4PcK+gzq+gj4DACW9lvgxNlSMVJy44Ksd2K1lDuuBLO +tQ= Content-Type: multipart/alternative; boundary="------------77K9n05B7qaIdIfLx2mFPmNr" Message-ID: <7dfef7ea-88db-07d3-3ffd-34c8f9dc7eea@codesourcery.com> Date: Fri, 30 Sep 2022 12:57:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [Patch] Fortran: Update use_device_ptr for OpenMP 5.1 [PR105318] Content-Language: en-US From: Tobias Burnus To: gcc-patches , fortran , Jakub Jelinek References: <6005cea4-c89e-0c31-1c61-d322dcf072e7@codesourcery.com> In-Reply-To: <6005cea4-c89e-0c31-1c61-d322dcf072e7@codesourcery.com> X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-09.mgc.mentorg.com (139.181.222.9) To svr-ies-mbx-12.mgc.mentorg.com (139.181.222.12) X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --------------77K9n05B7qaIdIfLx2mFPmNr Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable On 30.09.22 12:41, Tobias Burnus wrote: Fortran: Update use_device_ptr for OpenMP 5.1 [PR105318] The following two lines slipped in =E2=80=93 which I have now removed in my= version of the patch: --- a/gcc/testsuite/gfortran.dg/gomp/is_device_ptr-1.f90 +++ b/gcc/testsuite/gfortran.dg/gomp/is_device_ptr-1.f90 @@ -1,4 +1,5 @@ ! { dg-do compile } +! First (Leftover - I wanted to refer to PR105318 - but then decided against it.) +++ b/libgomp/testsuite/libgomp.fortran/is_device_ptr-2.f90 @@ -0,0 +1,167 @@ +! { dg-do compile } Likewise leftover - I had an intermittent problem with device testing; henc= e, I disabled it. It turned out to be unrelated, but it remained. Side remark: An issue I found with device testing was that I missed the "xx= =3D> null()"; in principle obvious (as GCC tried to map the pointer target= of the uninitialized pointer), but still easy to miss. Side note: The OpenMP spec (post-5.2) also clarified the mapping of undefin= ed pointers / requiring the two null init here. (The second null() is to avoid issues with firstprivatizing/copy-in of the = internal pointer representation vs. simply using it (host fallback, unified= shared memory). This forces the pointer after the target region to be the = same as before the region (now required by the spec!), permitting either im= plementation without unexpected side effects for the user.) Tobias ----------------- Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstra=C3=9Fe 201= , 80634 M=C3=BCnchen; Gesellschaft mit beschr=C3=A4nkter Haftung; Gesch=C3= =A4ftsf=C3=BChrer: Thomas Heurung, Frank Th=C3=BCrauf; Sitz der Gesellschaf= t: M=C3=BCnchen; Registergericht M=C3=BCnchen, HRB 106955 --------------77K9n05B7qaIdIfLx2mFPmNr--