From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by sourceware.org (Postfix) with ESMTP id 75C273937425 for ; Thu, 12 Mar 2020 03:41:54 +0000 (GMT) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-143-06B111AWOVOqYHsL-yburw-1; Wed, 11 Mar 2020 23:41:52 -0400 X-MC-Unique: 06B111AWOVOqYHsL-yburw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D0363800D4E; Thu, 12 Mar 2020 03:41:49 +0000 (UTC) Received: from ovpn-116-132.phx2.redhat.com (ovpn-116-132.phx2.redhat.com [10.3.116.132]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7289D394; Thu, 12 Mar 2020 03:41:49 +0000 (UTC) Message-ID: <7e032032285d71507a0522632a97abd3bd656f6d.camel@redhat.com> Subject: Re: [PATCH 4/6] i386: Use ix86_output_ssemov for DFmode TYPE_SSEMOV From: Jeff Law Reply-To: law@redhat.com To: "H.J. Lu" , gcc-patches@gcc.gnu.org Cc: Jakub Jelinek , Jan Hubicka , Uros Bizjak Date: Wed, 11 Mar 2020 21:41:48 -0600 In-Reply-To: <20200229141608.88967-5-hjl.tools@gmail.com> References: <20200229141608.88967-1-hjl.tools@gmail.com> <20200229141608.88967-5-hjl.tools@gmail.com> Organization: Red Hat User-Agent: Evolution 3.34.4 (3.34.4-1.fc31) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Mar 2020 03:41:55 -0000 On Sat, 2020-02-29 at 06:16 -0800, H.J. Lu wrote: > There is no need to set mode attribute to XImode nor V8DFmode since > ix86_output_ssemov can properly encode xmm16-xmm31 registers with and > without AVX512VL. > > gcc/ > > PR target/89229 > * config/i386/i386.c (ix86_output_ssemov): Handle MODE_DF. > * config/i386/i386.md (*movdf_internal): Call ix86_output_ssemov > for TYPE_SSEMOV. Remove TARGET_AVX512F, TARGET_PREFER_AVX256, > TARGET_AVX512VL and ext_sse_reg_operand check. And I worry about V1DF for alternatives 14,18 and SSE_SPLIT_REGS as well as alternative 15,19 and !TARGET_SSE2 which has insn_mode of V2SF. jeff >