From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 0F24A3858D1E for ; Mon, 9 Oct 2023 14:17:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F24A3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1c871a095ceso32519525ad.2 for ; Mon, 09 Oct 2023 07:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696861025; x=1697465825; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fr07dgqkshf23VlUWlMgiKI1ObXUgVg1q2dKAn7DHrg=; b=irQ1UmpQIZiUUUj7YhndlO04g8Mvugd8GtR5R15yhqkXV3+4hhAfKWMr5uf6L4YFmD 7G3UuAG6thjdpmIgdY6Gi194t8ssmZnrW2W3zKE1eH8Z61bOSRNvqIu4HBdALwiY57s8 v39QPlw/ugPWcf0ReNM+Boa9EsMJGDpsS+iUkRlFT6w8IbI3kHk3AtYKnQouidwY2giI lNMSPMRvMcm1smU/5sqP1Ds7V3Ymsg4/EMSubLeOzMC+BOY44y16Fs7r0ZD5H8Gnwqcy bBNhXL/kJ1+p7cR/Ls/kIM1+2yiFJRUnlpQxLUPhbWB78Ypc+JGX396n8PBvGrNKkOMf L0DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696861025; x=1697465825; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fr07dgqkshf23VlUWlMgiKI1ObXUgVg1q2dKAn7DHrg=; b=tTDAgfTKNR3OdEqmvAsexMZYQDiokjY7tFEJWTw+u2H2PZQeNAaoGmBT4lpqOSNFki Y+rUMnXBJxJDh4064loBK2EwaL5wkRW7e3AguX375qklIFa0iS/aRA9TWxs8rncmLeZo VF2l4IPR9xb1gVd4zNIEgGJDgX4eXAZ9beq7xBjcUFn1vm0K1a1Sy2qN4PT0bGR+6qOB k118S0pe9xBgTMxjsv0OX50ivqJTSIqtxxvqSlWtr6ncnMimws7TX0wVmzdHVoBaFO4i SLjYyfL/ZiEmBR7BKA9oSo3KpOMFglY0pnWSHGSTlmc/pbpLiGZx26mlpavfGGCe8gWj rw0w== X-Gm-Message-State: AOJu0YyLsd/JqG597xh/I2Ls/DNe0j78V43rWTzUoPGVB+31AGrd7s5k Zw5G1KZpyOqSryibPYXj1zM= X-Google-Smtp-Source: AGHT+IEV5pmM2cQBuITLoXLtalWHZbj5VDdW3XFp0g8ULuQijuLs2CNjONF+3HIAVbFhvVyyV50SIA== X-Received: by 2002:a17:90b:ed7:b0:268:7ec:51ae with SMTP id gz23-20020a17090b0ed700b0026807ec51aemr12304921pjb.41.1696861024802; Mon, 09 Oct 2023 07:17:04 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id 30-20020a17090a001e00b002791d5a3e29sm9127242pja.6.2023.10.09.07.17.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Oct 2023 07:17:04 -0700 (PDT) Message-ID: <7e3c0048-4459-40fd-a6ad-64245df6821c@gmail.com> Date: Mon, 9 Oct 2023 08:16:57 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/4] options: Define TARGET__P and TARGET__OPTS_P macro for Mask and InverseMask Content-Language: en-US To: Kito Cheng , gcc-patches@gcc.gnu.org, kito.cheng@gmail.com, palmer@dabbelt.com, rdapp@ventanamicro.com, juzhe.zhong@rivai.ai References: <20231003090934.12182-1-kito.cheng@sifive.com> <20231003090934.12182-2-kito.cheng@sifive.com> From: Jeff Law In-Reply-To: <20231003090934.12182-2-kito.cheng@sifive.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/3/23 03:09, Kito Cheng wrote: > We TARGET__P marcro to test a Mask and InverseMask with user > specified target_variable, however we may want to test with specific > gcc_options variable rather than target_variable. > > Like RISC-V has defined lots of Mask with TargetVariable, which is not > easy to use, because that means we need to known which Mask are associate with > which TargetVariable, so take a gcc_options variable is a better interface > for such use case. > > gcc/ChangeLog: > > * doc/options.texi (Mask): Document TARGET__P and > TARGET__OPTS_P. > (InverseMask): Ditto. > * opth-gen.awk (Mask): Generate TARGET__P and > TARGET__OPTS_P macro. > (InverseMask): Ditto. Doesn't this need to be updated to avoid multi-dimensional arrays in awk and rebased? Jeff