From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 19B153858D1E for ; Sat, 11 Mar 2023 16:59:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 19B153858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1035.google.com with SMTP id mg1so72401pjb.0 for ; Sat, 11 Mar 2023 08:59:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678553971; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=NytbaNxz82U0lvfX3LVXZ0JYoXgPDBCuz2Gj8sgwxiQ=; b=lS71tZzVLtbItAzLFK91coIzd60WH3a6oxo00zE/ENj/RmXC2/dyGS6pKphl+FGMCE CFb0J57mx5RhV21MowB5oDU2mJWGuLNc7zdC5FD76XzWbpw5quANR7jCT2L6Q+2tWLyg IW4KkNcQK9n/LrkLsvCozWHfefUum0OsHQki0FgvFQFpJTRrYL/SJr/QhynwSufLH32v bC6W1jGCR4GbfrwPbs75PYbUWfLJBuTwpX/A7verQeAIBzlv/ozNHei56FhI5ed02gWJ C/e4KFA9y4GD+FKnwOWlMSditkvoUwTjuaS21NqOfWv4SVsWVIW7+82xYQ8XEisk/Z9r mmlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678553971; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=NytbaNxz82U0lvfX3LVXZ0JYoXgPDBCuz2Gj8sgwxiQ=; b=iUtOqvSmV5LCjJ3QKBuqo9NH8gx99TJCDNnm5P3LP7ZVfov/EPZFLO2a5Lq8mrKA+P vNzM5E0YpCh3YwziVeEvMFiV5zvBJoINRBHJ2090Qm/2kGd2CB/PQLcgfv4EDoXqPdy9 kmiIbjPmuBVPm43tlHLv0doj9L3XKQE6UtvWEQbMSeFY5eJP7F4Ol38pgfTE/QrsmXN7 7fnCQW9mLYr/v5ym4WZvGsyweQ4ZX6sdDOSmlw4LvT1pYx3AOTJ9LfKRWl85Ah80P93g oDm6D/UEJbnKGE3o9yogRncov5/zG4xmvXezgotQUcPT7wHrrTMwHVVvdNNHSIeEmOB5 MJCA== X-Gm-Message-State: AO0yUKXt/2OVMxm4VSBZsmWItDT9BZX/2B8k5Qi21oavQ8vwQac7XQGk y9WobgMM80Pvvv21YJKlpgo= X-Google-Smtp-Source: AK7set9L5Ye+WHVN58oGs1shYXZMcTFkicTNUB4j9t5okxL764Nx1rB5bmhYHeNaujGA52BbAKd2gw== X-Received: by 2002:a17:90b:4d04:b0:237:47b0:3ea8 with SMTP id mw4-20020a17090b4d0400b0023747b03ea8mr32550201pjb.41.1678553970902; Sat, 11 Mar 2023 08:59:30 -0800 (PST) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id f1-20020a17090a664100b002353082958csm1760445pjm.10.2023.03.11.08.59.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Mar 2023 08:59:30 -0800 (PST) Message-ID: <7e49f36f-73d6-bf9b-fe83-b36474e09ae2@gmail.com> Date: Sat, 11 Mar 2023 09:59:29 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] PR target/89828 Inernal compiler error on -fno-omit-frame-pointer Content-Language: en-US To: Yoshinori Sato , gcc-patches@gcc.gnu.org References: <20230105130553.3434596-1-ysato@users.sourceforge.jp> From: Jeff Law In-Reply-To: <20230105130553.3434596-1-ysato@users.sourceforge.jp> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/5/23 06:05, Yoshinori Sato wrote: > Subject: > [PATCH] PR target/89828 Inernal compiler error on -fno-omit-frame-pointer > From: > Yoshinori Sato > Date: > 1/5/23, 06:05 > > To: > gcc-patches@gcc.gnu.org > CC: > Yoshinori Sato > > > The problem was caused by an erroneous note about creating a stack frame, > which caused the cur_cfa reg to fail to assert with a value other than > the frame pointer. > > This fix will generate notes that correctly update cur_cfa. > > gcc/config/rx/ > * rx.cc (add_pop_cfi_notes): Release the frame pointer if it is used. > (rx_expand_prologue): Redesigned stack pointer and frame pointer update process. This seems to be taking a step backwards in that it's causing multiple internal errors when compiling newlib. The failures are here: static void dwarf2out_frame_debug_adjust_cfa (rtx pat) { rtx src, dest; gcc_assert (GET_CODE (pat) == SET); dest = XEXP (pat, 0); src = XEXP (pat, 1); switch (GET_CODE (src)) { case PLUS: gcc_assert (cur_cfa->reg == XEXP (src, 0)); cur_cfa->offset -= rtx_to_poly_int64 (XEXP (src, 1)); break; case REG: break; default: gcc_unreachable (); } cur_cfa->reg = dwf_cfa_reg (dest); gcc_assert (cur_cfa->indirect == 0); } In particular it's tripping the gcc_assert in the PLUS case above. Which is a pretty good indicator the contents of the note and the insn's pattern are different WRT the expected registers. jeff