From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id D659B3831E7D; Fri, 9 Dec 2022 12:26:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D659B3831E7D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0098421.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 2B99dnLA013461; Fri, 9 Dec 2022 12:26:04 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : references : date : in-reply-to : message-id : mime-version : content-type : content-transfer-encoding; s=pp1; bh=6QIQd8W78z/fA8eaQ0IgcLtLhVVII7WGTQPWIozcEG8=; b=UTeEsnEaXiQiTP/ChCdoXW6pBUSxTL8WIWFIfkMHbACtI5GPH6CyaHnvwRB8OqUoCZNi SxhNfQGgXnhp+vLR8NplFsOpy3QlbesCyu9kJdSIbJ81FN3Ne7XbAOJXJAJvzk2/sHKJ ps91CzVJ1aVrezwS6pAzDg5zhkVXF5AuXCfqZgKALaNFhIauzxGqHBabW9Z6ZCaYJvG8 ZhqbWjcmXVydmLVFVfcO5emjB9TZYzaLiBxF0fMPwXbn7kTa1hm9/rMi5Kf2sJF6lgRo bqEXv8+mRbnYo4Yjjd3QXFH1OlJDVVwktJmV7JJxvp4+oZsWYEZqvXjgNLwazry0DjKq aA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mbh9cm040-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Dec 2022 12:26:04 +0000 Received: from m0098421.ppops.net (m0098421.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 2B9CJmR4026526; Fri, 9 Dec 2022 12:26:03 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3mbh9cm03m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Dec 2022 12:26:03 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.17.1.19/8.16.1.2) with ESMTP id 2B9ArF8W007885; Fri, 9 Dec 2022 12:26:02 GMT Received: from smtprelay05.wdc07v.mail.ibm.com ([9.208.129.117]) by ppma02dal.us.ibm.com (PPS) with ESMTPS id 3m9nnnx097-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 09 Dec 2022 12:26:02 +0000 Received: from smtpav06.wdc07v.mail.ibm.com (smtpav06.wdc07v.mail.ibm.com [10.39.53.233]) by smtprelay05.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 2B9CQ1J910486334 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 9 Dec 2022 12:26:01 GMT Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 644A15804E; Fri, 9 Dec 2022 12:26:01 +0000 (GMT) Received: from smtpav06.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E5BD758056; Fri, 9 Dec 2022 12:26:00 +0000 (GMT) Received: from pike (unknown [9.5.12.127]) by smtpav06.wdc07v.mail.ibm.com (Postfix) with ESMTPS; Fri, 9 Dec 2022 12:26:00 +0000 (GMT) From: Jiufu Guo To: Jiufu Guo via Gcc-patches Cc: "Kewen.Lin" , segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org Subject: Re: [PATCH 3/3]rs6000: NFC no need copy_rtx in rs6000_emit_set_long_const and rs6000_emit_set_const References: <20221201013619.196004-1-guojiufu@linux.ibm.com> <20221201013619.196004-3-guojiufu@linux.ibm.com> Date: Fri, 09 Dec 2022 20:25:58 +0800 In-Reply-To: (Jiufu Guo via Gcc-patches's message of "Thu, 1 Dec 2022 12:52:29 +0800") Message-ID: <7e4ju4n4q1.fsf@pike.rch.stglabs.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: TJCX1bc-VbaB4IU1yaJd36iqvCyP2xQc X-Proofpoint-GUID: r0Edk1qlhH3pLTyXS1O_RNq8CveDsUo0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1 definitions=2022-12-09_07,2022-12-08_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 clxscore=1015 spamscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2210170000 definitions=main-2212090095 X-Spam-Status: No, score=-5.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Jiufu Guo via Gcc-patches writes: > Hi Kewen, > > =E5=9C=A8 12/1/22 11:31 AM, Kewen.Lin =E5=86=99=E9=81=93: >> Hi Jeff, >>=20 >> on 2022/12/1 09:36, Jiufu Guo wrote: >>> Hi, >>> >>> Function rs6000_emit_set_const/rs6000_emit_set_long_const are only invo= ked from >>> two "define_split"s where the target operand is limited to gpc_reg_oper= and or >>> int_reg_operand, then the operand must be REG_P. >>> And in rs6000_emit_set_const/rs6000_emit_set_long_const, to create temp= rtx, >>> it is using code like "gen_reg_rtx({S|D}Imode)", it must also be REG_P. >>> So, copy_rtx is not needed for temp and dest. >>> >>> This patch removes those "copy_rtx" for rs6000_emit_set_const and >>> rs6000_emit_set_long_const. >>> >>> Bootstrap & regtest pass on ppc64{,le}. >>> Is this ok for trunk?=20 >>=20 >> This patch is okay, thanks! For the subject, IMHO it's better to use so= mething >> like: "rs6000: Remove useless copy_rtx in rs6000_emit_set_{,long}_const". >> I don't see NFC tag used much in GCC, though it's used a lot in llvm, but >> anyway you can append (NFC)/[NFC] at the end if you like. :) >>=20 > > "rs6000: Remove useless copy_rtx in rs6000_emit_set_{,long}_const" is gre= at! > > Thanks for your review and suggestions! Thanks for comments and review! And committed via r13-4583-g71b31d13757ae0. BR, Jeff (Jiufu) > > > BR, > Jeff (Jiufu) > >> BR, >> Kewen