From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 5D5CD3858C60 for ; Mon, 28 Feb 2022 08:36:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5D5CD3858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 12DDE218B8; Mon, 28 Feb 2022 08:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1646037406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mNvyjL25xj7a9o6ZHx5dD/Z5tCjB+Nu9nib3aQbAVxA=; b=EdD/uZv83XNCH8gjuEg4FiMg0iJWZUPrpb1VJ/K3eSfFSK8MG773J0AEVdxcz1QOCGdAPQ 5veOurF2eo1RLNwQZ+Bbx/eAAkBo667ppYsEroKAMY3skV/3c0hRI4T8HNOZX22tyyYWSE S70LWmW/kF/zdaf8ULzXwK7c1OyxMN8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1646037406; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mNvyjL25xj7a9o6ZHx5dD/Z5tCjB+Nu9nib3aQbAVxA=; b=R82wN1BiaGueSYy/gE/5+3CkArB4xRkFqoDa+exHvDN8WAPhIohTyYizXsT0FpYnWTyEJp Uzy94u+xFMi8LSBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E95C713A92; Mon, 28 Feb 2022 08:36:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id q7DRN52JHGIkPgAAMHmgww (envelope-from ); Mon, 28 Feb 2022 08:36:45 +0000 Message-ID: <7e548cc2-8c4b-8ba4-333e-f7e72b221beb@suse.cz> Date: Mon, 28 Feb 2022 09:36:45 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] configure: add --disable-fix-includes Content-Language: en-US To: Allan McRae , Jakub Jelinek , Richard Biener Cc: GCC Patches References: <417eca08-e1ad-538e-c39a-388e20e2fcca@suse.cz> <20220204133018.GD2646553@tucnak> <5e873856-28d1-817a-3a70-221c1e546fda@suse.cz> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Feb 2022 08:36:49 -0000 On 2/5/22 03:26, Allan McRae wrote: > On 5/2/22 01:22, Martin Liška wrote: >> On 2/4/22 14:30, Jakub Jelinek via Gcc-patches wrote: >>> We don't ship any include-fixed headers in Fedora/RHEL. >> >> Removing include-fixed from an installed folder, I see: >> >> make[2]: Entering directory '/home/marxin/Programming/postgres/src/common' >> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O3 -march=native -flto=auto -DFRONTEND -I. -I../../src/common -I../../src/include  -D_GNU_SOURCE -DVAL_CC="\"gcc\"" -DVAL_CPPFLAGS="\"-D_GNU_SOURCE\"" -DVAL_CFLAGS="\"-Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -O3 -march=native -flto=auto\"" -DVAL_CFLAGS_SL="\"-fPIC\"" -DVAL_LDFLAGS="\"-O3 -march=native -flto=auto -Wl,--as-needed -Wl,-rpath,'/usr/local/pgsql/lib64',--enable-new-dtags\"" -DVAL_LDFLAGS_EX="\"\"" >> -DVAL_LDFLAGS_SL="\"\"" -DVAL_LIBS="\"-lpgcommon -lpgport -lz -lreadline -lm \""  -c -o pg_lzcompress.o pg_lzcompress.c >> In file included from pg_lzcompress.c:186: >> /usr/include/limits.h:124:26: error: no include path in which to search for limits.h >>    124 | # include_next >>        |                          ^ >> pg_lzcompress.c:226:9: error: ‘INT_MAX’ undeclared here (not in a function) >>    226 |         INT_MAX,                                        /* No upper limit on what we'll try to >>        |         ^~~~~~~ >> pg_lzcompress.c:189:1: note: ‘INT_MAX’ is defined in header ‘’; did you forget to ‘#include ’? >>    188 | #include "common/pg_lzcompress.h" >>    +++ |+#include >> >> How do you solve this in Fedora/RHEL? > > The Fedora gcc.spec file has this: > > mv $FULLPATH/include-fixed/syslimits.h $FULLPATH/include/syslimits.h > mv $FULLPATH/include-fixed/limits.h $FULLPATH/include/limits.h Yes, I noticed that as well. > > My understanding are these are not real fixinclude processed headers. You are correct. I've just prepared a patch that would exclude these 2 header files from include-fixed. I'm planning the patch for next stage1. Martin > > Allan