From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2070.outbound.protection.outlook.com [40.107.104.70]) by sourceware.org (Postfix) with ESMTPS id A80733858C78 for ; Tue, 28 Nov 2023 16:14:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A80733858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A80733858C78 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.70 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701188085; cv=pass; b=VaujwzEu+0OEgsOBww/ztX5CI/rsySBjAYI+KPe4FCifph6IP9t5wHWZOI2mWwnDFkKRPtY9pEskWvvwOFcBtmOpNrxGNdlwcjVjyzsKDO8EiJKWFvhAfmkdiA/Fv9Zq1ktAfmp5tmAHX4P83UyuIEVFk6PoCjanFYrADpekqTE= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1701188085; c=relaxed/simple; bh=VVn3L4RR7Iw+KZ80nf21+foC/BsRYQB8X+FjheVZgfI=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=EV1/qMXSPddnOCi0QMrOKtAX5rT/dsnzRQO3HI/JRhSNnSKHsQE5Z6auQfJAwesYWVDy3oU+2Wofkm5Z7UGZdzRloiRiJ7CP46ZFE82lStQaFOYMVk4phmwbIp3k80yzcoHjbgfW0BawL7fppJi1bLAfn14FSuo0upiJIJPRarY= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=a3qRCopgCojeDI20JLORTOJiL0STW9/rh3DhpcnGxHkbl7SheM9VLIlCGoEA8SPP0QVYK7zs9mPlnADkg3j4ZYqDh280/3/jn9xrrObrZm1kMVj5Q1oMEfGyHFPf9gyYozux2Kr2VQUBZvdmzC6KGkF6GO+gDxw5W3QFryeD3v/EiD3ryjFo3xkxBmzypdP3u57hmw7dNvvuE7TiF3L1S3+ZIPm7FXi4Xp89uLb+00SjkP9H1t9WvDBWcq7MLI9XoAV/suFzMYQtcT5T/Pgxs9BmiOhIi9i3mA7huIX2TRLTf1D0upbyi5XYjwC83+VT4ACw6JYunrBd2DnKo2SRig== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bwJWZMQ88lVcprNFRGfuIPZPKOp84+glUiXJkFJjE7g=; b=kv3oD7zJbZ/x0m2KdG3HY+8FbY44zUCt/lgE2RG+VWfOuhaiNhkJKVScJgeOFyXrthBSalARfQNFFrnnkdzvGD7YrdpOBfbdnv0fSHwkpZsWAc7P3IKh9OtA6KoaDg3ydnrRBt8BDd58OA85UDkVnX8ZqGINw2UC/9g6GqETgZWRRsx/S1vqHrRoXTaAv3sHBp2pHMpIfzFxJ4JFnn6FIoWzPc9S5O6OjLsrlj7yZrocdeilbf69Mi770dPZyMouilcv9Use9ONhisF5tIr5VqKZISwEHEulE9fqq8G5PnWnJqW/LpvwcPQ+HPnS/qkwaJnoHGlCD3ISeccvbWxKTA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=gcc.gnu.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bwJWZMQ88lVcprNFRGfuIPZPKOp84+glUiXJkFJjE7g=; b=8gnu8dAKkqGAbI0Xo89vcW/VOQiaB7Fcwkpcpe86ofQU+hKHCF8EJwOeEyHHp5D3J0Wb+FheTVr8u5fqGQ7FM3U2SsJhv4CTnYt6kFngq0D/ae+ZPDeuBZ16xUDFf/Ag0ewS32PZUug+Eq1yINKURKYTWPzR0+uclv6ksGXjPHs= Received: from DB9PR05CA0004.eurprd05.prod.outlook.com (2603:10a6:10:1da::9) by PAXPR08MB6671.eurprd08.prod.outlook.com (2603:10a6:102:13b::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.28; Tue, 28 Nov 2023 16:14:41 +0000 Received: from DU6PEPF00009526.eurprd02.prod.outlook.com (2603:10a6:10:1da:cafe::1a) by DB9PR05CA0004.outlook.office365.com (2603:10a6:10:1da::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.27 via Frontend Transport; Tue, 28 Nov 2023 16:14:41 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF00009526.mail.protection.outlook.com (10.167.8.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.17 via Frontend Transport; Tue, 28 Nov 2023 16:14:41 +0000 Received: ("Tessian outbound 385ad2f98d71:v228"); Tue, 28 Nov 2023 16:14:40 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 32fe5560f924e223 X-CR-MTA-TID: 64aa7808 Received: from 262522fb4e5c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 0F6535B3-8C43-4362-A7F1-143412E8AFFA.1; Tue, 28 Nov 2023 16:14:28 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 262522fb4e5c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 28 Nov 2023 16:14:28 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7tUemsk2DQiK5lafUbvTPsbe7ARiLI++QeEZYzc8nCLdaFoe4bANiV+nh89iQto3dfM6sDTz4WpX80vhO/kI8gB3otzZU1LND3wRYquhG2NY9rPHDZZDNac+nBnes1+c5haFeTdepasz0KLl3RhG77ixsEP43UDB+Jb6bdFKgaTqcRYiIDHEceojJ+JHy63zKPuHWNBRgqTomkXZ48tLxkbQG+9OICdQs+RNJw8aM74TfMKadc0J5PU7JGvKu854uGmsqRo2KmY7E0BoLMPToWaaUW7TPGNtBovUON5wyzgbt554m89xKe2wgr7WjhrYVDCcTus0HxOc83BxOsHhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bwJWZMQ88lVcprNFRGfuIPZPKOp84+glUiXJkFJjE7g=; b=oAvUc2Nd3hKg4yU5shxQAlrs1qaR59qaGS14fJnkQuGusHkN2MB6UtVQ/ISqi44IJopmSfdB+db9ruNFWgI9r5thjJnfFyUUJZs+eQfGO/lqxtLSi2+sXeUgzs6NwpjxVyz+II4GK96N7nn0GhFFwqYrFhaCHi097AOQ3peeJok+4h96zEh+OWsDVmbQhlz2GJI1Zd8OREdKUrOLQbtTgMZ+jBl0nfe12IEaJn6/5X4KV4cTlQXpz4vccw70s7DizBUPaAqJ5NSyw4LT1/KVoCwDgHwa5AGTGcFhXtZLo2g5Ol3hsdOqqHumBRhYpN+hqVXa8Qy9HOgRjKmkXW2x5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bwJWZMQ88lVcprNFRGfuIPZPKOp84+glUiXJkFJjE7g=; b=8gnu8dAKkqGAbI0Xo89vcW/VOQiaB7Fcwkpcpe86ofQU+hKHCF8EJwOeEyHHp5D3J0Wb+FheTVr8u5fqGQ7FM3U2SsJhv4CTnYt6kFngq0D/ae+ZPDeuBZ16xUDFf/Ag0ewS32PZUug+Eq1yINKURKYTWPzR0+uclv6ksGXjPHs= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DBBPR08MB6091.eurprd08.prod.outlook.com (2603:10a6:10:1f4::5) by DB9PR08MB9801.eurprd08.prod.outlook.com (2603:10a6:10:462::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.29; Tue, 28 Nov 2023 16:14:26 +0000 Received: from DBBPR08MB6091.eurprd08.prod.outlook.com ([fe80::adea:b196:c278:cc83]) by DBBPR08MB6091.eurprd08.prod.outlook.com ([fe80::adea:b196:c278:cc83%7]) with mapi id 15.20.7025.022; Tue, 28 Nov 2023 16:14:26 +0000 Message-ID: <7e6d93bf-ba5d-4770-88ca-9aaa9741d4b3@arm.com> Date: Tue, 28 Nov 2023 16:14:29 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Add a REG_P check for inc and dec for Arm MVE To: Christophe Lyon Cc: "gcc-patches@gcc.gnu.org" , Richard Earnshaw , Richard Sandiford , Kyrylo Tkachov References: <6522a7d2-63a9-477a-a4b3-6069d83de0c0@arm.com> Content-Language: en-US From: Saurabh Jha In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0296.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:38f::10) To DBBPR08MB6091.eurprd08.prod.outlook.com (2603:10a6:10:1f4::5) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DBBPR08MB6091:EE_|DB9PR08MB9801:EE_|DU6PEPF00009526:EE_|PAXPR08MB6671:EE_ X-MS-Office365-Filtering-Correlation-Id: d8227163-b3a3-4e91-27ae-08dbf02d205c x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: WLwdWL8i+H1ZV/vxVM9+p0fc64wDTsLwe2ljy2rbrsTMC/vhg4+pwlSH29B5TY6Z6v/ChzSFZcqVvBGTjDVMGBTUxPBj93RKaNpd+/wqLpF40kTCQ/yq1XexXAudbIbxuScd+fbMMDdF7133QMtXqwWo/d//BJbmEPY1eXZ4UBwh1mV2nXdPvbR4JdEJQXmrbppZpVojyvhQbNgk0CQZ0DYhln6BfALlzlRSrXU7y1EncuvqIjZ2SeqNJPWXNQLTV6AQ60Z5eDopnkPVYpLqGAv9rPi4Zm/sF+QXBNpp2T12evtvnNR8pD5OVX0iYQ0nnfFejqa6oWye4cwdDaRU3XkIK1POqsMnOmZhcWegRF40CmmSkrYWmRxSCEmr1da7X2m5r6ca7Upq0gasLCKabrjjetHaT9eS4MikXnJqZHDZZBDqFJhrQddj01YArzmKlYA8vyLREM+nzyp8cJey5tUSm674GxfU0Hs2WxaUhMiWlSnC8gmXY4asroRZdfjc8abbwo22GFdXttEss1fme8tvyq/QzSdECLgMxkhJKfBCI/V3pmGmVL6SMcKlzB8WMhb3pNHm7mlCzZH2N4mD7AXTsyFXnblm1MKRZbuuLlVHiswBxQSdv+c7pVvh5xRBkyT172PTrbHk/YjU+BRsJuLgnta7IFyCpwj8oaF+9R1Amx/nh2G7MEwakKA6Ye7V8dIdaEql8ihyVj1iSJdT0Glg/2IX8PQYLGwTD2+FHzg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DBBPR08MB6091.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(366004)(39860400002)(346002)(376002)(230922051799003)(230173577357003)(230273577357003)(186009)(1800799012)(64100799003)(451199024)(31686004)(5660300002)(84970400001)(44832011)(41300700001)(8676002)(8936002)(4326008)(2906002)(316002)(66476007)(6916009)(66946007)(66556008)(54906003)(2616005)(6486002)(478600001)(6506007)(6512007)(53546011)(36756003)(26005)(86362001)(83380400001)(31696002)(38100700002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB9801 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF00009526.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b1b70ef3-1e9d-4151-7757-08dbf02d1755 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uuNnqKsPcTaC+LtULuwhMKxBUb8NZ5dJSpEmZSF/ntgvmPWGeyz90CpVbuyTiMc08rJBKvSQwgpAlIjywKJFdiMRHgX8n8NrbT4RB7OtzHC4tpM9jn97867zieNwzoqIyMLd8QthizrHpK7A9Qf3PMsxzZVywO1UGh2jJSoHO79hLnvCep0DM37hBdROx8124nE+LHfiYchpW8XzEpfodcX95TRodemLC1UoUz3rzGFJ4sUTiXNm3sUO3gOQMwf+uEDu1moiV6hwdgqAVZ8iKT3mCee2Hmj54I/5JcYh4JGqbUJeSM8oqZggsb4+Dm30XACOgZLa4ojtWMhMopJYq1tLRg1qaXveIgbQfXkBDXjqexONWwMWhKZehDibWMjgn9LpQcVlvepyNTy651ZELuUaL5xiq/b1Bde/hUeRwNYMRSTgmFuCQpS1+ibQsLwWq8a58+NgYV90QE2ZlUTQApvCJQ+BeiGz/VZHAy1Si/DchBDpsTcq0sTvOhVYoa/78rdA9083T4R+Mm6tkVRVA1y2VzLJOk7thegtM22p5fsaEhy7xxZ+6Smjgu+W8C5TeTF2MUgoENF5L+jgiX7mfhYdMZ+JdCiLF6K3tFEEsp7EootVEZXM3Kh4WaitPw4hIVvu+JMPSCtrpHEARmWlqZZvWVG9rvyb2CxK2ouKfxMK1fCxL6R9VjwmPG3V5nRWa51P1yxUEf0byWzS+kxB+pfQ2KwiIy3uy49NWGxlpbMu2ZSTVWRj/l+pt0ptZ9ZykfpSrArikM8T+VVEae2zKALWkg3Lo3K5NgQXtf3ESjl9vEUw4+K61en3ZtBkob/OG+Rn2o+0GcgxHK1iXTrFog== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(136003)(39860400002)(346002)(376002)(230273577357003)(230173577357003)(230922051799003)(186009)(64100799003)(82310400011)(1800799012)(451199024)(40470700004)(36840700001)(46966006)(336012)(2616005)(478600001)(53546011)(26005)(6506007)(6512007)(6862004)(47076005)(36860700001)(83380400001)(2906002)(5660300002)(41300700001)(54906003)(6486002)(8676002)(44832011)(8936002)(70206006)(4326008)(70586007)(316002)(40460700003)(356005)(81166007)(31696002)(86362001)(82740400003)(36756003)(31686004)(40480700001)(84970400001)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Nov 2023 16:14:41.0162 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d8227163-b3a3-4e91-27ae-08dbf02d205c X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF00009526.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR08MB6671 X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Christophe, On 11/20/2023 10:12 AM, Christophe Lyon wrote: > Hi Saurabh, > > On Tue, 14 Nov 2023 at 15:51, Kyrylo Tkachov wrote: >> Hi Saurabh, >> >>> -----Original Message----- >>> From: Saurabh Jha >>> Sent: Thursday, November 9, 2023 10:12 AM >>> To: gcc-patches@gcc.gnu.org; Richard Earnshaw >>> ; Richard Sandiford >>> >>> Subject: [PATCH] Add a REG_P check for inc and dec for Arm MVE >>> >>> Hey, >>> >>> This patch tightens mve_vector_mem_operand to reject non-register >>> operands inside {PRE,POST}_{INC,DEC} addresses by introducing a REG_P >>> check. >>> >>> This patch fixes this ICE:https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112337 >>> >>> Okay for trunk? I don't have trunk access so could someone please commit >>> on my behalf? >> Ok. >> >>> Regards, >>> Saurabh >>> >>> gcc/ChangeLog: >>> >>> PR target/112337 >>> * config/arm/arm.cc (mve_vector_mem_operand): Add a REG_P >>> check for INC >>> and DEC operations >>> >>> gcc/testsuite/ChangeLog: >>> >>> PR target/112337 >>> * gcc.target/arm/mve/pr112337.c: Test for REG_P check for INC and >>> DEC >>> operations > This new test fails in our CI (various flavours of target arm-eabi), > with the following: > /gcc.target/arm/mve/pr112337.c:11:18: warning: passing argument 1 of > '__arm_vldrwq_s32' from incompatible pointer type > [-Wincompatible-pointer-types] > In file included from > /home/tcwg-buildslave/workspace/tcwg_gnu_0/abe/snapshots/gcc.git~master/gcc/testsuite/gcc.target/arm/mve/pr112337.c:5: > /arm-eabi/14.0.0/include/arm_mve.h:1752:35: note: expected 'const > int32_t *' {aka 'const long int *'} but argument is of type 'int *' > > I think you should make p a int32_t pointer rather than int, but I am > wondering why you didn't see this problem in your testing? > > Can you check? > > Thanks, > > Christophe Thank you for bringing this up. Unfortunately, I misread the test output in my local testing. Apologies for that. I am working on a fix and will be submitting it soon. Thanks, Saurabh > >> ChangeLog entries should end with a full stop (the git commit hooks enforce it). >> I've adjusted the ChangeLog and pushed this patch for you. >> Thank you for the patch! >> Kyrill >>